On Wed 23-03-16 11:12:26, Ross Zwisler wrote:
On Mon, Mar 21, 2016 at 02:22:48PM +0100, Jan Kara wrote:
> Fault handlers currently take complete_unwritten argument to convert
> unwritten extents after PTEs are updated. However no filesystem uses
> this anymore as the code is racy. Remove the unused argument.
This looks good. Looking at this reminded me that at some point it may be
good to clean up our buffer head flags checks and make sure we don't have
checks that don't make sense - we still check for buffer_unwritten() in
buffer_written(), for instance.
The handling of BH_New isn't consistent among filesystems, either - XFS & ext4
go out of their way to make sure BH_New is not set, while ext2 sets BH_New.
But I think those are separate from this patch, I think.
Yes, that's a separate thing and I think I've handled most of that in the
following patches. Thanks for review!
Jan Kara <jack(a)suse.com>
SUSE Labs, CR