On Tue, Nov 6, 2018 at 6:51 AM Borislav Petkov <bp(a)alien8.de> wrote:
On Thu, Oct 25, 2018 at 06:37:29PM -0600, Vishal Verma wrote:
> The NFIT machine check handler uses the physical address from the 'mce'
> structure, and compares it against information in the ACPI NFIT table to
> determine whether that location lies on an NVDIMM. The mce->addr field
> however may not always be valid, and this is indicated by the
> MCI_STATUS_ADDRV bit in the status field.
> Export mce_usable_address() which already performs validation for the
> address, and use it in the NFIT handler.
> Reported-by: Robert Elliott <elliott(a)hpe.com>
> Fixes: 6839a6d96f4e ("nfit: do an ARS scrub on hitting a latent media
> Cc: stable(a)vger.kernel.org
> Cc: Dan Williams <dan.j.williams(a)intel.com>
> Cc: Tony Luck <tony.luck(a)intel.com>
> Cc: Borislav Petkov <bp(a)alien8.de>
> Signed-off-by: Vishal Verma <vishal.l.verma(a)intel.com>
> arch/x86/include/asm/mce.h | 1 +
> arch/x86/kernel/cpu/mcheck/mce.c | 3 ++-
> drivers/acpi/nfit/mce.c | 4 ++++
> 3 files changed, 7 insertions(+), 1 deletion(-)
Is there any particular reason why is this a separate patch and not part
of the first one?
I recommended the split so the fixes can be tracked and / or reverted
independently if they cause problems.