RE: [ndctl PATCH] ndctl/monitor: make the daemon exit message 'info' level
-----Original Message-----
From: Vishal Verma [mailto:vishal.l.verma@intel.com]
Sent: Friday, August 2, 2019 6:19 AM
To: linux-nvdimm(a)lists.01.org
Cc: Vishal Verma <vishal.l.verma(a)intel.com>; Qi, Fuli/斉 福利
<qi.fuli(a)fujitsu.com>; Dan Williams <dan.j.williams(a)intel.com>; Adam
Borowski <kilobyte(a)angband.pl>
Subject: [ndctl PATCH] ndctl/monitor: make the daemon exit message 'info'
level
The 'ndctl monitor daemon started' message is at an 'info' log level,
but the corresponding exit message (if no DIMMs are found for
monitoring) was only at a 'debug' level. As a result, on a system
without NVDIMMs, the sysadmin might see a 'monitor started' message, but
a monitor wouldn't actually be running. Making the exit message the same
log level ensures that no confusion arises out of this.
Cc: QI Fuli <qi.fuli(a)jp.fujitsu.com>
Cc: Dan Williams <dan.j.williams(a)intel.com>
Reported-by: Adam Borowski <kilobyte(a)angband.pl>
Signed-off-by: Vishal Verma <vishal.l.verma(a)intel.com>
---
ndctl/monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ndctl/monitor.c b/ndctl/monitor.c
index 6829a6b..6e7f038 100644
--- a/ndctl/monitor.c
+++ b/ndctl/monitor.c
@@ -646,7 +646,7 @@ int cmd_monitor(int argc, const char **argv, struct
ndctl_ctx *ctx)
goto out;
if (!mfa.num_dimm) {
- dbg(&monitor, "no dimms to monitor\n");
+ info(&monitor, "no dimms to monitor, exiting\n");
if (!monitor.daemon)
rc = -ENXIO;
goto out;
--
2.20.1
Hi Vishal,
This looks good to me.
Thank you very much.
QI Fuli