Re: [PATCH] dax, pmem: add support for msync

On 09/02/2015 10:04 PM, Ross Zwisler wrote: > On Tue, Sep 01, 2015 at 03:18:41PM +0300, Boaz Harrosh wrote: <> >> Apps expect all these to work: >> 1. open mmap m-write msync ... close >> 2. open mmap m-write fsync ... close >> 3. open mmap m-write unmap ... fsync close >> >> 4. open mmap m-write sync ... > > So basically you made close have an implicit fsync? What about the flow that > looks like this: > > 5. open mmap close m-write > What? no, close means ummap because you need a file* attached to your vma And you miss-understood me, the vm_opts->close is the *unmap* operation not the file::close() operation. I meant memory-cl_flush on unmap before the vma goes away.