On Thu, Sep 08, 2016 at 11:21:46PM +0000, Kani, Toshimitsu wrote:
On Thu, 2016-09-08 at 07:48 -0600, Kani, Toshimitsu wrote:
> On Thu, 2016-09-08 at 13:57 +0300, Kirill A. Shutemov wrote:
> > On Mon, Aug 29, 2016 at 10:00:43PM +0000, Kani, Toshimitsu wrote:
> > >
> > > Looking further, these shmem_huge handlings only check pre-
> > > conditions. So, we should be able to make shmem_get_unmapped_are
> > > a() as a wrapper, which checks such shmem-specific conitions, and
> > > then call __thp_get_unmapped_area() for the actual work. All
> > > DAX-specific checks are performed in thp_get_unmapped_area() as
> > > well. We can make __thp_get_unmapped_area() as a common
> > > function.
> > >
> > > I'd prefer to make such change as a separate item,
> > Do you have plan to submit such change?
> Yes, I will submit the change once I finish testing.
I found a bug in the current code, and need some clarification. The
if-statement below is reverted.
Yeah. It was repored by Hillf. The fixup got lost. :(
Could you post a proper patch with the fix?
I would be nice to credit Hillf there too.
Kirill A. Shutemov