Re: [Linux-nvdimm] [PATCH v2 11/20] libnd, nd_pmem: add libnd support to the pmem driver
On Tue, Apr 28, 2015 at 3:58 PM, Andy Lutomirski <luto(a)amacapital.net> wrote:
On Tue, Apr 28, 2015 at 3:21 PM, Phil Pokorny
<ppokorny(a)penguincomputing.com> wrote:
> On Tue, Apr 28, 2015 at 2:04 PM, Andy Lutomirski <luto(a)amacapital.net> wrote:
>> On Tue, Apr 28, 2015 at 11:25 AM, Dan Williams <dan.j.williams(a)intel.com>
wrote:
[..]
This is such a mess that I think this driver should maybe flat-out
refuse to load in this type of configuration without some scary module
option. I have some NVDIMMs that report as type 12 but need two extra
out-of-tree drivers to work safely. First, they need i2c_imc or the
equivalent (I'll try to resubmit that soon). Second, they need secret
magic NDAed register poking. The latter is very problematic.
At the very least, I think we should discourage people who don't
really know what they're doing from using this driver without care.
The benefit of the type-12 experiment having not made it very far out
of the lab is that it may be feasible to whitelist known platforms
where we believe ADR is available. Otherwise, the presence of the
NFIT asserts platform persistent memory support.