On Wed, Jun 29, 2016 at 4:19 PM, Verma, Vishal L
On Wed, 2016-06-29 at 16:12 -0700, Dan Williams wrote:
> On Wed, Jun 29, 2016 at 4:00 PM, Vishal Verma <vishal.l.verma(a)intel.co
> m> wrote:
> > For the debug prints in acpi_nfit_ctl(), all the prints except the
> > input
> > buffer dump printed the command name. Make this also do the same for
> > better readability.
> > Cc: Dan Williams <dan.j.williams(a)intel.com>
> > Cc: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com>
> > Signed-off-by: Vishal Verma <vishal.l.verma(a)intel.com>
> > ---
> > drivers/acpi/nfit.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> We used to do this, but nvdimm_cmd_name() currently only knows the
> names for the "Intel" DSMs. At a minimum we should force cmd_name to
> "unknown" for the other formats until support is added.
Looks like both the cmd_name functions (for bus and dimm) already do
return 'unknown' when a match isn't found?
If the value is out of range, but if the cmd number is < 10 it will
print the Intel name which might be wrong. nvdimm_cmd_name() needs to
take a new 'family id' parameter.