3:40 p.m.
Fix this build warning:
warning: 'phys' may be used uninitialized in this function
[-Wuninitialized]
As reported here:
https://lkml.org/lkml/2017/10/16/152
This should have no functional change because you can only get into the if
statement in dax_pgoff_to_phys() that is complaining about 'phys' being
uninitialized if you broke out early in the above loop, in which case
'phys' will be set.
Signed-off-by: Ross Zwisler <ross.zwisler(a)linux.intel.com>
---
drivers/dax/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/device.c b/drivers/dax/device.c
index e9f3b3e..4aca0a2 100644
--- a/drivers/dax/device.c
+++ b/drivers/dax/device.c
@@ -222,7 +222,7 @@ __weak phys_addr_t dax_pgoff_to_phys(struct dev_dax *dev_dax, pgoff_t
pgoff,
unsigned long size)
{
struct resource *res;
- phys_addr_t phys;
+ phys_addr_t phys = 0;
int i;
for (i = 0; i < dev_dax->num_resources; i++) {
--
2.9.5
3:40 p.m.
New subject: [PATCH 2/2] MAINTAINERS: Add entry for device DAX
And update the entry for filesystem DAX to differentiate them.
Signed-off-by: Ross Zwisler <ross.zwisler(a)linux.intel.com>
---
MAINTAINERS | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a74227a..b2b2e75 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4162,7 +4162,7 @@ L: linux-i2c(a)vger.kernel.org
S: Maintained
F: drivers/i2c/busses/i2c-diolan-u2c.c
-DIRECT ACCESS (DAX)
+FILESYSTEM DIRECT ACCESS (DAX)
M: Matthew Wilcox <mawilcox(a)microsoft.com>
M: Ross Zwisler <ross.zwisler(a)linux.intel.com>
L: linux-fsdevel(a)vger.kernel.org
@@ -4171,6 +4171,12 @@ F: fs/dax.c
F: include/linux/dax.h
F: include/trace/events/fs_dax.h
+DEVICE DIRECT ACCESS (DAX)
+M: Dan Williams <dan.j.williams(a)intel.com>
+L: linux-nvdimm(a)lists.01.org
+S: Supported
+F: drivers/dax/
+
DIRECTORY NOTIFICATION (DNOTIFY)
M: Jan Kara <jack(a)suse.cz>
R: Amir Goldstein <amir73il(a)gmail.com>
--
2.9.5
4:12 p.m.
New subject: [PATCH 2/2] MAINTAINERS: Add entry for device DAX
On Wed, Oct 18, 2017 at 8:40 AM, Ross Zwisler
<ross.zwisler(a)linux.intel.com> wrote:
And update the entry for filesystem DAX to differentiate them.
Signed-off-by: Ross Zwisler <ross.zwisler(a)linux.intel.com>
---
MAINTAINERS | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a74227a..b2b2e75 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4162,7 +4162,7 @@ L: linux-i2c(a)vger.kernel.org
S: Maintained
F: drivers/i2c/busses/i2c-diolan-u2c.c
-DIRECT ACCESS (DAX)
+FILESYSTEM DIRECT ACCESS (DAX)
M: Matthew Wilcox <mawilcox(a)microsoft.com>
M: Ross Zwisler <ross.zwisler(a)linux.intel.com>
L: linux-fsdevel(a)vger.kernel.org
@@ -4171,6 +4171,12 @@ F: fs/dax.c
F: include/linux/dax.h
F: include/trace/events/fs_dax.h
+DEVICE DIRECT ACCESS (DAX)
+M: Dan Williams <dan.j.williams(a)intel.com>
+L: linux-nvdimm(a)lists.01.org
+S: Supported
+F: drivers/dax/
+
I guess I had a good run hiding from get_maintainers.pl...
Applied for 4.15.
3:56 p.m.
On Wed, Oct 18, 2017 at 8:40 AM, Ross Zwisler
<ross.zwisler(a)linux.intel.com> wrote:
Fix this build warning:
warning: 'phys' may be used uninitialized in this function
[-Wuninitialized]
As reported here:
https://lkml.org/lkml/2017/10/16/152
This should have no functional change because you can only get into the if
statement in dax_pgoff_to_phys() that is complaining about 'phys' being
uninitialized if you broke out early in the above loop, in which case
'phys' will be set.
Then the compiler is wrong.
Signed-off-by: Ross Zwisler <ross.zwisler(a)linux.intel.com>
---
drivers/dax/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/device.c b/drivers/dax/device.c
index e9f3b3e..4aca0a2 100644
--- a/drivers/dax/device.c
+++ b/drivers/dax/device.c
@@ -222,7 +222,7 @@ __weak phys_addr_t dax_pgoff_to_phys(struct dev_dax *dev_dax, pgoff_t
pgoff,
unsigned long size)
{
struct resource *res;
- phys_addr_t phys;
+ phys_addr_t phys = 0;
We have uninitialized_var() for silencing the compiler, and since the
report is bogus we might note with a comment which gcc had a problem
with this routine.
6:21 p.m.
New subject: [PATCH v2] dev/dax: fix uninitialized variable build warning
Fix this build warning:
warning: 'phys' may be used uninitialized in this function
[-Wuninitialized]
As reported here:
https://lkml.org/lkml/2017/10/16/152
http://kisskb.ellerman.id.au/kisskb/buildresult/13181373/log/
Signed-off-by: Ross Zwisler <ross.zwisler(a)linux.intel.com>
---
drivers/dax/device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dax/device.c b/drivers/dax/device.c
index e9f3b3e..6833ada 100644
--- a/drivers/dax/device.c
+++ b/drivers/dax/device.c
@@ -222,7 +222,8 @@ __weak phys_addr_t dax_pgoff_to_phys(struct dev_dax *dev_dax, pgoff_t
pgoff,
unsigned long size)
{
struct resource *res;
- phys_addr_t phys;
+ /* gcc-4.6.3-nolibc for i386 complains that this is uninitialized */
+ phys_addr_t uninitialized_var(phys);
int i;
for (i = 0; i < dev_dax->num_resources; i++) {
--
2.9.5
12:09 a.m.
New subject: [PATCH v2] dev/dax: fix uninitialized variable build warning
On Wed, Oct 18, 2017 at 11:21 AM, Ross Zwisler
<ross.zwisler(a)linux.intel.com> wrote:
Fix this build warning:
warning: 'phys' may be used uninitialized in this function
[-Wuninitialized]
As reported here:
https://lkml.org/lkml/2017/10/16/152
http://kisskb.ellerman.id.au/kisskb/buildresult/13181373/log/
Signed-off-by: Ross Zwisler <ross.zwisler(a)linux.intel.com>
---
drivers/dax/device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dax/device.c b/drivers/dax/device.c
index e9f3b3e..6833ada 100644
--- a/drivers/dax/device.c
+++ b/drivers/dax/device.c
@@ -222,7 +222,8 @@ __weak phys_addr_t dax_pgoff_to_phys(struct dev_dax *dev_dax, pgoff_t
pgoff,
unsigned long size)
{
struct resource *res;
- phys_addr_t phys;
+ /* gcc-4.6.3-nolibc for i386 complains that this is uninitialized */
+ phys_addr_t uninitialized_var(phys);
Thanks Ross, applied.
1717
days inactive
1719
days old
5 comments
2 participants
participants (2)
-
Dan Williams -
Ross Zwisler