Hi Santosh, Thanks for your review, and sorry for my mistake. I will send the v2 soon. On 2021/4/20 14:35, Santosh Sivaraj wrote: > > Hi Zou, > > Zou Wei <zou_wei(a)huawei.com&gt; writes: > >> The sparse tool complains as follows: >> >> tools/testing/nvdimm/test/iomap.c:65:14: warning: >> symbol '__nfit_test_ioremap' was not declared. Should it be static? >> >> This symbol is not used outside of security.c, so this > > s/security.c/iomap.c/ > > Thanks, > Santosh > >> commit marks it static. >> >> Reported-by: Hulk Robot <hulkci(a)huawei.com&gt; >> Signed-off-by: Zou Wei <zou_wei(a)huawei.com&gt; >> --- >> tools/testing/nvdimm/test/iomap.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c >> index c62d372..ed563bd 100644 >> --- a/tools/testing/nvdimm/test/iomap.c >> +++ b/tools/testing/nvdimm/test/iomap.c >> @@ -62,7 +62,7 @@ struct nfit_test_resource *get_nfit_res(resource_size_t resource) >> } >> EXPORT_SYMBOL(get_nfit_res); >> >> -void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size, >> +static void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size, >> void __iomem *(*fallback_fn)(resource_size_t, unsigned long)) >> { >> struct nfit_test_resource *nfit_res = get_nfit_res(offset); >> -- >> 2.6.2 >> _______________________________________________ >> Linux-nvdimm mailing list -- linux-nvdimm(a)lists.01.org >> To unsubscribe send an email to linux-nvdimm-leave(a)lists.01.org > . >