When processing all namespaces and no namespaces exist user gets the default -ENXIO. Set default rc to 0 when processing all namespaces. This avoids confusing error message printed in addition to the message saying 0 namespaces were affected. Before: # ndctl check-namespace all namespace0.0: namespace_check: namespace0.0: check aborted, namespace online error checking namespaces: Device or resource busy checked 0 namespaces # ndctl disable-namespace all disabled 1 namespace # ndctl check-namespace all namespace0.0: namespace_check: Unable to recover any BTT info blocks error checking namespaces: No such device or address checked 0 namespaces # ndctl destroy-namespace all destroyed 1 namespace # ndctl check-namespace all error checking namespaces: No such device or address checked 0 namespaces # ndctl destroy-namespace all error destroying namespaces: No such device or address destroyed 0 namespaces After: # ndctl check-namespace all namespace0.0: namespace_check: namespace0.0: check aborted, namespace online error checking namespaces: Device or resource busy checked 0 namespaces # ndctl disable-namespace namespace0.0 disabled 1 namespace # ndctl check-namespace all namespace0.0: namespace_check: Unable to recover any BTT info blocks error checking namespaces: No such device or address checked 0 namespaces # ndctl destroy-namespace all destroyed 1 namespace # ndctl check-namespace all checked 0 namespaces # ndctl destroy-namespace all destroyed 0 namespaces # ndctl destroy-namespace all destroyed 0 namespaces Note: this does change the return value from -ENXIO to 0 in the cases when no namespaces exist and processing all namespaces was requested. Link: https://patchwork.kernel.org/patch/11681431/ Signed-off-by: Michal Suchanek <msuchanek(a)suse.de&gt; Reviewed-by: Santosh S <santosh(a)fossix.org&gt; --- v2: fix the error code references in the commit message --- ndctl/namespace.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ndctl/namespace.c b/ndctl/namespace.c index 3fabe4799d75..835f4076008a 100644 --- a/ndctl/namespace.c +++ b/ndctl/namespace.c @@ -2112,6 +2112,9 @@ static int do_xaction_namespace(const char *namespace, if (!namespace && action != ACTION_CREATE) return rc; + if (namespace && (strcmp(namespace, "all") == 0)) + rc = 0; + if (verbose) ndctl_set_log_priority(ctx, LOG_DEBUG); -- 2.28.0

On Fri, Aug 28, 2020 at 11:51:05AM +0200, Michal Suchanek wrote: Effectively reverts the two below commits: Fixes: b9cb03f6d5a8 ("ndctl/namespace: Fix enable-namespace error for seed namespaces") Fixes: e01045e58ad5 ("ndctl/namespace: Fix destroy-namespace accounting relative to seed devices") > Link: https://patchwork.kernel.org/patch/11739975/ > Signed-off-by: Santosh Sivaraj <santosh(a)fossix.org&gt; > [rebased on top of the previous patches] > Signed-off-by: Michal Suchanek <msuchanek(a)suse.de&gt; > --- > ndctl/lib/libndctl.c | 5 ----- > ndctl/namespace.c | 11 ----------- > 2 files changed, 16 deletions(-) > > diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c > index 952192c4c6b5..ecced5a3ae0b 100644 > --- a/ndctl/lib/libndctl.c > +++ b/ndctl/lib/libndctl.c > @@ -4253,16 +4253,11 @@ NDCTL_EXPORT int ndctl_namespace_enable(struct ndctl_namespace *ndns) > const char *devname = ndctl_namespace_get_devname(ndns); > struct ndctl_ctx *ctx = ndctl_namespace_get_ctx(ndns); > struct ndctl_region *region = ndns->region; > - unsigned long long size = ndctl_namespace_get_size(ndns); > int rc; > > if (ndctl_namespace_is_enabled(ndns)) > return 0; > > - /* Don't try to enable idle namespace (no capacity allocated) */ > - if (size == 0) > - return -ENXIO; > - > rc = ndctl_bind(ctx, ndns->module, devname); > > /* > diff --git a/ndctl/namespace.c b/ndctl/namespace.c > index 835f4076008a..65bca9191603 100644 > --- a/ndctl/namespace.c > +++ b/ndctl/namespace.c > @@ -1094,7 +1094,6 @@ static int namespace_destroy(struct ndctl_region *region, > struct ndctl_namespace *ndns) > { > const char *devname = ndctl_namespace_get_devname(ndns); > - unsigned long long size; > bool did_zero = false; > int rc; > > @@ -1139,19 +1138,9 @@ static int namespace_destroy(struct ndctl_region *region, > goto out; > } > > - size = ndctl_namespace_get_size(ndns); > - > rc = ndctl_namespace_delete(ndns); > if (rc) > debug("%s: failed to reclaim\n", devname); > - > - /* > - * Don't report a destroyed namespace when no capacity was > - * allocated. > - */ > - if (size == 0 && rc == 0) > - rc = 1; > - > out: > return rc; > } > -- > 2.28.0 >