5:23 a.m.
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://github.com/0day-ci/linux
Herbert-Xu/rhashtable-Handle-table-allocation-failure-during-insertion/20170212-030221
commit 5d60de5ff12fb1e966c863bcb41c1e2bdde66c50
Author: Herbert Xu <herbert(a)gondor.apana.org.au>
AuthorDate: Sat Feb 11 19:26:47 2017 +0800
Commit: 0day robot <fengguang.wu(a)intel.com>
CommitDate: Sun Feb 12 03:02:26 2017 +0800
rhashtable: Add nested tables
This patch adds code that handles GFP_ATOMIC kmalloc failure on
insertion. As we cannot use vmalloc, we solve it by making our
hash table nested. That is, we allocate single pages at each level
and reach our desired table size by nesting them.
When a nested table is created, only a single page is allocated
at the top-level. Lower levels are allocated on demand during
insertion. Therefore for each insertion to succeed, only two
(non-consecutive) pages are needed.
After a nested table is created, a rehash will be scheduled in
order to switch to a vmalloced table as soon as possible. Also,
the rehash code will never rehash into a nested table. If we
detect a nested table during a rehash, the rehash will be aborted
and a new rehash will be scheduled.
Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au>
+------------------------------------------------------------------+------------+------------+------------------+
| | eadcee1e3a |
5d60de5ff1 | v4.10-rc8_021716 |
+------------------------------------------------------------------+------------+------------+------------------+
| boot_successes | 0 | 0
| 9 |
| boot_failures | 177 | 48
| 82 |
| Kernel_panic-not_syncing:softlockup:hung_tasks | 177 | 48
| 14 |
| INFO:suspicious_RCU_usage | 0 | 39
| 64 |
| BUG:KASAN:user-memory-access_on_address | 0 | 0
| 16 |
| BUG:unable_to_handle_kernel | 0 | 0
| 18 |
| Oops | 0 | 0
| 18 |
| Kernel_panic-not_syncing:Fatal_exception | 0 | 0
| 18 |
| BUG:kernel_hang_in_test_stage | 0 | 0
| 19 |
| WARNING:at_kernel/sched/sched.h:#set_next_entity | 0 | 0
| 15 |
| INFO:possible_circular_locking_dependency_detected | 0 | 0
| 4 |
| WARNING:at_include/linux/cpumask.h:#find_get_context | 0 | 0
| 2 |
| invoked_oom-killer:gfp_mask=0x | 0 | 0
| 4 |
| Mem-Info | 0 | 0
| 4 |
| Kernel_panic-not_syncing:Out_of_memory_and_no_killable_processes | 0 | 0
| 4 |
| Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode= | 0 | 0
| 7 |
+------------------------------------------------------------------+------------+------------+------------------+
[ 9.022401] Testing concurrent rhashtable access from 10 threads
[ 15.800003]
[ 15.801145] ===============================
[ 15.801802] [ INFO: suspicious RCU usage. ]
[ 15.802476] 4.10.0-rc7-00090-g5d60de5 #1 Not tainted
[ 15.803235] -------------------------------
[ 15.803866] lib/rhashtable.c:1126 suspicious rcu_dereference_protected() usage!
[ 15.805167]
[ 15.805167] other info that might help us debug this:
[ 15.805167]
[ 15.806269]
[ 15.806269] rcu_scheduler_active = 2, debug_locks = 1
[ 15.807206] 1 lock held by rhashtable_thra/177:
[ 15.807839] #0: (rcu_read_lock){......}, at: [<ffffffff816c761d>]
thread_lookup_test+0xad/0x530
[ 15.809314]
[ 15.809314] stack backtrace:
[ 15.809967] CPU: 0 PID: 177 Comm: rhashtable_thra Not tainted 4.10.0-rc7-00090-g5d60de5
#1
[ 15.811194] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
1.9.3-20161025_171302-gandalf 04/01/2014
[ 15.812688] Call Trace:
[ 15.813071] dump_stack+0x86/0xcd
[ 15.813586] lockdep_rcu_suspicious+0x104/0x110
[ 15.814279] rht_bucket_nested+0xeb/0x220
[ 15.814900] thread_lookup_test+0x215/0x530
[ 15.815602] ? thread_lookup_test+0xad/0x530
[ 15.816284] ? rcu_read_unlock+0x60/0x60
[ 15.816833] ? insert_retry+0x27c/0x5d0
[ 15.817537] ? insert_retry+0x23/0x5d0
[ 15.818271] threadfunc+0x26e/0x8b0
[ 15.818803] ? kstrtos8_from_user+0x150/0x150
[ 15.819486] ? finish_task_switch+0x233/0x2d0
[ 15.820145] ? finish_task_switch+0x1e2/0x2d0
[ 15.820807] ? insert_retry+0x5d0/0x5d0
[ 15.821559] ? trace_hardirqs_on_caller+0x2a6/0x2e0
[ 15.822299] ? __kthread_parkme+0xdf/0x100
[ 15.822928] kthread+0x1cf/0x1e0
[ 15.823446] ? insert_retry+0x5d0/0x5d0
[ 15.824190] ? __kthread_bind_mask+0x80/0x80
[ 15.824831] ret_from_fork+0x31/0x40
[ 15.825455]
[ 15.825698] ===============================
[ 15.826337] [ INFO: suspicious RCU usage. ]
[ 15.826974] 4.10.0-rc7-00090-g5d60de5 #1 Not tainted
[ 15.827720] -------------------------------
[ 15.828385] lib/rhashtable.c:1131 suspicious rcu_dereference_protected() usage!
[ 15.829780]
[ 15.829780] other info that might help us debug this:
[ 15.829780]
[ 15.830975]
[ 15.830975] rcu_scheduler_active = 2, debug_locks = 1
[ 15.831956] 1 lock held by rhashtable_thra/177:
[ 15.832645] #0: (rcu_read_lock){......}, at: [<ffffffff816c761d>]
thread_lookup_test+0xad/0x530
[ 15.834076]
[ 15.834076] stack backtrace:
[ 15.834748] CPU: 0 PID: 177 Comm: rhashtable_thra Not tainted 4.10.0-rc7-00090-g5d60de5
#1
[ 15.835995] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
1.9.3-20161025_171302-gandalf 04/01/2014
[ 15.837514] Call Trace:
[ 15.837895] dump_stack+0x86/0xcd
[ 15.838434] lockdep_rcu_suspicious+0x104/0x110
[ 15.839141] rht_bucket_nested+0x1c7/0x220
[ 15.839771] thread_lookup_test+0x215/0x530
[ 15.840503] ? thread_lookup_test+0xad/0x530
[ 15.841244] ? rcu_read_unlock+0x60/0x60
[ 15.841855] ? insert_retry+0x27c/0x5d0
[ 15.842582] ? insert_retry+0x23/0x5d0
[ 15.843261] threadfunc+0x26e/0x8b0
[ 15.843750] ? kstrtos8_from_user+0x150/0x150
[ 15.844454] ? finish_task_switch+0x233/0x2d0
[ 15.845115] ? finish_task_switch+0x1e2/0x2d0
[ 15.845776] ? insert_retry+0x5d0/0x5d0
[ 15.846529] ? trace_hardirqs_on_caller+0x2a6/0x2e0
[ 15.847269] ? __kthread_parkme+0xdf/0x100
[ 15.847886] kthread+0x1cf/0x1e0
[ 15.848411] ? insert_retry+0x5d0/0x5d0
[ 15.849180] ? __kthread_bind_mask+0x80/0x80
[ 15.849822] ret_from_fork+0x31/0x40
[ 39.288808] Started 10 threads, 0 failed
[ 39.344928] test_printf: all 260 tests passed
[ 39.571877] test_bitmap: all 460506 tests passed
git bisect start 4a46686569061cc1abc34beaa653e8cdf624e06c
7089db84e356562f8ba737c29e472cc42d530dbc --
git bisect good fb084b07b6bff4d415a6528eb7c32dc4306c9eae # 01:05 23+ 13 Merge
'abelloni/at91-dt' into devel-hourly-2017021716
git bisect bad f1ad3ae3cd2dd394a392ddb24d7f56b4c51c3a08 # 01:20 1- 4 Merge
'linux-review/Igor-Pylypiv/net-fix-description-of-skb_find_text-according-to-removed-functionality/20170208-105106'
into devel-hourly-2017021716
git bisect bad 0b86680afda355fa3ed6f9da2716ead53d8d2d48 # 01:35 1- 2 Merge
'linux-review/Saber-Rezvani/net-ethernet-intel-e1000-msleep-is-unreliable-for-anything-20ms/20170210-170301'
into devel-hourly-2017021716
git bisect bad 283fb42d7452688950d67f72e1d6e3be6ccfd675 # 01:44 6- 9 Merge
'linux-review/Ralf-Baechle/NET-mkiss-6pack-Fix-SIOCSIFENCAP-ioctl/20170211-071145'
into devel-hourly-2017021716
git bisect bad 3e08f8ba6a3e162b7709596518ccd8e0a878d57c # 01:55 2- 3 Merge
'baolu/usb/xdbc/v7' into devel-hourly-2017021716
git bisect good 4d06ce5827b265523711a0a26e261cea69677819 # 02:09 44+ 37 Merge
'linux-review/Eric-Dumazet/mlx4-order-0-allocations-and-page-recycling/20170214-041424'
into devel-hourly-2017021716
git bisect good 34f04a2bc6a24c03f6a53e744603c7f89b4bb91e # 02:25 42+ 26 Merge
'linux-review/Krzysztof-Kozlowski/thermal-exynos-Remove-parsing-unused-samsung-tmu_cal_mode-property/20170212-041513'
into devel-hourly-2017021716
git bisect bad 3292006e6ec06517d577151b2b241ba77137b49d # 02:46 2- 10 Merge
'linux-review/Or-Gerlitz/net-mlx5e-Disable-preemption-when-doing-TC-statistics-upcall/20170212-172525'
into devel-hourly-2017021716
git bisect good d80c0b6e7691fc762b4beb9692bc66b02cb8d728 # 02:59 42+ 30 Merge
'linux-review/Bhumika-Goyal/kernel-ksysfs-add-__ro_after_init-to-bin_attribute-structure/20170212-031051'
into devel-hourly-2017021716
git bisect bad 048feb77e408b88db3f867090436ba2d5674bb05 # 03:17 4- 10 Merge
'linux-review/Herbert-Xu/rhashtable-Handle-table-allocation-failure-during-insertion/20170212-030221'
into devel-hourly-2017021716
git bisect good eadcee1e3ae1df7fa6600aa57b76ae9f1a43224b # 03:34 44+ 48 tipc:
Fix tipc_sk_reinit race conditions
git bisect bad 5d60de5ff12fb1e966c863bcb41c1e2bdde66c50 # 03:46 2- 7
rhashtable: Add nested tables
# first bad commit: [5d60de5ff12fb1e966c863bcb41c1e2bdde66c50] rhashtable: Add nested
tables
git bisect good eadcee1e3ae1df7fa6600aa57b76ae9f1a43224b # 04:06 129+ 177 tipc:
Fix tipc_sk_reinit race conditions
# extra tests with CONFIG_DEBUG_INFO_REDUCED
git bisect bad 5d60de5ff12fb1e966c863bcb41c1e2bdde66c50 # 04:25 1- 7
rhashtable: Add nested tables
# extra tests on HEAD of linux-devel/devel-hourly-2017021716
git bisect bad 4a46686569061cc1abc34beaa653e8cdf624e06c # 04:25 0- 82 0day
head guard for 'devel-hourly-2017021716'
# extra tests on tree/branch
linux-review/Herbert-Xu/rhashtable-Handle-table-allocation-failure-during-insertion/20170212-030221
git bisect bad 5d60de5ff12fb1e966c863bcb41c1e2bdde66c50 # 04:32 0- 48
rhashtable: Add nested tables
# extra tests with first bad commit reverted
git bisect good 81fb16e31647be56d7f20017a3e99828f6f1cf2a # 04:55 121+ 121 Revert
"rhashtable: Add nested tables"
# extra tests on tree/branch linus/master
git bisect good 2fe1e8a7b2f4dcac3fcb07ff06b0ae7396201fd6 # 05:35 121+ 61 Merge
tag 'powerpc-4.10-5' of
git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
# extra tests on tree/branch linux-next/master
git bisect good 4ce4a759a3e221b5265ebd03c2f8888b69a7cf3e # 07:38 120+ 67 Add
linux-next specific files for 20170217
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/lkp Intel Corporation
2:39 p.m.
On Sat, Feb 18, 2017 at 01:23:31PM +0800, Fengguang Wu wrote:
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://github.com/0day-ci/linux
Herbert-Xu/rhashtable-Handle-table-allocation-failure-during-insertion/20170212-030221
commit 5d60de5ff12fb1e966c863bcb41c1e2bdde66c50
Author: Herbert Xu <herbert(a)gondor.apana.org.au>
AuthorDate: Sat Feb 11 19:26:47 2017 +0800
Commit: 0day robot <fengguang.wu(a)intel.com>
CommitDate: Sun Feb 12 03:02:26 2017 +0800
rhashtable: Add nested tables
This patch adds code that handles GFP_ATOMIC kmalloc failure on
insertion. As we cannot use vmalloc, we solve it by making our
hash table nested. That is, we allocate single pages at each level
and reach our desired table size by nesting them.
When a nested table is created, only a single page is allocated
at the top-level. Lower levels are allocated on demand during
insertion. Therefore for each insertion to succeed, only two
(non-consecutive) pages are needed.
After a nested table is created, a rehash will be scheduled in
order to switch to a vmalloced table as soon as possible. Also,
the rehash code will never rehash into a nested table. If we
detect a nested table during a rehash, the rehash will be aborted
and a new rehash will be scheduled.
Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au>
+------------------------------------------------------------------+------------+------------+------------------+
| | eadcee1e3a |
5d60de5ff1 | v4.10-rc8_021716 |
+------------------------------------------------------------------+------------+------------+------------------+
| boot_successes | 0 | 0
| 9 |
| boot_failures | 177 | 48
| 82 |
| Kernel_panic-not_syncing:softlockup:hung_tasks | 177 | 48
| 14 |
| INFO:suspicious_RCU_usage | 0 | 39
| 64 |
| BUG:KASAN:user-memory-access_on_address | 0 | 0
| 16 |
| BUG:unable_to_handle_kernel | 0 | 0
| 18 |
| Oops | 0 | 0
| 18 |
| Kernel_panic-not_syncing:Fatal_exception | 0 | 0
| 18 |
| BUG:kernel_hang_in_test_stage | 0 | 0
| 19 |
| WARNING:at_kernel/sched/sched.h:#set_next_entity | 0 | 0
| 15 |
| INFO:possible_circular_locking_dependency_detected | 0 | 0
| 4 |
| WARNING:at_include/linux/cpumask.h:#find_get_context | 0 | 0
| 2 |
| invoked_oom-killer:gfp_mask=0x | 0 | 0
| 4 |
| Mem-Info | 0 | 0
| 4 |
| Kernel_panic-not_syncing:Out_of_memory_and_no_killable_processes | 0 | 0
| 4 |
| Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode= | 0 | 0
| 7 |
+------------------------------------------------------------------+------------+------------+------------------+
[ 9.022401] Testing concurrent rhashtable access from 10 threads
[ 15.800003]
[ 15.801145] ===============================
[ 15.801802] [ INFO: suspicious RCU usage. ]
[ 15.802476] 4.10.0-rc7-00090-g5d60de5 #1 Not tainted
[ 15.803235] -------------------------------
[ 15.803866] lib/rhashtable.c:1126 suspicious rcu_dereference_protected() usage!
Sorry, I chose the wrong annotation to fix the previous report.
This patch should fix it completely.
---8<---
Subject: rhashtable: Fix RCU dereference annotation in rht_bucket_nested
The current annotation is wrong as it says that we're only called
under spinlock. In fact it should be marked as under either
spinlock or RCU read lock.
Fixes: da20420f83ea ("rhashtable: Add nested tables")
Reported-by: Fengguang Wu <fengguang.wu(a)intel.com>
Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au>
---
lib/rhashtable.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index fac1a78..c5b9b93 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -1121,12 +1121,13 @@ struct rhash_head __rcu **rht_bucket_nested(const struct
bucket_table *tbl,
union nested_table *ntbl;
ntbl = (union nested_table *)rcu_dereference_raw(tbl->buckets[0]);
- ntbl = rht_dereference_bucket(ntbl[index].table, tbl, hash);
+ ntbl = rht_dereference_bucket_rcu(ntbl[index].table, tbl, hash);
subhash >>= tbl->nest;
while (ntbl && size > (1 << shift)) {
index = subhash & ((1 << shift) - 1);
- ntbl = rht_dereference_bucket(ntbl[index].table, tbl, hash);
+ ntbl = rht_dereference_bucket_rcu(ntbl[index].table,
+ tbl, hash);
size >>= shift;
subhash >>= shift;
}
--
Email: Herbert Xu <herbert(a)gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
2:34 a.m.
From: Herbert Xu <herbert(a)gondor.apana.org.au>
Date: Sat, 25 Feb 2017 22:39:50 +0800
Subject: rhashtable: Fix RCU dereference annotation in
rht_bucket_nested
The current annotation is wrong as it says that we're only called
under spinlock. In fact it should be marked as under either
spinlock or RCU read lock.
Fixes: da20420f83ea ("rhashtable: Add nested tables")
Reported-by: Fengguang Wu <fengguang.wu(a)intel.com>
Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au>
Applied.
4:31 a.m.
On 02/25, Herbert Xu wrote:
On Sat, Feb 18, 2017 at 01:23:31PM +0800, Fengguang Wu wrote:
> Greetings,
>
> 0day kernel testing robot got the below dmesg and the first bad commit is
>
> https://github.com/0day-ci/linux
Herbert-Xu/rhashtable-Handle-table-allocation-failure-during-insertion/20170212-030221
>
> commit 5d60de5ff12fb1e966c863bcb41c1e2bdde66c50
> Author: Herbert Xu <herbert(a)gondor.apana.org.au>
> AuthorDate: Sat Feb 11 19:26:47 2017 +0800
> Commit: 0day robot <fengguang.wu(a)intel.com>
> CommitDate: Sun Feb 12 03:02:26 2017 +0800
>
> rhashtable: Add nested tables
>
> This patch adds code that handles GFP_ATOMIC kmalloc failure on
> insertion. As we cannot use vmalloc, we solve it by making our
> hash table nested. That is, we allocate single pages at each level
> and reach our desired table size by nesting them.
>
> When a nested table is created, only a single page is allocated
> at the top-level. Lower levels are allocated on demand during
> insertion. Therefore for each insertion to succeed, only two
> (non-consecutive) pages are needed.
>
> After a nested table is created, a rehash will be scheduled in
> order to switch to a vmalloced table as soon as possible. Also,
> the rehash code will never rehash into a nested table. If we
> detect a nested table during a rehash, the rehash will be aborted
> and a new rehash will be scheduled.
>
> Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au>
>
>
+------------------------------------------------------------------+------------+------------+------------------+
> | | eadcee1e3a |
5d60de5ff1 | v4.10-rc8_021716 |
>
+------------------------------------------------------------------+------------+------------+------------------+
> | boot_successes | 0 | 0
| 9 |
> | boot_failures | 177 | 48
| 82 |
> | Kernel_panic-not_syncing:softlockup:hung_tasks | 177 | 48
| 14 |
> | INFO:suspicious_RCU_usage | 0 | 39
| 64 |
> | BUG:KASAN:user-memory-access_on_address | 0 | 0
| 16 |
> | BUG:unable_to_handle_kernel | 0 | 0
| 18 |
> | Oops | 0 | 0
| 18 |
> | Kernel_panic-not_syncing:Fatal_exception | 0 | 0
| 18 |
> | BUG:kernel_hang_in_test_stage | 0 | 0
| 19 |
> | WARNING:at_kernel/sched/sched.h:#set_next_entity | 0 | 0
| 15 |
> | INFO:possible_circular_locking_dependency_detected | 0 | 0
| 4 |
> | WARNING:at_include/linux/cpumask.h:#find_get_context | 0 | 0
| 2 |
> | invoked_oom-killer:gfp_mask=0x | 0 | 0
| 4 |
> | Mem-Info | 0 | 0
| 4 |
> | Kernel_panic-not_syncing:Out_of_memory_and_no_killable_processes | 0 | 0
| 4 |
> | Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode= | 0 | 0
| 7 |
>
+------------------------------------------------------------------+------------+------------+------------------+
>
> [ 9.022401] Testing concurrent rhashtable access from 10 threads
> [ 15.800003]
> [ 15.801145] ===============================
> [ 15.801802] [ INFO: suspicious RCU usage. ]
> [ 15.802476] 4.10.0-rc7-00090-g5d60de5 #1 Not tainted
> [ 15.803235] -------------------------------
> [ 15.803866] lib/rhashtable.c:1126 suspicious rcu_dereference_protected() usage!
Sorry, I chose the wrong annotation to fix the previous report.
This patch should fix it completely.
This warning is gone with the fix patch in 0day environment.
Tested-by: Xiaolong Ye <xiaolong.ye(a)intel.com>
Thanks,
Xiaolong
---8<---
Subject: rhashtable: Fix RCU dereference annotation in rht_bucket_nested
The current annotation is wrong as it says that we're only called
under spinlock. In fact it should be marked as under either
spinlock or RCU read lock.
Fixes: da20420f83ea ("rhashtable: Add nested tables")
Reported-by: Fengguang Wu <fengguang.wu(a)intel.com>
Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au>
---
lib/rhashtable.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index fac1a78..c5b9b93 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -1121,12 +1121,13 @@ struct rhash_head __rcu **rht_bucket_nested(const struct
bucket_table *tbl,
union nested_table *ntbl;
ntbl = (union nested_table *)rcu_dereference_raw(tbl->buckets[0]);
- ntbl = rht_dereference_bucket(ntbl[index].table, tbl, hash);
+ ntbl = rht_dereference_bucket_rcu(ntbl[index].table, tbl, hash);
subhash >>= tbl->nest;
while (ntbl && size > (1 << shift)) {
index = subhash & ((1 << shift) - 1);
- ntbl = rht_dereference_bucket(ntbl[index].table, tbl, hash);
+ ntbl = rht_dereference_bucket_rcu(ntbl[index].table,
+ tbl, hash);
size >>= shift;
subhash >>= shift;
}
--
Email: Herbert Xu <herbert(a)gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
LKP mailing list
LKP(a)lists.01.org
https://lists.01.org/mailman/listinfo/lkp
1998
days inactive
2007
days old
3 comments
4 participants
participants (4)
-
David Miller -
Fengguang Wu -
Herbert Xu -
Ye Xiaolong