On Thu, Apr 27, 2017 at 12:20:09AM +0200, Borislav Petkov wrote:
On Wed, Apr 26, 2017 at 02:06:02PM -0700, Luck, Tony wrote:
> Then we'd try to load some other driver: sb_edac, skx_edac, etc. If
> they get through the platform tests to find they are on the right
> cpu model, and they find all the right PCIe devices to access memory
> controller registers ... then they call edac_mc_add_mc() to tell
> EDAC core they want to run things ... and that supplants ghes_edac.
Yeah, but that means a serious EDAC core surgery as we've never
supported more than one EDAC driver. What would be easier, IMO,
is to move the reporting functionality from ghes_edac.c to
drivers/acpi/apei/ghes.c and export only the EDAC tracepoint so that
GHES can call into it. Through a notifier or so.
Ah, that sounds simpler.
This way we'll get rid of the ghes_edac.c thing completely the
functionality will be completely part of ghes.c in drivers/acpi/ and
then we can load our platform drivers just the same.
But that's definitely future work.
I'd still like to apply the oneliner for 4.12 so that the bug Xiaolong
reported doesn't happen. Ok?
Sure. That makes sense.