11:48 p.m.
On 5/17/19 10:17 AM, Miroslav Benes wrote:
Hi,
I noticed that livepatching selftests fail on our master branch
(https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching...).
...
[ adding lkp(a)01.org to this email ]
lkp folks, I was wondering if the kernel selftests were included as part
of the test-bot and if so, do we need to do anything specific to include
the livepatching selftests?
Thanks,
-- Joe
12:31 a.m.
New subject: livepatching selftests failure on current master branch
On Wed, Jun 05, 2019 at 09:48:02AM -0400, Joe Lawrence wrote:
On 5/17/19 10:17 AM, Miroslav Benes wrote:
>Hi,
>
>I noticed that livepatching selftests fail on our master branch
>(https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git/).
>
>...
[ adding lkp(a)01.org to this email ]
lkp folks, I was wondering if the kernel selftests were included as
part of the test-bot and if so, do we need to do anything specific
yes, kernel
selftest is part of regular execution, which includes the livepatching
test. Also the livepatching.git is under our testing. But we may not successfully
bisect all failures.
The mails related to livepatching test or livepatch in last two months are
https://lists.01.org/pipermail/lkp/2019-April/010026.html
https://lists.01.org/pipermail/lkp/2019-May/010218.html
Thanks
to include the livepatching selftests?
Thanks,
-- Joe
_______________________________________________
LKP mailing list
LKP(a)lists.01.org
https://lists.01.org/mailman/listinfo/lkp
12:51 a.m.
New subject: livepatching selftests failure on current master branch
On 6/5/19 10:31 AM, Philip Li wrote:
On Wed, Jun 05, 2019 at 09:48:02AM -0400, Joe Lawrence wrote:
> On 5/17/19 10:17 AM, Miroslav Benes wrote:
>> Hi,
>>
>> I noticed that livepatching selftests fail on our master branch
>>
(https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching...).
>>
>> ...
>
> [ adding lkp(a)01.org to this email ]
>
> lkp folks, I was wondering if the kernel selftests were included as
> part of the test-bot and if so, do we need to do anything specific
yes, kernel selftest is part of regular execution, which includes the livepatching
test. Also the livepatching.git is under our testing...
Hi Philip,
Good to hear. My github tree and Josh's kernel.org tree are included as
(perhaps other livepatching dev trees as well), so the more coverage the
better :)
... But we may not
successfully
bisect all failures.
That's okay, though I guess I'm not clear why there wasn't an email
reporting that the livepatching selftests failed after livepatching.git
was recently updated to include tglx's stack trace fixes.
Do the tests only run for unique commits (ie, will it skip when
livepatching.git updates/merges latest linux tree ??)
Thanks,
-- Joe
10:49 a.m.
New subject: livepatching selftests failure on current master branch
On Wed, Jun 05, 2019 at 10:51:53AM -0400, Joe Lawrence wrote:
On 6/5/19 10:31 AM, Philip Li wrote:
>On Wed, Jun 05, 2019 at 09:48:02AM -0400, Joe Lawrence wrote:
>>On 5/17/19 10:17 AM, Miroslav Benes wrote:
>>>Hi,
>>>
>>>I noticed that livepatching selftests fail on our master branch
>>>(https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git/).
>>>
>>>...
>>
>>[ adding lkp(a)01.org to this email ]
>>
>>lkp folks, I was wondering if the kernel selftests were included as
>>part of the test-bot and if so, do we need to do anything specific
>yes, kernel selftest is part of regular execution, which includes the livepatching
> test. Also the livepatching.git is under our testing...
Hi Philip,
Good to hear. My github tree and Josh's kernel.org tree are
included as (perhaps other livepatching dev trees as well), so the
more coverage the better :)
> ... But we may not successfully
>bisect all failures.
That's okay, though I guess I'm not clear why there wasn't an email
reporting that the livepatching selftests failed after
livepatching.git was recently updated to include tglx's stack trace
fixes.
Do the tests only run for unique commits (ie, will it skip when
livepatching.git updates/merges latest linux tree ??)
it will not skip, though we
are not testing commit by commit. If the issue
is found, and bisect to the bad commit, we will report to author of that
commit for information.
Thanks,
-- Joe
4:43 a.m.
New subject: livepatching selftests failure on current master branch
On 6/5/19 8:49 PM, Philip Li wrote:
On Wed, Jun 05, 2019 at 10:51:53AM -0400, Joe Lawrence wrote:
> Do the tests only run for unique commits (ie, will it skip when
> livepatching.git updates/merges latest linux tree ??)
it will not skip, though we are not testing commit by commit. If the issue
is found, and bisect to the bad commit, we will report to author of that
commit for information.
Sorry, I'm not following along, let me rephrase my question...
This is the rough timeline that recently occurred:
- changes were made to stacktracing API
-- one commit affected livepatching and broke a selftest
-- Linus pulled the changes
- the livepatching tree updated its master to Linus tree
-- Miroslav noticed that self-tests were broken in the livepatch tree
-- we fixed up the stacktracing API, pushed up to Linus
-- all is good now
Could the 0-day bot testing have helped us spot the self-test breakage
before Linus pulled or when the livepatching tree updated?
Thanks,
-- Joe
12:36 a.m.
New subject: livepatching selftests failure on current master branch
On Thu, Jun 06, 2019 at 02:43:43PM -0400, Joe Lawrence wrote:
On 6/5/19 8:49 PM, Philip Li wrote:
>On Wed, Jun 05, 2019 at 10:51:53AM -0400, Joe Lawrence wrote:
>>Do the tests only run for unique commits (ie, will it skip when
>>livepatching.git updates/merges latest linux tree ??)
>it will not skip, though we are not testing commit by commit. If the issue
>is found, and bisect to the bad commit, we will report to author of that
>commit for information.
Sorry, I'm not following along, let me rephrase my question...
sorry for late
response, i was taken a few days off.
This is the rough timeline that recently occurred:
- changes were made to stacktracing API
-- one commit affected livepatching and broke a selftest
i assume this is another
kernel tree, not necessary the livepatch
kernel tree. This tree may or may not be in our monitor list.
- if not, we can't report is before linus pull.
- if yes, we should be able to detect the failure in normal situation,
and trigger a bisect. But due to how we run the testing internally,
it sometimes can fail to trigger bisect or bisect successfully.
-- Linus pulled the changes
- the livepatching tree updated its master to Linus tree
-- Miroslav noticed that self-tests were broken in the livepatch tree
-- we fixed up the stacktracing API, pushed up to Linus
-- all is good now
Could the 0-day bot testing have helped us spot the self-test
breakage before Linus pulled or when the livepatching tree updated?
This is similar
to previous answer. If the error is not fixed, and exists
in any tree under 0day's monitor, we can figure out the culprit patch.
For now, we will have our best effort to detect regression as many as
possible, while it is not reaching 100% for the test suites we have.
Thanks,
-- Joe
5:42 p.m.
New subject: livepatching selftests failure on current master branch
On Thu 2019-06-06 08:49:43, Philip Li wrote:
On Wed, Jun 05, 2019 at 10:51:53AM -0400, Joe Lawrence wrote:
> On 6/5/19 10:31 AM, Philip Li wrote:
> >On Wed, Jun 05, 2019 at 09:48:02AM -0400, Joe Lawrence wrote:
> That's okay, though I guess I'm not clear why there wasn't an email
> reporting that the livepatching selftests failed after
> livepatching.git was recently updated to include tglx's stack trace
> fixes.
>
> Do the tests only run for unique commits (ie, will it skip when
> livepatching.git updates/merges latest linux tree ??)
it will not skip, though we are not testing commit by commit. If the issue
is found, and bisect to the bad commit, we will report to author of that
commit for information.
Bisecting might take a lot of time or even fail. But each selftest
should get associated with a kernel subsystem. It would be helpful
to always inform the subsystem maintainers. Or at least the author
of the selftest that failed.
Best Regards,
Petr
4:55 p.m.
New subject: livepatching selftests failure on current master branch
On Tue, Jun 11, 2019 at 09:42:57AM +0200, Petr Mladek wrote:
On Thu 2019-06-06 08:49:43, Philip Li wrote:
> On Wed, Jun 05, 2019 at 10:51:53AM -0400, Joe Lawrence wrote:
> > On 6/5/19 10:31 AM, Philip Li wrote:
> > >On Wed, Jun 05, 2019 at 09:48:02AM -0400, Joe Lawrence wrote:
> > That's okay, though I guess I'm not clear why there wasn't an
email
> > reporting that the livepatching selftests failed after
> > livepatching.git was recently updated to include tglx's stack trace
> > fixes.
> >
> > Do the tests only run for unique commits (ie, will it skip when
> > livepatching.git updates/merges latest linux tree ??)
> it will not skip, though we are not testing commit by commit. If the issue
> is found, and bisect to the bad commit, we will report to author of that
> commit for information.
Bisecting might take a lot of time or even fail. But each selftest
should get associated with a kernel subsystem. It would be helpful
to always inform the subsystem maintainers. Or at least the author
of the selftest that failed.
thanks for the suggestion, we haven't done this
yet that we uses merging
approach (merge different repos together to test) to speed up the testing,
so we need to bisect to make sure the issue is reproducible and not related
to merge. But anyway, we will consider this for future todo.
Best Regards,
Petr
1192
days inactive
1201
days old
7 comments
3 participants
participants (3)
-
Joe Lawrence -
Petr Mladek -
Philip Li