5:19 p.m.
Greeting,
FYI, we noticed the following commit (built with gcc-9):
commit: 51d5ae114da8b196202c819ef2149929d8763bb7 ("loop: replace loop_validate_mutex
with loop_validate_spinlock")
git://git.osdn.net/gitroot/tomoyo/tomoyo-test1.git master
in testcase: blktests
version: blktests-x86_64-3be7849-1_20211102
with following parameters:
test: loop-group-03
ucode: 0xe2
on test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz with 32G memory
caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
If you fix the issue, kindly add following tag
Reported-by: kernel test robot <oliver.sang(a)intel.com>
2021-11-23 22:46:53 sed "s:^:loop/:"
/lkp/benchmarks/blktests/tests/loop-group-03
2021-11-23 22:46:53 ./check loop/006 loop/007
loop/006 (change loop backing file while creating/removing another loop device)
loop/006 (change loop backing file while creating/removing another loop device) [failed]
runtime ... 31.072s
--- tests/loop/006.out 2021-11-23 16:47:18.000000000 +0000
+++ /lkp/benchmarks/blktests/results/nodev/loop/006.out.bad 2021-11-23
22:47:24.356147920 +0000
@@ -1,2 +1,3 @@
Running loop/006
+losetup: /dev/loop0: failed to set up loop device: Invalid argument
Test complete
loop/007 (update loop device capacity with filesystem)
loop/007 (update loop device capacity with filesystem) [passed]
runtime ... 0.270s
To reproduce:
git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
sudo bin/lkp install job.yaml # job file is attached in this email
bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
sudo bin/lkp run generated-yaml-file
# if come across any failure that blocks the test,
# please remove ~/.lkp and /lkp dir to run from a clean state.
---
0DAY/LKP+ Test Infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/lkp@lists.01.org Intel Corporation
Thanks,
Oliver Sang
8:55 p.m.
New subject: [loop] 51d5ae114d: blktests.loop/006.fail
Hello.
On 2021/11/25 15:19, kernel test robot wrote:
To reproduce:
git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
sudo bin/lkp install job.yaml # job file is attached in this email
bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
sudo bin/lkp run generated-yaml-file
# if come across any failure that blocks the test,
# please remove ~/.lkp and /lkp dir to run from a clean state.
On Ubuntu 21.10, I can't complete
bin/lkp install job.yaml
due to the following error.
----------
HEAD is now at 642d426f Release 1.6
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c argconfig.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c suffix.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c parser.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c nvme-print.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c nvme-ioctl.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c nvme-lightnvm.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c fabrics.c
In file included from /usr/include/x86_64-linux-gnu/sys/types.h:176,
from /usr/include/stdlib.h:394,
from fabrics.c:24:
fabrics.c: In function ‘do_discover’:
fabrics.c:315:34: error: array subscript ‘struct nvmf_disc_rsp_page_hdr[0]’ is partly
outside array bounds of ‘unsigned char[16]’ [-Werror=array-bounds]
315 | *numrec = le64_to_cpu(log->numrec);
fabrics.c:315:19: note: in expansion of macro ‘le64_to_cpu’
315 | *numrec = le64_to_cpu(log->numrec);
| ^~~~~~~~~~~
fabrics.c:302:15: note: referencing an object of size 16 allocated by ‘calloc’
302 | log = calloc(1, log_size);
| ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/sys/types.h:176,
from /usr/include/stdlib.h:394,
from fabrics.c:24:
fabrics.c:316:33: error: array subscript ‘struct nvmf_disc_rsp_page_hdr[0]’ is partly
outside array bounds of ‘unsigned char[16]’ [-Werror=array-bounds]
316 | genctr = le64_to_cpu(log->genctr);
fabrics.c:316:18: note: in expansion of macro ‘le64_to_cpu’
316 | genctr = le64_to_cpu(log->genctr);
| ^~~~~~~~~~~
fabrics.c:302:15: note: referencing an object of size 16 allocated by ‘calloc’
302 | log = calloc(1, log_size);
| ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [Makefile:46: fabrics.o] Error 1
==> ERROR: A failure occurred in package().
Aborting...
Install blktests failed
----------
I tried
export CFLAGS='-O2 -g -Wall -Werror -Wno-error=array-bounds'
before
bin/lkp install job.yaml
but environment variable is not inherited till fabrics.c . Also
editing Makefile does not help because files are overwritten.
I don't know how to make it possible to complete.
Can you provide the files related to
Running loop/006
+losetup: /dev/loop0: failed to set up loop device: Invalid argument
Test complete
line so that I can understand what this testcase is trying to do ?
10:26 p.m.
New subject: [loop] 51d5ae114d: blktests.loop/006.fail
on 2021/11/25 17:55, Tetsuo Handa wrote:
Hello.
On 2021/11/25 15:19, kernel test robot wrote:
> To reproduce:
>
> git clone https://github.com/intel/lkp-tests.git
> cd lkp-tests
> sudo bin/lkp install job.yaml # job file is attached in this
email
> bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp
run
> sudo bin/lkp run generated-yaml-file
>
> # if come across any failure that blocks the test,
> # please remove ~/.lkp and /lkp dir to run from a clean state.
On Ubuntu 21.10, I can't complete
bin/lkp install job.yaml
due to the following error.
----------
HEAD is now at 642d426f Release 1.6
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c argconfig.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c suffix.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c parser.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c nvme-print.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c nvme-ioctl.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c nvme-lightnvm.c
cc -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
-DNVME_VERSION='"1.6"' -c fabrics.c
In file included from /usr/include/x86_64-linux-gnu/sys/types.h:176,
from /usr/include/stdlib.h:394,
from fabrics.c:24:
fabrics.c: In function ‘do_discover’:
fabrics.c:315:34: error: array subscript ‘struct nvmf_disc_rsp_page_hdr[0]’ is partly
outside array bounds of ‘unsigned char[16]’ [-Werror=array-bounds]
315 | *numrec = le64_to_cpu(log->numrec);
fabrics.c:315:19: note: in expansion of macro ‘le64_to_cpu’
315 | *numrec = le64_to_cpu(log->numrec);
| ^~~~~~~~~~~
fabrics.c:302:15: note: referencing an object of size 16 allocated by ‘calloc’
302 | log = calloc(1, log_size);
| ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/sys/types.h:176,
from /usr/include/stdlib.h:394,
from fabrics.c:24:
fabrics.c:316:33: error: array subscript ‘struct nvmf_disc_rsp_page_hdr[0]’ is partly
outside array bounds of ‘unsigned char[16]’ [-Werror=array-bounds]
316 | genctr = le64_to_cpu(log->genctr);
fabrics.c:316:18: note: in expansion of macro ‘le64_to_cpu’
316 | genctr = le64_to_cpu(log->genctr);
| ^~~~~~~~~~~
fabrics.c:302:15: note: referencing an object of size 16 allocated by ‘calloc’
302 | log = calloc(1, log_size);
| ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [Makefile:46: fabrics.o] Error 1
==> ERROR: A failure occurred in package().
Aborting...
Install blktests failed
----------
I tried
export CFLAGS='-O2 -g -Wall -Werror -Wno-error=array-bounds'
You might need to pass extra CFLAGS in pkg/blktests/PKGBUILD where it
builds the tests.
before
bin/lkp install job.yaml
but environment variable is not inherited till fabrics.c . Also
editing Makefile does not help because files are overwritten.
I don't know how to make it possible to complete.
Can you provide the files related to
It could relate to below test
https://github.com/osandov/blktests/blob/master/tests/loop/006
Thanks
Zhijian
>
>> Running loop/006
>> +losetup: /dev/loop0: failed to set up loop device: Invalid argument
>> Test complete
> line so that I can understand what this testcase is trying to do ?
> _______________________________________________
> LKP mailing list -- lkp(a)lists.01.org
> To unsubscribe send an email to lkp-leave(a)lists.01.org
1:49 a.m.
New subject: [loop] 51d5ae114d: blktests.loop/006.fail
On 2021/11/25 20:26, Li Zhijian wrote:
> I tried
>
> export CFLAGS='-O2 -g -Wall -Werror -Wno-error=array-bounds'
You might need to pass extra CFLAGS in pkg/blktests/PKGBUILD where it builds the tests.
OK.
sed -i -e 's/make/make CFLAGS="-O2 -g -Wall -Werror
-Wno-error=array-bounds"/' pkg/blktests/PKGBUILD
worked.
> Can you provide the files related to
It could relate to below test
https://github.com/osandov/blktests/blob/master/tests/loop/006
>
>> Running loop/006
>> +losetup: /dev/loop0: failed to set up loop device: Invalid argument
>> Test complete
> line so that I can understand what this testcase is trying to do ?
Thank you. I think that this report was generated by serialization change
introduced by "loop: replace loop_validate_mutex with loop_validate_spinlock".
loop/006 was created for commit 310ca162d779efee ("block/loop: Use global lock
for ioctl() operation."). Commit 6cc8e7430801fa23 ("loop: scale loop device by
introducing per device lock") re-opened the race window and commit 3ce6e1f662a91097
("loop: reintroduce global lock for safe loop_validate_file() traversal") again
closed.
Since syzkaller finds circular locking dependency, locking for the loop module is
frequently changing. Commit c895b784c699224d ("loop: don't hold lo_mutex during
__loop_clr_fd()") which is scheduled for 5.17 stopped holding lo_mutex for
ioctl(LOOP_CLR_FD).
Then, "loop: replace loop_validate_mutex with loop_validate_spinlock" which is
waiting for
review at
https://lkml.kernel.org/r/84a861dc-6d50-81c0-8e8b-461ef59f4c01@i-love.sak...
is going to as well stop holding lo_mutex for ioctl(LOOP_SET_FD) / ioctl(LOOP_CONFIGURE)
/
ioctl(LOOP_CHANGE_FD). Technically, lo_mutex can be replaced with a global spinlock using
the same approach.
And "loop: replace loop_validate_mutex with loop_validate_spinlock" causes
loop_validate_file()
(where loop/006 was developed for) to observe Lo_binding state and returns -EINVAL, based
on
an assumption that it is a stupid request for administrator that one process tries to
tear down a loop device while other process tries to modify that loop device (in other
words,
"an insane attempt deserves an insane response"); as long as the kernel does not
crash,
returning an error when hitting a race window triggered by concurrent requests would be
fine.
I think that we need to drop (or update) loop/006 if "loop: replace
loop_validate_mutex with
loop_validate_spinlock" was accepted.
297
days inactive
297
days old
3 comments
3 participants
participants (3)
-
kernel test robot -
Li Zhijian -
Tetsuo Handa