12:20 a.m.
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
commit e7223f18603374d235d8bb0398532323e5f318b9
Author: Sudip Mukherjee <sudipm.mukherjee(a)gmail.com>
AuthorDate: Fri Feb 12 18:33:45 2016 +0530
Commit: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
CommitDate: Sun Feb 14 17:43:50 2016 -0800
ppdev: use new parport device model
Modify ppdev driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee <sudip(a)vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
+---------------------------------------------------------------------+------------+------------+------------+
| | 3c8db58432 |
e7223f1860 | 8eb81b9e40 |
+---------------------------------------------------------------------+------------+------------+------------+
| boot_successes | 29 | 0
| 0 |
| boot_failures | 67 | 30
| 26 |
| Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode= | 67 |
| |
| kernel_BUG_at_drivers/base/driver.c | 0 | 30
| 26 |
| invalid_opcode:#[##] | 0 | 30
| 26 |
| invalid_opcode:#[##]PREEMPT_PREEMPT_DEBUG_PAGEALLOC_DEBUG_PAGEALLOC | 0 | 30
| 26 |
| RIP:driver_register | 0 | 30
| 26 |
| Kernel_panic-not_syncing:Fatal_exception | 0 | 30
| 26 |
| backtrace:ppdev_init | 0 | 30
| 26 |
| backtrace:kernel_init_freeable | 0 | 30
| 26 |
+---------------------------------------------------------------------+------------+------------+------------+
[ 1.808834] Non-volatile memory driver v1.3
[ 1.810078] ------------[ cut here ]------------
[ 1.810078] ------------[ cut here ]------------
[ 1.810982] kernel BUG at drivers/base/driver.c:153!
[ 1.810982] kernel BUG at drivers/base/driver.c:153!
[ 1.812297] invalid opcode: 0000 [#1]
[ 1.812297] invalid opcode: 0000 [#1] PREEMPT PREEMPT DEBUG_PAGEALLOC DEBUG_PAGEALLOC
[ 1.813465] CPU: 0 PID: 1 Comm: swapper Not tainted 4.5.0-rc4-00154-ge7223f1 #2
[ 1.813465] CPU: 0 PID: 1 Comm: swapper Not tainted 4.5.0-rc4-00154-ge7223f1 #2
[ 1.814852] task: ffff88000f468000 ti: ffff88000f46c000 task.ti: ffff88000f46c000
[ 1.814852] task: ffff88000f468000 ti: ffff88000f46c000 task.ti: ffff88000f46c000
[ 1.816276] RIP: 0010:[<ffffffff816e0e51>]
[ 1.816276] RIP: 0010:[<ffffffff816e0e51>] [<ffffffff816e0e51>]
driver_register+0xa1/0xd0
[<ffffffff816e0e51>] driver_register+0xa1/0xd0
[ 1.817855] RSP: 0000:ffff88000f46fe70 EFLAGS: 00010246
[ 1.817855] RSP: 0000:ffff88000f46fe70 EFLAGS: 00010246
[ 1.818867] RAX: ffffffff82ef039c RBX: 000000000e136c08 RCX: 0000000000000000
[ 1.818867] RAX: ffffffff82ef039c RBX: 000000000e136c08 RCX: 0000000000000000
[ 1.820206] RDX: ffffffff82ef039c RSI: ffffffff83459b80 RDI: ffffffff83456428
[ 1.820206] RDX: ffffffff82ef039c RSI: ffffffff83459b80 RDI: ffffffff83456428
[ 1.821559] RBP: ffff88000f46fe88 R08: 0000000000000001 R09: 0000000000000000
[ 1.821559] RBP: ffff88000f46fe88 R08: 0000000000000001 R09: 0000000000000000
[ 1.822913] R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff83456400
[ 1.822913] R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff83456400
[ 1.824259] R13: 0000000000000000 R14: ffffffff836bd0b0 R15: 0000000000000000
[ 1.824259] R13: 0000000000000000 R14: ffffffff836bd0b0 R15: 0000000000000000
[ 1.825613] FS: 0000000000000000(0000) GS:ffffffff83221000(0000)
knlGS:0000000000000000
[ 1.825613] FS: 0000000000000000(0000) GS:ffffffff83221000(0000)
knlGS:0000000000000000
[ 1.827147] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1.827147] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1.828240] CR2: 0000000000000000 CR3: 0000000003210000 CR4: 00000000001406b0
[ 1.828240] CR2: 0000000000000000 CR3: 0000000003210000 CR4: 00000000001406b0
[ 1.829590] Stack:
[ 1.829590] Stack:
[ 1.829988] ffffffff816d7c89
[ 1.829988] ffffffff816d7c89 000000000e136c08 000000000e136c08 ffffffff8364e617
ffffffff8364e617 ffff88000f46fea0 ffff88000f46fea0
[ 1.831442] ffffffff8364e695
[ 1.831442] ffffffff8364e695 ffff88000e136af0 ffff88000e136af0 ffff88000f46ff10
ffff88000f46ff10 ffffffff8361e0b5 ffffffff8361e0b5
[ 1.832903] 0000000000000000
[ 1.832903] 0000000000000000 ffffffff8312c928 ffffffff8312c928 000005ca00060006
000005ca00060006 ffffffff82f32904 ffffffff82f32904
[ 1.834368] Call Trace:
[ 1.834368] Call Trace:
[ 1.834841] [<ffffffff816d7c89>] ? __parport_register_driver+0x39/0x100
[ 1.834841] [<ffffffff816d7c89>] ? __parport_register_driver+0x39/0x100
[ 1.836121] [<ffffffff8364e617>] ? rng_init+0x12/0x12
[ 1.836121] [<ffffffff8364e617>] ? rng_init+0x12/0x12
[ 1.837099] [<ffffffff8364e695>] ppdev_init+0x7e/0xcb
[ 1.837099] [<ffffffff8364e695>] ppdev_init+0x7e/0xcb
[ 1.838081] [<ffffffff8361e0b5>] do_one_initcall+0xf0/0x183
[ 1.838081] [<ffffffff8361e0b5>] do_one_initcall+0xf0/0x183
[ 1.839164] [<ffffffff8361e249>] kernel_init_freeable+0x101/0x187
[ 1.839164] [<ffffffff8361e249>] kernel_init_freeable+0x101/0x187
[ 1.840344] [<ffffffff82695b10>] ? rest_init+0x130/0x130
[ 1.840344] [<ffffffff82695b10>] ? rest_init+0x130/0x130
[ 1.841379] [<ffffffff82695b19>] kernel_init+0x9/0xe0
[ 1.841379] [<ffffffff82695b19>] kernel_init+0x9/0xe0
[ 1.842366] [<ffffffff8269fb1f>] ret_from_fork+0x3f/0x70
[ 1.842366] [<ffffffff8269fb1f>] ret_from_fork+0x3f/0x70
[ 1.843405] [<ffffffff82695b10>] ? rest_init+0x130/0x130
[ 1.843405] [<ffffffff82695b10>] ? rest_init+0x130/0x130
[ 1.844437] Code:
[ 1.844437] Code: ff ff 85 85 c0 c0 41 41 89 89 c4 c4 75 75 13 13 48 48 8b 8b 7b 7b 70
70 31 31 f6 f6 e8 e8 47 47 d3 d3 e8 e8 ff ff 44 44 89 89 e0 e0 5b 5b 41 41 5c 5c 5d 5d c3
c3 48 48 89 89 df df e8 e8 b7 b7 df df ff ff ff ff 44 44 89 89 e0 e0 5b 5b 41 41 5c 5c 5d
5d c3 c3 <0f> <0f> 0b 0b 48 48 8b 8b 33 33 48 48 c7 c7 c7 c7 58 58 f3 f3 f8 f8
82 82 e8 e8 ed ed 24 24 a5 a5 ff ff 48 48 8b 8b 73 73 08 08
[ 1.848930] RIP
[ 1.848930] RIP [<ffffffff816e0e51>] driver_register+0xa1/0xd0
[<ffffffff816e0e51>] driver_register+0xa1/0xd0
[ 1.850075] RSP <ffff88000f46fe70>
[ 1.850075] RSP <ffff88000f46fe70>
[ 1.850780] ---[ end trace 301e5f19aca79aa0 ]---
[ 1.850780] ---[ end trace 301e5f19aca79aa0 ]---
git bisect start 8eb81b9e40322ecdc7c326ca3d429af82dc71c45
18558cae0272f8fd9647e69d3fec1565a7949865 --
git bisect good 81177251dd233e878a3ab7fa4fb34a9d985c69ab # 11:25 22+ 1 Merge
'tty/tty-testing' into devel-catchup-201602151050
git bisect bad 408808ab2ab758c6fa1bdec8fe4d7f7120779186 # 11:33 0- 12 Merge
'linux-review/Simon-Horman/MAINTAINERS-Update-mailing-list-for-Renesas-ARM64-SoC-Development/20160215-095242'
into devel-catchup-201602151050
git bisect good 0a6b1d10601e41de57eeadcf17164d7e668425b7 # 11:41 22+ 0 Merge
'jsakkine-tpmdd/master' into devel-catchup-201602151050
git bisect bad 84e1e09d3107ab136b1e932d9d8e6fe9097e21be # 11:47 0- 24 Merge
'char-misc/char-misc-testing' into devel-catchup-201602151050
git bisect good 52210c8745e418f82f3f0aeeee01d7bc4858812a # 12:03 22+ 7
coresight: implementing 'cpu_id()' API
git bisect good 202cdb6f889bf45e1cb4883e1727e9909152b777 # 12:10 22+ 0 drivers:
char: raw: Removed unnecessary braces
git bisect good 990162f038400bd229685316beea1155be095125 # 12:17 22+ 14 char:
nwbutton: avoid unused variable warning
git bisect good 6ddf2f0cb1e1931d16e08e30130ed04e5a441f2c # 12:26 22+ 18 misc:
mic: use after free printing error message
git bisect good 83e80605cc3ce6a2ac966151cd515f691e4835e0 # 12:32 22+ 24 ppdev:
remove braces
git bisect good 3c8db584323875a50696718c89d94cef0ed54f30 # 12:39 22+ 22 ppdev:
remove space before tab
git bisect bad 396ec3dea3d82d0a32906efe9803a8ef2647df51 # 12:47 0- 23 ppdev:
use dev_* macros
git bisect bad e7223f18603374d235d8bb0398532323e5f318b9 # 12:51 0- 24 ppdev:
use new parport device model
# first bad commit: [e7223f18603374d235d8bb0398532323e5f318b9] ppdev: use new parport
device model
git bisect good 3c8db584323875a50696718c89d94cef0ed54f30 # 12:54 66+ 67 ppdev:
remove space before tab
# extra tests with DEBUG_INFO
git bisect bad e7223f18603374d235d8bb0398532323e5f318b9 # 13:00 0- 3 ppdev:
use new parport device model
# extra tests on HEAD of linux-devel/devel-catchup-201602151050
git bisect bad 8eb81b9e40322ecdc7c326ca3d429af82dc71c45 # 13:00 0- 26 0day
head guard for 'devel-catchup-201602151050'
# extra tests on tree/branch char-misc/char-misc-testing
git bisect bad 396ec3dea3d82d0a32906efe9803a8ef2647df51 # 13:08 0- 30 ppdev:
use dev_* macros
# extra tests with first bad commit reverted
git bisect good 695d7d11b66df48501e9b9f6f4bf94e28817b2ca # 15:48 62+ 44 Revert
"ppdev: use new parport device model"
# extra tests on tree/branch linus/master
git bisect good 1926e54f115725a9248d0c4c65c22acaf94de4c4 # 16:07 62+ 8
MAINTAINERS: Update mailing list for Renesas ARM64 SoC Development
# extra tests on tree/branch linux-next/master
git bisect good 2625f908fc0cbd7e40483217772888529ecbdfd1 # 16:20 64+ 64 Add
linux-next specific files for 20160215
This script may reproduce the error.
----------------------------------------------------------------------------
#!/bin/bash
kernel=$1
initrd=yocto-minimal-x86_64.cgz
wget --no-clobber
https://github.com/fengguang/reproduce-kernel-bug/raw/master/initrd/$initrd
kvm=(
qemu-system-x86_64
-enable-kvm
-cpu Haswell,+smep,+smap
-kernel $kernel
-initrd $initrd
-m 256
-smp 1
-device e1000,netdev=net0
-netdev user,id=net0
-boot order=nc
-no-reboot
-watchdog i6300esb
-rtc base=localtime
-serial stdio
-display none
-monitor null
)
append=(
hung_task_panic=1
earlyprintk=ttyS0,115200
systemd.log_level=err
debug
apic=debug
sysrq_always_enabled
rcupdate.rcu_cpu_stall_timeout=100
panic=-1
softlockup_panic=1
nmi_watchdog=panic
oops=panic
load_ramdisk=2
prompt_ramdisk=0
console=ttyS0,115200
console=tty0
vga=normal
root=/dev/ram0
rw
drbd.minor_count=8
)
"${kvm[@]}" --append "${append[*]}"
----------------------------------------------------------------------------
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/lkp Intel Corporation
3:50 a.m.
On Mon, Feb 15, 2016 at 04:20:45PM +0800, kernel test robot wrote:
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
commit e7223f18603374d235d8bb0398532323e5f318b9
Author: Sudip Mukherjee <sudipm.mukherjee(a)gmail.com>
AuthorDate: Fri Feb 12 18:33:45 2016 +0530
Commit: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
CommitDate: Sun Feb 14 17:43:50 2016 -0800
ppdev: use new parport device model
Modify ppdev driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee <sudip(a)vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Can you please send the .config file so that i can reproduce in my local
system and test?
Ying Huang also sent a similar report after posting the patches. I tried
his .config and your scripts to reproduce this but was not able to.
Anyway, this error is not related to this patch, this patch has just
uncovered this error in parport. And will only happen if ppdev tries to
register with parport before parport bus is registered.
Can you please check if the below patch solves the problem:
diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index 3308427..176b2b6 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -273,6 +273,9 @@ int __parport_register_driver(struct parport_driver *drv, struct
module *owner,
/* using device model */
int ret;
+ if (!parport_bus_type.p)
+ return -EAGAIN;
+
/* initialize common driver fields */
drv->driver.name = drv->name;
drv->driver.bus = &parport_bus_type;
--
regards
sudip
7:41 a.m.
On Mon 2016-02-15 17:20:01, Sudip Mukherjee wrote:
On Mon, Feb 15, 2016 at 04:20:45PM +0800, kernel test robot wrote:
> Greetings,
>
> 0day kernel testing robot got the below dmesg and the first bad commit is
>
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
char-misc-testing
>
> commit e7223f18603374d235d8bb0398532323e5f318b9
> Author: Sudip Mukherjee <sudipm.mukherjee(a)gmail.com>
> AuthorDate: Fri Feb 12 18:33:45 2016 +0530
> Commit: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
> CommitDate: Sun Feb 14 17:43:50 2016 -0800
>
> ppdev: use new parport device model
>
> Modify ppdev driver to use the new parallel port device model.
>
> Signed-off-by: Sudip Mukherjee <sudip(a)vectorindia.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Can you please send the .config file so that i can reproduce in my local
system and test?
Ying Huang also sent a similar report after posting the patches. I tried
his .config and your scripts to reproduce this but was not able to.
Anyway, this error is not related to this patch, this patch has just
uncovered this error in parport. And will only happen if ppdev tries to
register with parport before parport bus is registered.
The problem has been propagated to the Linus' tree for 4.6. I get
[ 1.281235] kernel BUG at drivers/base/driver.c:153!
[ 1.281924] invalid opcode: 0000 [#1] SMP
[ 1.282560] Modules linked in:
[ 1.283095] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 4.5.0-4-default+ #2448
[ 1.284015] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs
01/01/2011
[ 1.284553] task: ffff88013a6a8000 ti: ffff88013a6ac000 task.ti: ffff88013a6ac000
[ 1.284553] RIP: 0010:[<ffffffff81562a86>] [<ffffffff81562a86>]
driver_register+0xd6/0xe0
[ 1.284553] RSP: 0000:ffff88013a6afdc0 EFLAGS: 00010246
[ 1.284553] RAX: ffffffff81d1f68b RBX: ffffffff81f2af08 RCX: 0000000000000000
[ 1.284553] RDX: ffffffff81d1f68b RSI: ffffffff81f2e5a0 RDI: ffffffff81f2af08
[ 1.284553] RBP: ffff88013a6afdd0 R08: 0000000000000000 R09: 0000000000000000
[ 1.284553] R10: 0000000000000001 R11: 00000000000013bd R12: ffffffff81f2aee0
[ 1.284553] R13: 0000000000000000 R14: ffffffff8201f353 R15: ffff88013fc17558
[ 1.284553] FS: 0000000000000000(0000) GS:ffff88013fc80000(0000)
knlGS:0000000000000000
[ 1.284553] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1.284553] CR2: 0000000000000000 CR3: 0000000001e06000 CR4: 00000000000006e0
[ 1.284553] Stack:
[ 1.284553] 0000000000000000 ffffffff81f2aee0 ffff88013a6afdf8 ffffffff81554c6a
[ 1.284553] ffffffff81d1f68b 00000000b9226c80 ffff8800b91bfce0 ffff88013a6afe10
[ 1.284553] ffffffff8201f3d3 ffffffff81e0b050 ffff88013a6afe80 ffffffff810003b8
[ 1.284553] Call Trace:
[ 1.284553] [<ffffffff81554c6a>] __parport_register_driver+0x5a/0x150
[ 1.284553] [<ffffffff8201f3d3>] ppdev_init+0x80/0xd1
[ 1.284553] [<ffffffff810003b8>] do_one_initcall+0x88/0x1c0
[ 1.284553] [<ffffffff8108f200>] ? parse_args+0x210/0x3b0
[ 1.284553] [<ffffffff81fd22e1>] kernel_init_freeable+0x1f9/0x289
[ 1.284553] [<ffffffff81fd19b2>] ? set_debug_rodata+0x12/0x12
[ 1.284553] [<ffffffff8190fc4e>] kernel_init+0xe/0x110
[ 1.284553] [<ffffffff8191dc32>] ret_from_fork+0x22/0x50
[ 1.284553] [<ffffffff8190fc40>] ? rest_init+0x130/0x130
[ 1.284553] Code: c7 20 f0 cd 81 31 c0 e8 a8 68 c2 ff 48 8b 73 08 eb 8e 48 8b 33 48 c7
c7 60 f0 cd 81 31 c0 41 bc f0 ff ff ff e8 8b 68 c2 ff eb 91 <0f> 0b 0f 1f 84 00 00
00 00 00 0f 1f 44 00 00 55 48 85 ff 48 89
[ 1.284553] RIP [<ffffffff81562a86>] driver_register+0xd6/0xe0
[ 1.284553] RSP <ffff88013a6afdc0>
Can you please check if the below patch solves the problem:
diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index 3308427..176b2b6 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -273,6 +273,9 @@ int __parport_register_driver(struct parport_driver *drv, struct
module *owner,
/* using device model */
int ret;
+ if (!parport_bus_type.p)
+ return -EAGAIN;
+
/* initialize common driver fields */
drv->driver.name = drv->name;
drv->driver.bus = &parport_bus_type;
This patch helps. Feel free to use:
Tested-by: Petr Mladek <pmladek(a)suse.com>
Could we please get the fix into the mainline?
Best Regards,
Petr
9:12 a.m.
On Thu, Mar 24, 2016 at 7:41 AM, Petr Mladek <pmladek(a)suse.com> wrote:
Could we please get the fix into the mainline?
I've reverted the offending original commit for now. The fix I see
seems questionable - just ignoring the parport registration will get
rid of the oops, but drivers shouldn't be testing that "p" value
anyway, and it also fundamentally seems to just drop the parport
registration on the floor, so it doesn't seem like a real fix anyway.
So reverting the whole mess seems like the right thing. It's triply
the right thing when it's over a month since the original report, and
this shit made it into my kernel anyway.
Not acceptable.
Linus
1358
days inactive
1397
days old
3 comments
4 participants
participants (4)
-
kernel test robot -
Linus Torvalds -
Petr Mladek -
Sudip Mukherjee