On 10/19/20 9:50 PM, Ian Rogers wrote: > On Mon, Oct 19, 2020 at 2:51 AM John Garry <john.garry(a)huawei.com&gt; wrote: >> >> On 19/10/2020 00:30, Ian Rogers wrote: >>> On Sun, Oct 18, 2020 at 1:51 AM kernel test robot <rong.a.chen(a)intel.com&gt; wrote: >>>> >>>> Greeting, >>>> >>>> FYI, we noticed the following commit (built with gcc-9): >>>> >>>> commit: fcc9c5243c478f104014daf4d23db86098d2aef0 ("perf metricgroup: Hack a fix for aliases when covering multiple PMUs") >>>> url: https://github.com/0day-ci/linux/commits/John-Garry/perf-pmu-events-Suppo... >>>> >>>> >>>> in testcase: perf-sanity-tests >>>> version: perf-x86_64-c85fb28b6f99-1_20201008 >>>> with following parameters: >>>> >>>> perf_compiler: gcc >>>> ucode: 0xdc >>>> >>>> >>>> >>>> on test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz with 32G memory >>>> >>>> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): >>> >>> I believe this is a Skylake and there is a known bug in the Skylake >>> metric DRAM_Parallel_Reads as described here: >>> https://lore.kernel.org/lkml/CAP-5=fXejVaQa9qfW66cY77qB962+jbe8tT5bsLoOOc... >>> Fixing the bug needs more knowledge than what is available in manuals. >>> Hopefully Intel can take a look. >>> >>> Thanks, >>> Ian >> >> So this named patch ("perf metricgroup: Hack a fix for aliases...") is >> breaking test #67 on my machine also, which is a broadwell. > > Thanks for taking a look John. If you want help you can send the > output of "perf test 67 -vvv" to me. It is possible Broadwell has > similar glitches in the json to Skylake. I tested the original test on > server parts as I can access them as cloud machines. > >> I will have a look, but I was hoping that Ian would have a proper fix >> for this on top of ("perf metricgroup: Fix uncore metric expressions"), >> which now looks to be merged. > > I still have these changes to look at in my inbox but I'm assuming > they're good :-) Sorry for not getting to them, but it's good they are > merged. Hi Ian, Checked in upstream kernel with your fix patch, in powerpc also test case 67 is passing. But I am getting issue in test 10 for powerpc [command]# ./perf test 10 10: PMU events : 10.1: PMU event table sanity : Ok 10.2: PMU event map aliases : Ok 10.3: Parsing of PMU event table metrics : Skip (some metrics failed) 10.4: Parsing of PMU event table metrics with fake PMUs : FAILED! Was debugging it, issue is with commit e1c92a7fbbc5 perf tests: Add another metric parsing test. So, there we are passing different runtime parameter value in "expr__find_other and expr__parse" in function `metric_parse_fake`. I believe we need to send same value. I will send fix patch for the same. Thanks, Kajol Jain