On Tue, Sep 30, 2014 at 1:14 AM, Fengguang Wu <fengguang.wu(a)intel.com> wrote:
Hi Steven,
FYI, we noticed that your commit a9f180345f5378ac87d80ed0bea55ba421d83859
("compiler/gcc4: Make quirk for asm_volatile_goto() unconditional") fixed
a number of machine boot failures in our LKP test farm. This is really helpful!
Our gcc version is 4.9.1 (Debian 4.9.1-11).
Hey cool, that's good news!
I rather wish we could find the root cause of the miscompiles, though,
so we could conditionalize the quirk on something again. I'm terrible
at debugging GCC behavior, though, so I'm not the right person for it.
- Steven
569d6557ab957d6 a9f180345f5378ac87d80ed0b
--------------- -------------------------
%stddev %change %stddev
\ | /
1 ± 0% -100.0% 0 ± 0%
lkp-st02/dd-write/5m-11HDD-RAID5-cfq-btrfs-100dd
1 ± 0% -100.0% 0 ± 0% TOTAL dmesg.kernel_BUG_at_fs/nfs/pagelist.c
569d6557ab957d6 a9f180345f5378ac87d80ed0b
--------------- -------------------------
1 ± 0% -100.0% 0 ± 0%
lkp-st02/dd-write/5m-11HDD-RAID5-cfq-btrfs-100dd
1 ± 0% -100.0% 0 ± 0% TOTAL
dmesg.Kernel_panic-not_syncing:Fatal_exception
569d6557ab957d6 a9f180345f5378ac87d80ed0b
--------------- -------------------------
1 ± 0% -100.0% 0 ± 0%
lkp-st02/dd-write/5m-11HDD-RAID5-cfq-btrfs-100dd
1 ± 0% -100.0% 0 ± 0% TOTAL dmesg.invalid_opcode
569d6557ab957d6 a9f180345f5378ac87d80ed0b
--------------- -------------------------
1 ± 0% -100.0% 0 ± 0% ivb42/will-it-scale/futex4
1 ± 0% -100.0% 0 ± 0% ivb44/fsmark/1x-1t-1HDD-xfs-4M-60G-NoSync
1 ± 0% -100.0% 0 ± 0%
ivb44/fsmark/1x-64t-1BRD_48G-btrfs-4M-40G-fsyncBeforeClose
1 ± 0% -100.0% 0 ± 0% lkp-bdw01/blogbench/1SSD-btrfs
1 ± 0% -100.0% 0 ± 0%
lkp-hsw01/vm-scalability/300s-anon-rx-rand-mt
1 ± 0% -100.0% 0 ± 0% lkp-sbx04/will-it-scale/futex3
1 ± 0% -100.0% 0 ± 0% lkp-sbx04/will-it-scale/page_fault3
1 ± 0% -100.0% 0 ± 0%
lkp-st02/dd-write/5m-11HDD-RAID5-cfq-btrfs-100dd
8 ± 0% -100.0% 0 ± 0% TOTAL last_state.is_incomplete_run
569d6557ab957d6 a9f180345f5378ac87d80ed0b
--------------- -------------------------
1 ± 0% -100.0% 0 ± 0% ivb42/will-it-scale/futex4
1 ± 0% -100.0% 0 ± 0% ivb44/fsmark/1x-1t-1HDD-xfs-4M-60G-NoSync
1 ± 0% -100.0% 0 ± 0%
ivb44/fsmark/1x-64t-1BRD_48G-btrfs-4M-40G-fsyncBeforeClose
1 ± 0% -100.0% 0 ± 0% lkp-bdw01/blogbench/1SSD-btrfs
1 ± 0% -100.0% 0 ± 0%
lkp-hsw01/vm-scalability/300s-anon-rx-rand-mt
1 ± 0% -100.0% 0 ± 0% lkp-sbx04/will-it-scale/futex3
1 ± 0% -100.0% 0 ± 0% lkp-sbx04/will-it-scale/page_fault3
1 ± 0% -100.0% 0 ± 0%
lkp-st02/dd-write/5m-11HDD-RAID5-cfq-btrfs-100dd
8 ± 0% -100.0% 0 ± 0% TOTAL last_state.booting
Thanks,
Fengguang