January 2021 - mptcp - Ml01.01.Org

[MPTCP][PATCH mptcp-next] Squash to "mptcp: use WRITE_ONCE/READ_ONCE for the pernet *_max"

by Geliang Tang

As Jakub suggested, drop all the READ_ONCEs in the original patch. And the commit message needs to be updated too: - Subject: mptcp: use WRITE_ONCE for the pernet *_max This patch uses WRITE_ONCE() for all the pernet add_addr_signal_max, add_addr_accept_max, local_addr_max and subflows_max fields in struct pm_nl_pernet to avoid concurrency issues. - Signed-off-by: Geliang Tang <geliangtang(a)gmail.com> --- net/mptcp/pm_netlink.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index 7d6081d9a1db..c429bd82313e 100644 --- a/net/mptcp/pm_netlink.c +++ b/net/mptcp/pm_netlink.c @@ -616,11 +616,11 @@ static int mptcp_pm_nl_append_new_local_addr(struct pm_nl_pernet *pernet, pernet->next_id = entry->addr.id; if (entry->addr.flags & MPTCP_PM_ADDR_FLAG_SIGNAL) { - addr_max = READ_ONCE(pernet->add_addr_signal_max); + addr_max = pernet->add_addr_signal_max; WRITE_ONCE(pernet->add_addr_signal_max, addr_max + 1); } if (entry->addr.flags & MPTCP_PM_ADDR_FLAG_SUBFLOW) { - addr_max = READ_ONCE(pernet->local_addr_max); + addr_max = pernet->local_addr_max; WRITE_ONCE(pernet->local_addr_max, addr_max + 1); } @@ -932,11 +932,11 @@ static int mptcp_nl_cmd_del_addr(struct sk_buff *skb, struct genl_info *info) return -EINVAL; } if (entry->addr.flags & MPTCP_PM_ADDR_FLAG_SIGNAL) { - addr_max = READ_ONCE(pernet->add_addr_signal_max); + addr_max = pernet->add_addr_signal_max; WRITE_ONCE(pernet->add_addr_signal_max, addr_max - 1); } if (entry->addr.flags & MPTCP_PM_ADDR_FLAG_SUBFLOW) { - addr_max = READ_ONCE(pernet->local_addr_max); + addr_max = pernet->local_addr_max; WRITE_ONCE(pernet->local_addr_max, addr_max - 1); } @@ -1140,12 +1140,12 @@ mptcp_nl_cmd_set_limits(struct sk_buff *skb, struct genl_info *info) int ret; spin_lock_bh(&pernet->lock); - rcv_addrs = READ_ONCE(pernet->add_addr_accept_max); + rcv_addrs = pernet->add_addr_accept_max; ret = parse_limit(info, MPTCP_PM_ATTR_RCV_ADD_ADDRS, &rcv_addrs); if (ret) goto unlock; - subflows = READ_ONCE(pernet->subflows_max); + subflows = pernet->subflows_max; ret = parse_limit(info, MPTCP_PM_ATTR_SUBFLOWS, &subflows); if (ret) goto unlock; -- 2.29.2

1 month

3
2
0 / 0

[PATCH net-next v3] mptcp: fix length of MP_PRIO suboption

by Davide Caratti

With version 0 of the protocol it was legal to encode the 'Subflow Id' in the MP_PRIO suboption, to specify which subflow would change its 'Backup' flag. This has been removed from v1 specification: thus, according to RFC 8684 §3.3.8, the resulting 'Length' for MP_PRIO changed from 4 to 3 byte. Current Linux generates / parses MP_PRIO according to the old spec, using 'Length' equal to 4, and hardcoding 1 as 'Subflow Id'; RFC compliance can improve if we change 'Length' in other to become 3, leaving a 'Nop' after the MP_PRIO suboption. In this way the kernel will emit and accept *only* MP_PRIO suboptions that are compliant to version 1 of the MPTCP protocol. unpatched 5.11-rc kernel: [root@bottarga ~]# tcpdump -tnnr unpatched.pcap | grep prio reading from file unpatched.pcap, link-type LINUX_SLL (Linux cooked v1) dropped privs to tcpdump IP 10.0.3.2.48433 > 10.0.1.1.10006: Flags [.], ack 1, win 502, options [nop,nop,TS val 4032325513 ecr 1876514270,mptcp prio non-backup id 1,mptcp dss ack 14084896651682217737], length 0 patched 5.11-rc kernel: [root@bottarga ~]# tcpdump -tnnr patched.pcap | grep prio reading from file patched.pcap, link-type LINUX_SLL (Linux cooked v1) dropped privs to tcpdump IP 10.0.3.2.49735 > 10.0.1.1.10006: Flags [.], ack 1, win 502, options [nop,nop,TS val 1276737699 ecr 2686399734,mptcp prio non-backup,nop,mptcp dss ack 18433038869082491686], length 0 Changes since v2: - when accounting for option space, don't increment 'TCPOLEN_MPTCP_PRIO' and use 'TCPOLEN_MPTCP_PRIO_ALIGN' instead, thanks to Matthieu Baerts. Changes since v1: - refactor patch to avoid using 'TCPOLEN_MPTCP_PRIO' with its old value, thanks to Geliang Tang. Fixes: 067065422fcd ("mptcp: add the outgoing MP_PRIO support") Signed-off-by: Davide Caratti <dcaratti(a)redhat.com> --- net/mptcp/options.c | 5 +++-- net/mptcp/protocol.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/net/mptcp/options.c b/net/mptcp/options.c index 775f0576592e..bb874c5d663a 100644 --- a/net/mptcp/options.c +++ b/net/mptcp/options.c @@ -699,10 +699,11 @@ static bool mptcp_established_options_mp_prio(struct sock *sk, if (!subflow->send_mp_prio) return false; - if (remaining < TCPOLEN_MPTCP_PRIO) + /* account for the trailing 'nop' option */ + if (remaining < TCPOLEN_MPTCP_PRIO_ALIGN) return false; - *size = TCPOLEN_MPTCP_PRIO; + *size = TCPOLEN_MPTCP_PRIO_ALIGN; opts->suboptions |= OPTION_MPTCP_PRIO; opts->backup = subflow->request_bkup; diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h index 447ce4631b43..d31edbae8da8 100644 --- a/net/mptcp/protocol.h +++ b/net/mptcp/protocol.h @@ -61,7 +61,8 @@ #define TCPOLEN_MPTCP_ADD_ADDR6_BASE_PORT 24 #define TCPOLEN_MPTCP_PORT_LEN 4 #define TCPOLEN_MPTCP_RM_ADDR_BASE 4 -#define TCPOLEN_MPTCP_PRIO 4 +#define TCPOLEN_MPTCP_PRIO 3 +#define TCPOLEN_MPTCP_PRIO_ALIGN 4 #define TCPOLEN_MPTCP_FASTCLOSE 12 /* MPTCP MP_JOIN flags */ -- 2.29.2

1 month

3
3
0 / 0

Private information d

by Elizabeth C Shroeder

My Beloved In God. Greetings in the name of our lord Jesus Christ. I am Mrs Elizabeth Schroder from Germany, a widow to late Dr. A. Schroder l am 51 years old and a converted born again Christian, suffering from long time cancer of the breast, from all indication my condition is really deteriorating and it is quite obvious that I might not live more than two (2) months, according to my doctor because the cancer has gotten to a very worst / dangerous stage. My late husband and my only child died last five years ago, his death was politically motivated. My late husband was a very rich and wealthy oil business man who was running his oil,Gold/Diamond Business here in West Africa Nigeria. After his death, I inherited all his business and wealth. My doctors has advised me that I may not live for more than two (2) months, so I now decided to divide the part of this wealth, to contribute to the development of the church in Africa, America, Asia, and Europe. I collected your email address during my desperate search on the internet and I prayed over it. I decided to donate the sum of $17,500,000.00 USD (Seventeen Million Five hundred thousand United States dollars) to the less privileged because I cannot take this money to the grave. Please I want you to note that this fund is lodged in a private bank here in Africa(Standard Trust Bank Africa). Once I hear from you, I will forward to you all the information's you will use to get this fund released from the bank and to be transferred to your bank account. I honestly pray that this money when transferred to you will be used for the said purpose because l have come to find out that wealth acquisition without Christ is vanity. May the grace of our lord Jesus the love of God and the fellowship of God be with you and your family. Reply me on my private email address zbthschroder1(a)gmail.com Thanks and God bless you. Your beloved sister in Christ. Mrs. Elizabeth Schroder Donor

1 month

1
0
0 / 0

Follow me, Orbit and Waypoint

by Jeff Young

1 month

1
0
0 / 0

[PATCH net-next 00/16] mptcp: ADD_ADDR enhancements

by Mat Martineau

This patch series from the MPTCP tree contains enhancements and associated tests for the ADD_ADDR ("add address") MPTCP option. This option allows already-connected MPTCP peers to share additional IP addresses with each other, which can then be used to create additional subflows within those MPTCP connections. Patches 1 & 2 remove duplicated data in the per-connection path manager structure. Patches 3-6 initiate additional subflows when an address is added using the netlink path manager interface and improve ADD_ADDR signaling reliability, subject to configured limits. Self tests are also updated. Patches 7-15 add new support for optional port numbers in ADD_ADDR. This includes creating an additional in-kernel TCP listening socket for the requested port number, validating the port number when processing incoming subflow connections, including the port number in netlink interfaces, and adding some new MIBs. New self test cases are added for subflows connecting with alternate port numbers. Patch 16 refactors the self test script containing the ADD_ADDR test cases, allowing developers to quickly run a subset of the tests. Geliang Tang (16): mptcp: use WRITE_ONCE/READ_ONCE for the pernet *_max mptcp: drop *_max fields in mptcp_pm_data mptcp: create subflow or signal addr for newly added address mptcp: send ack for every add_addr selftests: mptcp: use minus values for removing address numbers selftests: mptcp: add testcases for newly added addresses mptcp: create the listening socket for new port mptcp: drop unused skb in subflow_token_join_request mptcp: add a new helper subflow_req_create_thmac mptcp: add port number check for MP_JOIN mptcp: enable use_port when invoke addresses_equal mptcp: deal with MPTCP_PM_ADDR_ATTR_PORT in PM netlink selftests: mptcp: add port argument for pm_nl_ctl mptcp: add the mibs for ADD_ADDR with port selftests: mptcp: add testcases for ADD_ADDR with port selftests: mptcp: add command line arguments for mptcp_join.sh net/mptcp/mib.c | 6 + net/mptcp/mib.h | 6 + net/mptcp/mptcp_diag.c | 6 +- net/mptcp/options.c | 4 + net/mptcp/pm.c | 12 +- net/mptcp/pm_netlink.c | 295 ++++- net/mptcp/protocol.c | 2 +- net/mptcp/protocol.h | 12 +- net/mptcp/subflow.c | 79 +- .../testing/selftests/net/mptcp/mptcp_join.sh | 1095 +++++++++++------ tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 24 +- 11 files changed, 1084 insertions(+), 457 deletions(-) base-commit: 32e31b78272ba0905c751a0f6ff6ab4c275a780e -- 2.30.0

1 month

2
18
0 / 0

[MPTCP][PATCH mptcp-next 0/8] RM_ADDR: remove a list of addrs

by Geliang Tang

This patchset added the removing a list of addresses support for RM_ADDR. It addressed issue #140. tag: export/20210129T064739 Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/140 Geliang Tang (8): mptcp: remove multi addrs on outgoing path mptcp: remove multi addrs on incoming path mptcp: add removing multi addrs support in PM mptcp: add removing multi addrs support in netlink mptcp: implement mptcp_nl_remove_addrs_and_subflows mptcp: remove a list of addrs when flushing mptcp: update the netlink event for rm_addr selftests: mptcp: add testcases for removing addrs include/net/mptcp.h | 2 +- include/uapi/linux/mptcp.h | 1 + net/mptcp/options.c | 53 +++-- net/mptcp/pm.c | 26 +-- net/mptcp/pm_netlink.c | 182 ++++++++++++++---- net/mptcp/protocol.h | 23 ++- .../testing/selftests/net/mptcp/mptcp_join.sh | 23 +++ 7 files changed, 235 insertions(+), 75 deletions(-) -- 2.29.2

1 month

2
11
0 / 0

[MPTCP][RFC mptcp-next 0/6] add trace events

by Geliang Tang

This patchset addressed issues 131, replace some/most pr_debug with trace events. Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/131 Geliang Tang (6): mptcp: add tracepoints for data operations mptcp: add echo field in mptcp_out_options mptcp: add tracepoints for options operations mptcp: add mptcpi_local_addr_* in mptcp_info mptcp: add tracepoints for PM operations mptcp: add tracepoints for subflow operations include/net/mptcp.h | 1 + include/trace/events/mptcp.h | 408 +++++++++++++++++++++++++++++++++++ include/uapi/linux/mptcp.h | 4 +- net/mptcp/mptcp_diag.c | 4 +- net/mptcp/options.c | 11 +- net/mptcp/pm.c | 3 + net/mptcp/pm_netlink.c | 6 +- net/mptcp/protocol.c | 5 + net/mptcp/protocol.h | 1 + net/mptcp/subflow.c | 6 + 10 files changed, 445 insertions(+), 4 deletions(-) create mode 100644 include/trace/events/mptcp.h -- 2.29.2

1 month

3
10
0 / 0

Business Proposal

by Aisha mohammed

1 month

1
0
0 / 0

!!FINAL WARNING!! | Your mailbox storage is full mptcp@lists.01.org 7✉ New Messages

by Webmail Support

1 month

1
0
0 / 0

Re: Conference call

by Susan Taylor

Are you looking for any of the following Email and phone list gathered from LinkedIn, Events and market research? Please specify your target audience so that we can share a sample with you. * Architects and interior designers email list * CEO, owner, President and COO contacts * CFO, Controller, VP/Director/Manager of Finance, Accounts Payable, Accounts Receivable, Audit Contacts * Chief Human Resources Officer, VP/Director/Manager of HR, Employee Benefits, Employee Communications, Employee Compensation, Employee Engagement, Employee Experience and Employee Relations, Talent Acquisition, Talent Development, Talent Management, Recruiting Contacts * CIO,CTO, CISO, VP/Director/Manager of IT, IT Compliance, IT Risk, BI, Cloud, Database and IT Security Contacts * CMO, VP/Director/Manager of Marketing, social media, Sales, demand generation, Lead generation, inside sales, Marketing Communications contacts etc. * Compliance and Risk Management Contacts * CPA and Bookkeepers email list * Data Analytics and Database Administrators contacts * Disaster Recovery Contacts * E-commerce or online retailers email list * Education industry executives email list - Principals, Dean, Admins and teachers from Schools, Colleges and Universities * Engineers email list * Event and meeting planners email list * Facilities and office manager Contacts * General and corporate counsel as well legal professionals list * Government contractors email list * Health & Safety Contacts * High net worth individuals/investors email list * Hospitals, clinics, private practices, Pharmaceutical and biotechnology company’s top decision makers email list * Human Capital Management Contacts * Individual insurance agents list * ISV/VARs list * Learning & Development Contacts * Logistics, shipping and supply chain managers email list * Manufacturing Industry executives list * Network manager, Surveillance, System Administrator, Technical Support Contacts * New & Used Car Dealers email list * Oil, Gas and utility industry contacts * Physicians, Doctors, Nurses, Dentists, Therapists email list * Plant Manager Contacts * Product and project management list * Purchasing and Procurement Contacts * Specific Event attendees list * Telecom managers, VOIP managers, Cloud architect, Cloud managers, Storage managers email list * VP/Director/Manager of Customer Service and Customer Success Susan Taylor Database Consultant 42Mil B2B and 210Mil B2C Opt-in Email and phone list with other data fields Unsubscribe http://appendleadedm.info/emm/index.php/lists/tm309l31m36a2/unsubscribe/r...

1 month

1
0
0 / 0

2021

2020

2019

2018

2017

mptcp January 2021