On 17/10/2019 15:38, Matthieu Baerts wrote:
Thank you for the reviews!
On 17/10/2019 15:26, Paolo Abeni wrote:
> On Thu, 2019-10-10 at 16:27 +0200, Matthieu Baerts wrote:
>> WARNING: line over 80 characters
>> #233: FILE: net/mptcp/options.c:47:
>> + * negotiated, the receiver MUST close the subflow
>> with a RST as it is
>> Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
>> to be squashed in "mptcp: Handle MPTCP TCP options"
>> net/mptcp/options.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/net/mptcp/options.c b/net/mptcp/options.c
>> index cee4280647fe..adf65d3ff27b 100644
>> --- a/net/mptcp/options.c
>> +++ b/net/mptcp/options.c
>> @@ -44,8 +44,8 @@ void mptcp_parse_option(const unsigned char *ptr,
>> int opsize,
>> * Section 3.3.0:
>> * "If a checksum is not present when its use has been
>> - * negotiated, the receiver MUST close the subflow with a
>> RST as it is
>> - * considered broken."
>> + * negotiated, the receiver MUST close the subflow with a
>> RST as
>> + * it is considered broken."
>> * We don't implement DSS checksum - fall back to TCP.
> This one and the next 2 patches are IMHO uncontroversially good, but
> the 4th is a bit against my personal taste - I would keep the
> checkpatch offenders instead;). No objections on the 5th patch.
I am fine to drop the 4th one. Florian mentioned earlier that it is
better to fix checkpatch issues than having comments about that during
the reviews or dedicated patches later to fix just that. But because
Florian wrote this code (mptcp_snmp_list + linux_mptcp_mib_field), I
guess he is also fine not to follow checkpatch rules :)
I am going to apply the other patches, they are not linked to each others.
- ca0aa2a7167f "squashed" patch 1/5 in "mptcp: Handle MPTCP TCP
- 6d74ebddfb37 "squashed" patch 2/5 in "mptcp: new sysctl to control the
activation per NS"
- ce91edef4344 "squashed" patch 3/5 in "mptcp: queue data for mptcp
- patch 4/5 is not applied
- 2236d77c0c5f: "squashed" patch 5/5 in "mptcp: increment MIB counters
in a few places"
- 6f951dc4ca1b..4c046ac001b8: result
Matthieu Baerts | R&D Engineer
Tessares SA | Hybrid Access Solutions
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium