+Benjamin

> On Oct 30, 2019, at 7:18 AM, Paolo Abeni <pabeni@redhat.com> wrote:
>
> On Fri, 2019-10-25 at 17:20 +0200, Matthieu Baerts wrote:
>> On 25/10/2019 09:53, Matthieu Baerts wrote:
>>>     - MPTCP v1 support → part 2:
>>>         - Paolo started to look at the RFC to support Christoph
>>>         - Christoph will be the submitter of the patch
>>>         - *Matth*: publish a branch with mptcp.org + MPTCPv1
>>
>> I didn't have a lot of time to look at it but you can find mptcp.org
>> kernel with Christoph patches (and a small fix) to support MPTCPv1 on my
>> Github account:
>>
>>     https://github.com/matttbe/mptcp_net-next/tree/mptcp_v0.95_mptcp_v1
>>     https://github.com/matttbe/mptcp_net-next/tree/mptcp_trunk_mptcp_v1
>>
>> I would recommend to use the branch based on mptcp_v0.95 (last upstream
>> LTS, v4.19.55).
>
> Looking at the code, it seams to me the abve does not implement/use
> sha256, but it still relies on sha1 hmac.

Benjamin, didn't you implement SHA-256 support? Do you still have the patches?


Cheers,
Christoph

>
> Is the above expected? or are some patches missing?
>
> Thanks,
>
> Paolo
>