On Wed, 2019-11-13 at 17:35 +0100, Matthieu Baerts wrote:
Should we already add the MIB counter? And/or add a TODO in the code?
I think adding more MIB counter is a later tasks.
We are not there yet but missing an ADD_ADDR can have bad
And it would be unexpected for the userspace to drop it, especially with
MPTCPv1 which should make it reliable :)
whoops... I missed that difference between v0 and v1. That opens a full
can of worms, I think/fear:
ADD_ADDR6 echo (30 bytes) can't fit TCP option space easily, without
dropping also the tstamp option. Why does echo includes the IP address
itself ?!? why is the address ID not enough?
bold/stupid question: is still possible change v1 specs in that regard?
(e.g. removing the address from ADD_ADDR echo option)
> Inserting a (duplicate) ack to try to fit such option looks
> also out-of-scope for this change.
Here I missed the side effects of duplicate acks on CC. We can't easily
plug there MPTCP specific behavior and if we start sending TCP dup ack
to carry MPTCP info we may end-up needing hook to avoid interference on
Agreed. We should add this in a TODO list of "things for
later" :) (or a
TODO in the code?)
I think tracking this on the framepad is the better option.