On Fri, 24 Apr 2020, Paolo Abeni wrote:
This is a very early RFC showcasing the fix discussed in yday mtg -
first 3 patches. It contains also fix/warkaround for the last warn() I'm
able to hit with syzbot repro provided by Christoph.
With this series and https://marc.info/?l=linux-netdev&m=158772695009150&w=2
on top of -net I haven't hit any of the 'known' oops/warn so far, but
I'm hitting a WARN_ONCE("Bad mapping: "...) I'm unsure it's
introduced here or not.
+1 on the suboption approach and adding mptcp_init_options().
While the accessors are more verbose, I do agree that it makes things more
readable. In a way I think checking/setting the bits directly might make
it more obvious that the changes are minor, but it seems like it would get
merged either way.