3:36 a.m.
Hi Rao,
On Wed, Mar 21, 2018 at 6:01 PM, Rao Shoaib <rao.shoaib(a)oracle.com> wrote:
There has been some misunderstanding on what an RFC patch is and
what
standards it needs to meet. Following is the official response of David
Miller.
Thank you for this forwarded message.
Based on those guidelines the RFC patch we submitted meets and
exceeds the
requirements. So please review it.
I don't have the same experiences as some other here but I will try to give
interesting comments if I have some.
Was the version you sent last month with 9 patches the last one?
Replacement of function pointers will be addressed later as a
separate
issue.
I agree about that.
In case there are other procedural issues that would prohibit
technical
discussion please site the written rules or first ask David Miller.
There are a lot of technical issues to discuss, so if possible lets not
get tied up on process and bureaucracy. Looking forward to detailed
technical comments.
Good idea.
-------- Forwarded Message --------
Subject: Re: Few questions about submitting patches
Date: Wed, 21 Mar 2018 12:46:17 -0400 (EDT)
From: David Miller <davem(a)davemloft.net> <davem(a)davemloft.net>
To: rao.shoaib(a)oracle.com
CC: netdev(a)vger.kernel.org, eric.dumazet(a)gmail.com
> * #ifdef FOO
>
> In a regular patch consisting of a series of patches, can the above
> #ifdef be used in a patch before the patch that allows the selection
> of FOO. That patch is part of the series but comes later.
It is better to introduce them at the same time.
But if it is prohibitively difficult to do so, yet at the same
time properly split up your changes into manageable pieces, it
can be OK.
It is definitely determined on a case by case basis.
So ok to keep them to clearly indicate where MPTCP specific code will be?
Matthieu
--
[image: Tessares SA] <http://www.tessares.net> Matthieu Baerts | R&D
Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
<https://www.google.com/maps?q=1+Avenue+Jean+Monnet,+1348+Ottignies-Louvai...
--
------------------------------
DISCLAIMER.
This email and any files transmitted with it are confidential and intended
solely for the use of the individual or entity to whom they are addressed.
If you have received this email in error please notify the system manager.
This message contains confidential information and is intended only for the
individual named. If you are not the named addressee you should not
disseminate, distribute or copy this e-mail. Please notify the sender
immediately by e-mail if you have received this e-mail by mistake and
delete this e-mail from your system. If you are not the intended recipient
you are notified that disclosing, copying, distributing or taking any
action in reliance on the contents of this information is strictly
prohibited.