Hi Davide, Paolo,
On 14/10/2019 16:56, Paolo Abeni wrote:
On Mon, 2019-10-14 at 16:46 +0200, Davide Caratti wrote:
> with this series we make
> setscokopt(..., IPPROTO_TCP, TCP_ULP, "mptcp", sizeof("mptcp"));
> return -1 and set errno to -EOPNOPSUPPORT.
> this allows attaching MPTCP ULP only to a TCP socket that has been
> created through sock_create_kern().
> - Patch 1/2 lets subflow_init() fail with -EOPNOTSUPPORT in case users
> try to setsockopt(..., TCP_ULP) on a TCP socket that has been created
> by a userspace program. I suggest squashing this patch in "mptcp:
> Associate MPTCP context with TCP socket".
> - Patch 2/2 includes kselftest code. I suggest squashing it with "mptcp:
> add basic kselftest for mptcp".
> Changes since v1:
> - don't redirect the selftest output to /dev/null
> - test output depends on the value of 'errno', to avoid false negative
> in case kernel is built without CONFIG_MPTCP
> Davide Caratti (2):
> mptcp: subflow: disallow setsockopt(... TCP_ULP, "mptcp")
> selftests: test setsockopt(..., TCP_ULP, "mptcp", ...)
> net/mptcp/subflow.c | 7 +++
> .../selftests/net/mptcp/mptcp_connect.c | 52 +++++++++++++++++--
> .../selftests/net/mptcp/mptcp_connect.sh | 19 +++++++
> 3 files changed, 75 insertions(+), 3 deletions(-)
The patches LGTM, thanks Davide!
Thank you for the patches and the review!
- 87df9026e7cc: "squashed" the first patch in "mptcp: Associate MPTCP
context with TCP socket"
- 8c907c48da5c: "Signed-off-by" + "Co-developed-by"
- a8a756ed4dbc: conflict in
- 2057bcf6bf5e: "squashed" the second patch in "mptcp: add basic
kselftest for mptcp"
- be20e32cf37d..c7557e1f213a: result
Tests are still OK!
mptcp mailing list -- mptcp(a)lists.01.org
To unsubscribe send an email to mptcp-leave(a)lists.01.org
Matthieu Baerts | R&D Engineer
Tessares SA | Hybrid Access Solutions
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium