the radix tree slot manipulation needs some extra care to fit the RCU annotation. Also replace raw *slot assignment with the related radix tree helper - elsewhere sparse will lament there, too. Squash-to: "mptcp: Add key generation and token tree" Signed-off-by: Paolo Abeni <pabeni(a)redhat.com&gt; --- net/mptcp/token.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/mptcp/token.c b/net/mptcp/token.c index a0d8f6e323b2..aeb7059d19e1 100644 --- a/net/mptcp/token.c +++ b/net/mptcp/token.c @@ -161,8 +161,8 @@ void mptcp_token_update_accept(struct sock *sk, struct sock *conn) slot = radix_tree_lookup_slot(&token_tree, subflow->token); WARN_ON_ONCE(!slot); if (slot) { - WARN_ON_ONCE(*slot != &token_used); - *slot = conn; + WARN_ON_ONCE(rcu_access_pointer(*slot) != &token_used); + radix_tree_replace_slot(&token_tree, slot, conn); } spin_unlock_bh(&token_tree_lock); } -- 2.21.0