[PATCH] Add vid/pid for Ericsson F5521gw
by Torgny Johansson
---
plugins/ofono.rules | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/plugins/ofono.rules b/plugins/ofono.rules
index 859da56..f2a8162 100644
--- a/plugins/ofono.rules
+++ b/plugins/ofono.rules
@@ -388,6 +388,9 @@ ATTRS{idVendor}=="0bdb", ATTRS{idProduct}=="1049", ENV{OFONO_DRIVER}="mbm"
ATTRS{idVendor}=="0bdb", ATTRS{idProduct}=="190a", ENV{OFONO_DRIVER}="mbm"
ATTRS{idVendor}=="0bdb", ATTRS{idProduct}=="1909", ENV{OFONO_DRIVER}="mbm"
+# Ericsson F5521gw
+ATTRS{idVendor}=="0bdb", ATTRS{idProduct}=="190d", ENV{OFONO_DRIVER}="mbm"
+
# Sony-Ericsson MD300
ATTRS{idVendor}=="0fce", ATTRS{idProduct}=="d0cf", ENV{OFONO_DRIVER}="mbm"
--
1.7.1
10 years, 3 months
Re: [PATCH] hso: Set modem name based on udev network interface name
by "Benoît Monin"
Hi Marcel,
> De : Marcel Holtmann
>
> Hi Benoit,
>
> the friendly modem name is for devices that do have a friendly name,
> like Bluetooth headsets. Why do you wanna misuse the interface name
> here. I am a bit against this, because it leads to speculation and
> assumptions in userspace programs.
>
Maybe I should give some details of what I'm trying to achieve. The
device we're building has 2 identical modems with fixed position on
USB. We also have the possibility to drive their power supply
independently and to swap the sim cards.
I need a way to know which one is modem A and which one is modem B
and I have no easy way of knowing the modem serial number or the
sim subscriber id beforehand. With an udev rule, I can easily set
a fixed name for the network interface of each modem. But under
ofono, I can't tell which modem is which. That's why I added this
"not-so-friendly" name.
Is there a way of knowing which physical modem ofono is refering to ?
I recognize that our case may not be the most common and I understand
that you don't want to abuse the Name property. Maybe exposing the
NetworkInterface as a modem property would be ok ? or exposing
a PhysicalName ?
--
Benoît.
10 years, 3 months
[PATCH 1/2] Fixes segfault when removing Nokia Datacard.
by Hannu Lyytinen
---
plugins/nokia.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/plugins/nokia.c b/plugins/nokia.c
index f65617b..bb8e2f3 100644
--- a/plugins/nokia.c
+++ b/plugins/nokia.c
@@ -130,7 +130,8 @@ static void nokia_disconnect(gpointer user_data)
DBG("");
- ofono_gprs_context_remove(data->gc);
+ if (data->gc)
+ ofono_gprs_context_remove(data->gc);
g_at_chat_unref(data->modem);
data->modem = NULL;
--
1.7.0.4
10 years, 3 months
RE: [PATCH 1/4] doc: Add ModemAccessTechnology property
by Rajesh.Nagaiah＠elektrobit.com
Hi Denis/Marcel,
>
> > Hi Rajesh,
> >
> > > doc/modem-api.txt | 9 +++++++++
> > > 1 files changed, 9 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/doc/modem-api.txt b/doc/modem-api.txt index
> > > c48375e..f5a3026 100644
> > > --- a/doc/modem-api.txt
> > > +++ b/doc/modem-api.txt
> > > @@ -43,6 +43,15 @@ Properties boolean Powered [readwrite]
> > > modem. The Emergency is true if an
> > emergency call or
> > > related operation is currently active.
> > >
> > > + string ModemAccessTechnology [readonly]
> > > +
> > > + Contains current access techonology of
> > the modem.
> > > + Possible values are:
> > > + "gsm" - the current modem access
> > technology is GSM
> > > + "cdma" - the current modem access
> > technology is CDMA
> > > +
> > > + By default oFono uses "gsm" setting.
> > > +
> >
> > so you are in the org.ofono.Modem interface and its
> properties and you
> > wanna prefix the property with "Modem".
> > That is rather pointless duplication of information. So just strip
> > that.
>
> I prefix it with Modem just not to mix with the Network
> Access Technology. From the property name prespective I agree
> with you, its an redundant info as we are in org.ofono.Modem interface
>
> > The obvious question we have to discuss, if we really wanna
> do it this
> > way. What are the pros and what are the cons?
>
> I quite didnt get this query, pros and cons about this
> property usage or ?
Any update on this ? If Modem prefix is the only comment, I can
remove and resubmit the patch again. or is there more comments ?
BR,
Rajesh
10 years, 3 months
[PATCH] sim: Check SIM pin status after changing pin.
by Marit Henriksen
From: Marit Henriksen <marit.henriksen(a)stericsson.com>
When changing pin, it is possible to get in a state where the modem requests puk
(if incorrect pin is entered too many times). Need to check the SIM pin status
to discover this.
---
src/sim.c | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/sim.c b/src/sim.c
index 699ebe9..b2277c5 100644
--- a/src/sim.c
+++ b/src/sim.c
@@ -628,15 +628,16 @@ static DBusMessage *sim_unlock_pin(DBusConnection *conn, DBusMessage *msg,
static void sim_change_pin_cb(const struct ofono_error *error, void *data)
{
struct ofono_sim *sim = data;
+ DBusMessage *reply;
- if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
- __ofono_dbus_pending_reply(&sim->pending,
- __ofono_error_failed(sim->pending));
- return;
- }
+ if (error->type != OFONO_ERROR_TYPE_NO_ERROR)
+ reply = __ofono_error_failed(sim->pending);
+ else
+ reply = dbus_message_new_method_return(sim->pending);
- __ofono_dbus_pending_reply(&sim->pending,
- dbus_message_new_method_return(sim->pending));
+ __ofono_dbus_pending_reply(&sim->pending, reply);
+
+ sim_pin_check(sim);
}
static DBusMessage *sim_change_pin(DBusConnection *conn, DBusMessage *msg,
--
1.7.0.4
10 years, 3 months
[PATCH] sim: use mask for check of sim file status
by Lucas, GuillaumeX
From: Guillaume Lucas <guillaumex.lucas(a)intel.com>
Is' the first bit of the sim file status who indicates if a file
is valid or not. So a mask must be used to check this.
---
src/sim.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/sim.c b/src/sim.c
index 02ab329..2ee2b29 100644
--- a/src/sim.c
+++ b/src/sim.c
@@ -1290,7 +1290,7 @@ static void sim_efbdn_info_read_cb(int ok, unsigned char file_status,
if (!ok)
goto out;
- if (file_status == SIM_FILE_STATUS_VALID)
+ if (file_status & SIM_FILE_STATUS_VALID)
sim_bdn_enabled(sim);
out:
@@ -1327,7 +1327,7 @@ static void sim_efadn_info_read_cb(int ok, unsigned char file_status,
if (!ok)
goto out;
- if (file_status != SIM_FILE_STATUS_VALID)
+ if (!(file_status & SIM_FILE_STATUS_VALID))
sim_fdn_enabled(sim);
out:
--
1.7.0.4
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
10 years, 3 months
[PATCH] TODO: Add owner of provide local info task
by Yang Gu
---
TODO | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/TODO b/TODO
index 0d04208..a5196f7 100644
--- a/TODO
+++ b/TODO
@@ -362,6 +362,7 @@ Sim Toolkit
Priority: High
Complexity: C2
+ Owner: Yang Gu <yang.gu(a)intel.com>
Emergency Calls
--
1.7.2.3
10 years, 3 months
[PATCHv2] isigen: increase offline timeout
by Pekka.Pessi＠nokia.com
From: Pekka Pessi <Pekka.Pessi(a)nokia.com>
The modem deregisters from network before response to MTC_STATE_REQ is
returned. Deregistering can take up to 6 seconds.
---
drivers/isimodem/mtc.h | 1 +
plugins/isigen.c | 2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/isimodem/mtc.h b/drivers/isimodem/mtc.h
index 2a5754f..4f452e7 100644
--- a/drivers/isimodem/mtc.h
+++ b/drivers/isimodem/mtc.h
@@ -28,6 +28,7 @@ extern "C" {
#define PN_MTC 0x15
#define MTC_TIMEOUT 5
+#define MTC_STATE_REQ_TIMEOUT (6 + 5)
enum mtc_isi_cause {
MTC_OK = 0x00,
diff --git a/plugins/isigen.c b/plugins/isigen.c
index 493d926..838d060 100644
--- a/plugins/isigen.c
+++ b/plugins/isigen.c
@@ -373,7 +373,7 @@ static void isigen_online(struct ofono_modem *modem, ofono_bool_t online,
isi->online = online;
- if (g_isi_send(isi->client, req, sizeof(req), MTC_TIMEOUT,
+ if (g_isi_send(isi->client, req, sizeof(req), MTC_STATE_REQ_TIMEOUT,
mtc_state_cb, cbd, NULL))
return;
--
1.7.1
10 years, 3 months
Re: Huawei EM 770 not working properly
by Frederic Crozat
Le jeudi 04 novembre 2010 à 09:16 -0500, Denis Kenzior a écrit :
> Hi Frederic,
>
> On 11/04/2010 06:15 AM, Frederic Crozat wrote:
> > Hi,
> >
> > I'm trying to get ofono working properly with integrated 3G card on my
> > EEE PC.
> >
> > Card is Huawei EM 770 (12d1:1001).
> >
> > I'm testing with ofono 0.34.
> >
> > so far, the modem is correctly detected :
> >
> > list-modem returns :
> > [ /huawei0 ]
> > Features = sim
> > Powered = 1
> > Interfaces = org.ofono.SimManager
> > Online = 0
> > Model = EM770
> > Manufacturer = huawei
> > Serial = ....
> > Revision = 11.104.16.12.00
> > [ org.ofono.SimManager ]
> > Present = 0
>
> What is happening is that oFono thinks the sim is not inserted, and it
> does not proceed further with modem initialization. oFono polls the
> SYSINFO command, with one of the fields being the status of the SIM.
>
> Do you have a SIM PIN set? The current huawei driver does not handle
> this case gracefully yet, mainly because the huawei firmware is quite
> 'peculiar'.
Since I'm using SIM card from my N900, I've disabled PIN code and ofono
worked properly and I was able to connect to my 3G operator (and see it
is locking me out, because I have a 3G phone subscription and it is
seeing a modem IMEI ...).
So, next part would be to get PIN code working ;)
>From other collegues who bought the same netbook, it seems umtsmon is
able to get PIN unlocking for this card.
--
Frederic Crozat <fcrozat(a)novell.com>
Novell
10 years, 3 months
Huawei EM 770 not working properly
by Frederic Crozat
Hi,
I'm trying to get ofono working properly with integrated 3G card on my
EEE PC.
Card is Huawei EM 770 (12d1:1001).
I'm testing with ofono 0.34.
so far, the modem is correctly detected :
list-modem returns :
[ /huawei0 ]
Features = sim
Powered = 1
Interfaces = org.ofono.SimManager
Online = 0
Model = EM770
Manufacturer = huawei
Serial = ....
Revision = 11.104.16.12.00
[ org.ofono.SimManager ]
Present = 0
And trying to put it "online" using online-modem returns
"org.ofono.Error.NotAvailable"
Logs are as follow :
ofonod[1493]: plugins/bluetooth.c:manager_properties_cb()
ofonod[1493]: plugins/bluetooth.c:parse_adapters()
ofonod[1493]: plugins/bluetooth.c:parse_adapters() Calling GetProperties
on /org/bluez/465/hci0
ofonod[1493]: plugins/bluetooth.c:parse_devices()
ofonod[1493]: plugins/bluetooth.c:adapter_properties_cb() Adapter
Address: 00:25:D3:A2:D1:09, Path: /org/bluez/465/hci0
ofonod[1493]: plugins/huawei.c:huawei_enable() 0x941b210
ofonod[1493]: plugins/huawei.c:open_device() Modem /dev/ttyUSB0
ofonod[1493]: plugins/huawei.c:open_device() Pcui /dev/ttyUSB2
ofonod[1493]: plugins/huawei.c:query_sim_state()
ofonod[1493]: PCUI: > ATE0 +CMEE=1\r
ofonod[1493]: PCUI: < \r\nOK\r\n
ofonod[1493]: PCUI: > AT+CFUN=1\r
ofonod[1493]: PCUI: < \r\nOK\r\n
ofonod[1493]: plugins/huawei.c:cfun_enable()
ofonod[1493]: PCUI: > AT^SYSINFO\r
ofonod[1493]: PCUI: < \r\n^SYSINFO:0,0,0,0,0,,0\r\n\r\nOK\r\n
ofonod[1493]: plugins/huawei.c:notify_sim_state() 0
ofonod[1493]: plugins/huawei.c:huawei_pre_sim() 0x941b210
ofonod[1493]: plugins/huawei.c:query_sim_state()
ofonod[1493]: PCUI: > AT^U2DIAG?\r
ofonod[1493]: PCUI: < \r\nERROR\r\n
ofonod[1493]: PCUI: > AT^GETPORTMODE\r
ofonod[1493]: PCUI: < \r\nCOMMAND NOT SUPPORT\r\n
ofonod[1493]: PCUI: > AT^USSDMODE=?\r
ofonod[1493]: PCUI: < \r\nCOMMAND NOT SUPPORT\r\n
ofonod[1493]: PCUI: > AT^CVOICE=?\r
ofonod[1493]: PCUI: < \r\n^CVOICE:(1)\r\n\r\nOK\r\n
ofonod[1493]: PCUI: > AT^SYSINFO\r
ofonod[1493]: PCUI: < \r\n^SYSINFO:0,0,0,0,0,,0\r\n\r\nOK\r\n
ofonod[1493]: plugins/huawei.c:notify_sim_state() 0
ofonod[1493]: PCUI: > AT+CGMI\r
ofonod[1493]: PCUI: < \r\nhuawei\r\n\r\nOK\r\n
ofonod[1493]: PCUI: > AT^CVOICE?\r
ofonod[1493]: PCUI: < \r\n^CVOICE:1\r\n\r\nOK\r\n
ofonod[1493]: PCUI: > AT+CGMM\r
ofonod[1493]: PCUI: < \r\nEM770\r\n\r\nOK\r\n
ofonod[1493]: PCUI: > AT+CGMR\r
ofonod[1493]: PCUI: < \r\n11.104.16.12.00\r\n\r\nOK\r\n
ofonod[1493]: PCUI: > AT+CGSN\r
ofonod[1493]: PCUI: < \r\n355093024527802\r\n\r\nOK\r\n
ofonod[1493]: PCUI: < \r\n^RSSI:23\r\n\r\n^SRVST:1\r\n\r\n^MODE:5,4\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
ofonod[1493]: PCUI: < \r\n^BOOT:24527802,0,0,0,24\r\n
Any idea ?
--
Frederic Crozat <fcrozat(a)novell.com>
Novell
10 years, 3 months
