January 2011 - ofono - Ml01.01.Org

[PATCH 0/2] Add additional information for mandatory general result

by Jeevaka Badrappan

Hi, As per the ETSI TS 102 223 specification section 8.12.2, For the general result "terminal currently unable to process command", it is mandatory for the terminal to provide additional information. Defined values for additional information can be found in the same section. Coding '00' shall be used by the terminal if none of the defined values apply. Following set of patches, introduce a macro for adding the additional information and changes done to existing code to make use of added macro. Regards, Jeevaka Jeevaka Badrappan (2): stk: add additional info for terminal busy result stk: make use of ADD_ERROR_RESULT macro src/stk.c | 114 ++++++++++++++++++++++++++++++++++++------------------------- 1 files changed, 67 insertions(+), 47 deletions(-)

11 years, 8 months

2
3
0 / 0

[PATCH] plugins-mbm: Combining mbm_disable and reopen_callback

by Tomasz Gregorek

From: Tomasz Gregorek <tomasz.gregorek(a)stericsson.com> Combining mbm_disable and reopen_callback into one and removing 1 second delay between them to avoid call to reopen_callback after modem being disconnected. --- plugins/mbm.c | 41 +++++++++++------------------------------ 1 files changed, 11 insertions(+), 30 deletions(-) diff --git a/plugins/mbm.c b/plugins/mbm.c index dca9bd8..d1529ac 100644 --- a/plugins/mbm.c +++ b/plugins/mbm.c @@ -66,7 +66,6 @@ struct mbm_data { gboolean have_sim; struct ofono_gprs *gprs; struct ofono_gprs_context *gc; - guint reopen_source; enum mbm_variant variant; }; @@ -297,21 +296,26 @@ static GAtChat *create_port(const char *device) return chat; } -static void mbm_disconnect(gpointer user_data); - -static gboolean reopen_callback(gpointer user_data) +static void mbm_disconnect(gpointer user_data) { struct ofono_modem *modem = user_data; struct mbm_data *data = ofono_modem_get_data(modem); const char *data_dev; - data->reopen_source = 0; + DBG(""); + + if (data->gc) + ofono_gprs_context_remove(data->gc); + + g_at_chat_unref(data->data_port); + data->data_port = NULL; data_dev = ofono_modem_get_string(modem, "DataDevice"); data->data_port = create_port(data_dev); + if (data->data_port == NULL) - return FALSE; + return; if (getenv("OFONO_AT_DEBUG")) g_at_chat_set_debug(data->data_port, mbm_debug, "Data: "); @@ -323,30 +327,12 @@ static gboolean reopen_callback(gpointer user_data) data->gc = ofono_gprs_context_create(modem, 0, "atmodem", data->data_port); + if (data->gprs && data->gc) { ofono_gprs_context_set_type(data->gc, OFONO_GPRS_CONTEXT_TYPE_MMS); ofono_gprs_add_context(data->gprs, data->gc); } - - return FALSE; -} - -static void mbm_disconnect(gpointer user_data) -{ - struct ofono_modem *modem = user_data; - struct mbm_data *data = ofono_modem_get_data(modem); - - DBG(""); - - if (data->gc) - ofono_gprs_context_remove(data->gc); - - g_at_chat_unref(data->data_port); - data->data_port = NULL; - - /* Waiting for the +CGEV: ME DEACT might also work */ - data->reopen_source = g_timeout_add_seconds(1, reopen_callback, modem); } static int mbm_enable(struct ofono_modem *modem) @@ -425,11 +411,6 @@ static int mbm_disable(struct ofono_modem *modem) DBG("%p", modem); - if (data->reopen_source > 0) { - g_source_remove(data->reopen_source); - data->reopen_source = 0; - } - if (data->modem_port == NULL) return 0; -- 1.7.1

11 years, 8 months

3
5
0 / 0

[PATCH 0/2] Add ifxmodem support for enable/disable tty

by Jeevaka Badrappan

Hi, Following patch adds the ifxmodem support for enabling/disabling tty mode. Regards, Jeevaka Jeevaka Badrappan (2): ctm: add ofono_ctm_get_modem interface ifxmodem: add enable/disable ctm support Makefile.am | 3 +- drivers/ifxmodem/ctm.c | 243 +++++++++++++++++++++++++++++++++++++++++++ drivers/ifxmodem/ifxmodem.c | 2 + drivers/ifxmodem/ifxmodem.h | 3 + include/ctm.h | 2 + src/ctm.c | 5 + 6 files changed, 257 insertions(+), 1 deletions(-) create mode 100644 drivers/ifxmodem/ctm.c

11 years, 8 months

3
6
0 / 0

[PATCH] test: add set-call-forwarding

by Jarko Poutiainen

--- Makefile.am | 3 +- test/set-call-forwarding | 64 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+), 1 deletions(-) create mode 100755 test/set-call-forwarding diff --git a/Makefile.am b/Makefile.am index 4dec90a..ead154d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -449,7 +449,8 @@ test_scripts = test/backtrace \ test/set-tty \ test/set-gsm-band \ test/set-umts-band \ - test/lockdown-modem + test/lockdown-modem \ + test/set-call-forwarding if TEST testdir = $(pkglibdir)/test diff --git a/test/set-call-forwarding b/test/set-call-forwarding new file mode 100755 index 0000000..159a27c --- /dev/null +++ b/test/set-call-forwarding @@ -0,0 +1,64 @@ +#!/usr/bin/python + +import sys +import gobject + +import dbus +import dbus.mainloop.glib + +def property_changed(property, value): + if len(value.__str__()) > 0: + print "CF property %s changed to %s" % (property, value) + else: + print "CF property %s changed to disabled" % (property) + + if canexit: + mainloop.quit(); + +if __name__ == "__main__": + if len(sys.argv) < 3: + print "Usage: %s <property> <value>" % (sys.argv[0]) + print "Properties can be: VoiceUnconditional, VoiceBusy," + print " VoiceNoReply, VoiceNoReplyTimeout, VoiceNotReachable" + print "Value: number to or the timeout" + sys.exit(1) + + property = sys.argv[1] + value = sys.argv[2] + + canexit = False + + dbus.mainloop.glib.DBusGMainLoop(set_as_default=True) + + bus = dbus.SystemBus() + + manager = dbus.Interface(bus.get_object('org.ofono', '/'), + 'org.ofono.Manager') + + modems = manager.GetModems() + + cf = dbus.Interface(bus.get_object('org.ofono', modems[0][0]), + 'org.ofono.CallForwarding') + + cf.connect_to_signal("PropertyChanged", property_changed) + + if (property == "VoiceNoReplyTimeout"): + try: + cf.SetProperty(property, dbus.UInt16(value), + timeout = 100) + except dbus.DBusException, e: + print "Unable SetProperty", e + sys.exit(1); + else: + try: + cf.SetProperty(property, value, timeout = 100) + except dbus.DBusException, e: + print "Unable SetProperty", e + sys.exit(1); + + print "Set Property successfull" + + canexit = True + + mainloop = gobject.MainLoop() + mainloop.run() -- 1.7.0.4

11 years, 8 months

2
1
0 / 0

[PATCH] test: add disable-call-forwarding

by Jarko Poutiainen

--- Makefile.am | 3 +- test/disable-call-forwarding | 53 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 55 insertions(+), 1 deletions(-) create mode 100755 test/disable-call-forwarding diff --git a/Makefile.am b/Makefile.am index 4dec90a..2df0fbd 100644 --- a/Makefile.am +++ b/Makefile.am @@ -449,7 +449,8 @@ test_scripts = test/backtrace \ test/set-tty \ test/set-gsm-band \ test/set-umts-band \ - test/lockdown-modem + test/lockdown-modem \ + test/disable-call-forwarding if TEST testdir = $(pkglibdir)/test diff --git a/test/disable-call-forwarding b/test/disable-call-forwarding new file mode 100755 index 0000000..ca0ba90 --- /dev/null +++ b/test/disable-call-forwarding @@ -0,0 +1,53 @@ +#!/usr/bin/python + +import sys +import gobject + +import dbus +import dbus.mainloop.glib + +def property_changed(property, value): + if len(value.__str__()) > 0: + print "CF property %s changed to %s" % (property, value) + else: + print "CF property %s changed to disabled" % (property) + + if canexit: + mainloop.quit(); + +if __name__ == "__main__": + if len(sys.argv) < 2: + print "Usage: %s <type>" % (sys.argv[0]) + print "Type can be: all, conditional" + sys.exit(1) + + canexit = False + + type = sys.argv[1] + + dbus.mainloop.glib.DBusGMainLoop(set_as_default=True) + + bus = dbus.SystemBus() + + manager = dbus.Interface(bus.get_object('org.ofono', '/'), + 'org.ofono.Manager') + + modems = manager.GetModems() + + cf = dbus.Interface(bus.get_object('org.ofono', modems[0][0]), + 'org.ofono.CallForwarding') + + cf.connect_to_signal("PropertyChanged", property_changed) + + try: + cf.DisableAll(type, timeout = 100) + except dbus.DBusException, e: + print "Unable to DisableAll", e + sys.exit(1); + + print "DisableAll successful" + + canexit = True + + mainloop = gobject.MainLoop() + mainloop.run() -- 1.7.0.4

11 years, 8 months

2
1
0 / 0

[PATCH] TODO: Add task for main.conf

by Aki Niemi

--- TODO | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 757c587..4faee16 100644 --- a/TODO +++ b/TODO @@ -396,6 +396,14 @@ Miscellaneous Complexity: C2 Owner: Sjur Brændeland <sjur.brandeland(a)stericsson.com> +- Add support for main.conf. This task will add support for general + as well as per-atom configuration options that are read and parsed + at startup from a configuration file under /etc/ofono. + + Priority: Medium + Complexity: C1 + Owner: Aki Niemi <aki.niemi(a)nokia.com> + CDMA Voicecall ============== -- 1.7.1

11 years, 8 months

2
1
0 / 0

[PATCH] TODO: set owner of Support HFP AG emulator task

by Frédéric Danis

From: Frederic Danis <frederic.danis(a)linux.intel.com> --- TODO | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 495d539..28a6c32 100644 --- a/TODO +++ b/TODO @@ -106,6 +106,7 @@ Modem Emulator Complexity: C4 Priority: Medium + Owner: Frédéric Danis <frederic.danis(a)linux.intel.com> - Support extensions to HFP AG emulator. Some carkits support additional AT command extensions to the Bluetooth HFP AG standard. Refer to CE4A @@ -116,6 +117,7 @@ Modem Emulator Complexity: C4 Priority: Medium Depends: HFP AG emulator + Owner: Frédéric Dalleau <frederic.dalleau(a)linux.intel.com> - Support HSP AG. Similar to HFP AG emulator but implements the much reduced Bluetooth HSP AG profile. -- 1.7.1

11 years, 8 months

3
2
0 / 0

[PATCH] isimodem: fix return from call control requests

by Pekka.Pessi＠nokia.com

From: Pekka Pessi <Pekka.Pessi(a)nokia.com> --- drivers/isimodem/voicecall.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index c19e64d..6f866a5 100644 --- a/drivers/isimodem/voicecall.c +++ b/drivers/isimodem/voicecall.c @@ -795,7 +795,7 @@ static void isi_call_control_resp(const GIsiMessage *msg, void *data) } if (cause == CALL_CAUSE_NO_CAUSE) { - isi_ctx_return_failure(irc); + isi_ctx_return_success(irc); return; } -- 1.7.1

11 years, 8 months

2
1
0 / 0

[PATCH 00/16] M15 coding style fixes

by Jeevaka Badrappan

11 years, 8 months

2
17
0 / 0

Update interface with variable port numbers?

by Jessica Nilsson

Hi, we could probably use an update in the push_notification_register_agent in plugins/push-notification.c so that it would be possible to specify port numbers instead of them being hardcoded with #define WAP_PUSH_SRC_PORT 9200 #define WAP_PUSH_DST_PORT 2948 We would like to be able to use the oma-ilp 7276/tcp OMA Internal Location Protocol specified on http://www.iana.org/assignments/port-numbers This could also be used for other WAP based services. Is this something that you would agree would be useful and we could add to the TODO list? Best Regards, Jessica Nilsson

11 years, 8 months

2
1
0 / 0

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

ofono January 2011