[PATCH 1/1] gatserver: Add ATS5 command feature
by Olivier Guiter
---
gatchat/gatserver.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c
index be9f79a..25b7ba4 100644
--- a/gatchat/gatserver.c
+++ b/gatchat/gatserver.c
@@ -796,6 +796,7 @@ static char *extract_line(GAtServer *p, struct ring_buffer *rbuf)
int line_length = 0;
gboolean in_string = FALSE;
char s3 = p->v250.s3;
+ char s5 = p->v250.s5;
char *line;
int i;
@@ -837,7 +838,11 @@ static char *extract_line(GAtServer *p, struct ring_buffer *rbuf)
if (*buf == '"')
in_string = !in_string;
- if ((*buf == ' ' || *buf == '\t') && in_string == FALSE)
+ if (*buf == s5) {
+ if (i != 0)
+ i -= 1;
+ }
+ else if ((*buf == ' ' || *buf == '\t') && in_string == FALSE)
; /* Skip */
else if (*buf != s3)
line[i++] = *buf;
--
1.7.1
11 years, 7 months
[RESEND] IPv6 support
by Mika Liljeberg
Hi All,
Here are the IPv6 patches again, rebased to current master.
Regards,
MikaL
[RESEND PATCH 01/13] gprs: factor out common code
[RESEND PATCH 02/13] gprs: Update documentation for IPv6
[RESEND PATCH 03/13] gprs: driver interface changes for IPv6
[RESEND PATCH 04/13] gprs: core support for IPv6
[RESEND PATCH 05/13] test: modify test scripts for IPv6
[RESEND PATCH 06/13] isimodem: IPv6 support
[RESEND PATCH 07/13] atmodem: update to new gprs context interface
[RESEND PATCH 08/13] huaweimodem: update to new gprs context interface
[RESEND PATCH 09/13] mbmmodem: update to new gprs context interface
[RESEND PATCH 10/13] hsomodem: update to new gprs context interface
[RESEND PATCH 11/13] ifxmodem: update to new gprs context interface
[RESEND PATCH 12/13] stemodem: update to new gprs context interface
[RESEND PATCH 13/13] phonesim: add IPv6 support
Makefile.am | 3 +-
doc/connman-api.txt | 9 +-
drivers/atmodem/gprs-context.c | 41 ++--
drivers/hsomodem/gprs-context.c | 48 +++--
drivers/huaweimodem/gprs-context.c | 43 +++--
drivers/ifxmodem/gprs-context.c | 36 ++--
drivers/isimodem/gprs-context.c | 119 +++++++-----
drivers/mbmmodem/gprs-context.c | 65 ++++---
drivers/stemodem/gprs-context.c | 31 ++-
include/gprs-context.h | 27 ++-
plugins/phonesim.c | 32 +++-
src/gprs.c | 390 ++++++++++++++++++++++++------------
test/list-contexts | 6 +-
test/set-context-property | 38 ++++
14 files changed, 583 insertions(+), 305 deletions(-)
11 years, 7 months
[PATCH 0/1] Fix issue in ifxmodem set rat mode
by Jeevaka Badrappan
Hi,
Find the syntax of the XRAT set command:
Defined values
<AcT> indicates the radio access technology and may be
0 GSM single mode
1 GSM / UMTS Dual mode
2 UTRAN (UMTS)
< PreferredAct > This parameter is used for network registration in case of <AcT>=1.
0 RAT GSM
2 RAT UMTS
Regards,
Jeevaka
Jeevaka Badrappan (1):
ifxmodem: fix issue in set rat mode
drivers/ifxmodem/radio-settings.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
11 years, 7 months
[PATCH] ifxmodem: add CNAP support
by Jeevaka Badrappan
---
drivers/ifxmodem/voicecall.c | 51 ++++++++++++++++++++++++++++++++++++++++++
1 files changed, 51 insertions(+), 0 deletions(-)
diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c
index 30e6991..87a48e6 100644
--- a/drivers/ifxmodem/voicecall.c
+++ b/drivers/ifxmodem/voicecall.c
@@ -630,6 +630,56 @@ static void clip_notify(GAtResult *result, gpointer user_data)
ofono_voicecall_notify(vc, call);
}
+static void cnap_notify(GAtResult *result, gpointer user_data)
+{
+ struct ofono_voicecall *vc = user_data;
+ struct voicecall_data *vd = ofono_voicecall_get_data(vc);
+ GAtResultIter iter;
+ const char *name;
+ int validity;
+ GSList *l;
+ struct ofono_call *call;
+
+ /*
+ * Currently, its not clear which URC will contain the
+ * calling party name for the waiting call.
+ */
+ l = g_slist_find_custom(vd->calls,
+ GINT_TO_POINTER(CALL_STATUS_INCOMING),
+ at_util_call_compare_by_status);
+ if (l == NULL) {
+ ofono_error("CNAP for unknown call");
+ return;
+ }
+
+ g_at_result_iter_init(&iter, result);
+
+ if (!g_at_result_iter_next(&iter, "+CNAP:"))
+ return;
+
+ if (!g_at_result_iter_next_string(&iter, &name))
+ return;
+
+ if (strlen(name) > 0)
+ validity = CNAP_VALIDITY_VALID;
+ else
+ validity = CNAP_VALIDITY_NOT_AVAILABLE;
+
+ /* If we have CNI validity field, override our guessed value */
+ g_at_result_iter_next_number(&iter, &validity);
+
+ DBG("%s %d", name, validity);
+
+ call = l->data;
+
+ strncpy(call->name, name, OFONO_MAX_CALLER_NAME_LENGTH);
+ call->name[OFONO_MAX_CALLER_NAME_LENGTH] = '\0';
+ call->cnap_validity = validity;
+
+ if (call->type == 0)
+ ofono_voicecall_notify(vc, call);
+}
+
static void ccwa_notify(GAtResult *result, gpointer user_data)
{
struct ofono_voicecall *vc = user_data;
@@ -746,6 +796,7 @@ static void ifx_voicecall_initialized(gboolean ok, GAtResult *result,
g_at_chat_register(vd->chat, "+CRING:", cring_notify, FALSE, vc, NULL);
g_at_chat_register(vd->chat, "+CLIP:", clip_notify, FALSE, vc, NULL);
+ g_at_chat_register(vd->chat, "+CNAP:", cnap_notify, FALSE, vc, NULL);
g_at_chat_register(vd->chat, "+CCWA:", ccwa_notify, FALSE, vc, NULL);
g_at_chat_register(vd->chat, "+XEM:", xem_notify, FALSE, vc, NULL);
g_at_chat_register(vd->chat, "+XCALLSTAT:", xcallstat_notify,
--
1.7.0.4
11 years, 7 months
Re: [PATCH] plugin: add plugin for Linktop/Teracom LW273 data card
by Amit Mendapara
Hi Danis,
I have submitted three patches as you suggested but no one has reviewed it.
Would you tell me what else I can do to ensure it's been integrated in
ofono?
Regards
--
Amit Mendapara
On Mon, Feb 7, 2011 at 8:51 AM, Amit Mendapara <mendapara.amit(a)gmail.com>wrote:
> Hi Denis,
>
> Thanks you for your kind attention. I will resubmit as suggested.
>
> Regards
> --
> Amit Mendapara
>
>
> On Fri, Feb 4, 2011 at 10:07 PM, Denis Kenzior <denkenz(a)gmail.com> wrote:
>
>> Hi Amit,
>>
>> On 02/03/2011 10:34 AM, Amit Mendapara wrote:
>> > The LW273 and LW272 devices are being distributed by BSNL in India
>> > with Teracom
>> > brand name. Both the devices have similar specs except data speed and
>> > having same
>> > usb id (230d:0001).
>> >
>> > Links:
>> >
>> > http://www.bsnl.in/service/3G/3G_files/3g.htm
>> > http://www.teracom.in/htmls/3G.html
>> > http://www.linktop.com.cn/en/Products.asp?FID=1&LID=302
>> > <http://www.linktop.com.cn/en/Products.asp?FID=1&LID=302>
>> > http://amit-mendapara.blogspot.com/2010/11/amazing-bsnl-3g.html
>> >
>> > Regards
>> > --
>> > Amit Mendapara
>> >
>>
>> Thanks for your patch, but please resubmit it in a proper format for
>> review. The easiest way to do that is git-send-email. Also, please
>> have a look at the 'Submitting patches' section in the HACKING file of
>> oFono. Ideally this should be a 3 patch series, one adding the linktop
>> driver, one modifying udev and one modifying ofono.rules.
>>
>> Regards,
>> -Denis
>>
>
>
11 years, 7 months
[PATCH] doc: remove unused GetIcon from SimToolKit
by Jeevaka Badrappan
---
doc/stk-api.txt | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/doc/stk-api.txt b/doc/stk-api.txt
index 054821b..529c734 100644
--- a/doc/stk-api.txt
+++ b/doc/stk-api.txt
@@ -10,14 +10,6 @@ Methods dict GetProperties()
Returns properties for the SimToolkit object. See the
properties section for available properties.
- array{byte} GetIcon(byte id)
-
- Returns the icon data for icon identified by id.
-
- Possible Errors: [service].Error.InvalidArguments
- [service].Error.InvalidFormat
- [service].Error.NotFound
-
void SelectItem(byte item, object agent)
Selects an item from the main menu, thus triggering
--
1.7.0.4
11 years, 7 months
[PATCH 0/1] Update possible errors
by Jeevaka Badrappan
Hi,
Following patch updates the possible errors to the api documentation.
Possible error values are updated based on currently returned errors.
Regards,
Jeevaka
Jeevaka Badrappan (1):
doc: Update possible errors
doc/audio-settings-api.txt | 2 -
doc/call-barring-api.txt | 31 ++++++++++++++++++++++
doc/call-forwarding-api.txt | 16 +++++++++++
doc/call-meter-api.txt | 14 ++++++++++
doc/call-settings-api.txt | 8 ++++++
doc/call-volume-api.txt | 9 +++---
doc/cdma-voicecall-manager-api.txt | 10 +++++++
doc/cell-broadcast-api.txt | 7 ++---
doc/connman-api.txt | 25 ++++++++++++++----
doc/manager-api.txt | 2 -
doc/message-api.txt | 2 -
doc/message-waiting-api.txt | 7 +++--
doc/messagemanager-api.txt | 14 ++++++++--
doc/modem-api.txt | 10 ++++---
doc/network-api.txt | 16 +++++++----
doc/phonebook-api.txt | 2 +-
doc/pushnotification-api.txt | 8 ++++++
doc/radio-settings-api.txt | 9 +++---
doc/sim-api.txt | 37 +++++++++++++++++++++++++-
doc/stk-api.txt | 17 +++++++-----
doc/supplementaryservices-api.txt | 20 +++++++++++---
doc/voicecall-api.txt | 17 +++++++++++-
doc/voicecallmanager-api.txt | 49 ++++++++++++++++++++++++++++++++++-
23 files changed, 273 insertions(+), 59 deletions(-)
11 years, 7 months
[PATCH] network: Remove unused SetProperty
by Jeevaka Badrappan
---
doc/network-api.txt | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/doc/network-api.txt b/doc/network-api.txt
index 4cb6366..db8da75 100644
--- a/doc/network-api.txt
+++ b/doc/network-api.txt
@@ -12,16 +12,6 @@ Methods dict GetProperties()
Possible Errors: [service].Error.InvalidArguments
- void SetProperty(string name, variant value)
-
- Changes the value of the specified property. Only
- properties that are listed as readwrite are
- changeable. On success a PropertyChanged signal
- will be emitted.
-
- Possible Errors: [service].Error.InvalidArguments
- [service].Error.DoesNotExist
-
void Register()
Attempts to register to the default network. The
--
1.7.0.4
11 years, 7 months
ANNOUNCE: telepathy-ring 2.1.3
by Pekka Pessi
Telepathy-Ring 2.1.3 ("I wish it need not have happened in my time")
is now available for download from:
http://telepathy.freedesktop.org/releases/telepathy-ring/telepathy-ring-2...
md5sum: 292d132ca62051398e8087d3721dedbb telepathy-ring-2.1.3.tar.gz
sha1sum: 8de6bae3337896bd2cf4d502e1bd09794fe10a6d telepathy-ring-2.1.3.tar.gz
What is it?
===========
Telepathy-Ring a 3GPP (GSM and 3G UMTS) connection manager for
Telepathy framework using oFono. It supports voice calls and
short messages.
What's New?
===========
Added manual page, updated documentation
Add manager for Conference channels
Not using sms-glib wrapper anymore
What's Fixed?
===========
BMC#12164, 12932: emitting correct message type
Fix problems closing channels when disconnecting
--
Pekka.Pessi mail at nokia.com
11 years, 7 months
Issue with GPRS not attached?
by Robertino Benis
Hi there,
Has anyone seen this issue with oFono:
Error activating /ifx0/context1: org.ofono.Error.NotAttached: GPRS is
not attached
I am using IFX modem with specific hardware board. I have not seen this
issue before. I was using latest oFono from git (cloned sometimes on
Thursday, Feb 10, 2011). Maybe SIM card changed features? :-)
[root@localhost test]# ./list-contexts
[ /ifx0 ]
[ /ifx0/context1 ]
Username =
Protocol = ip
Name = Internet
Settings = { }
Active = 0
AccessPointName = wap.cingular
Password =
Type = internet
[root@localhost test]#
Context has been created, and APN was added. Log file did not look
suspicious, so it should run fine.
However, when I try
[root@localhost test]# ./enable-gprs
Connecting modem /ifx0...
[root@localhost test]#
- no error
But
[root@localhost test]# ./activate-context
Error activating /ifx0/context1: org.ofono.Error.NotAttached: GPRS is
not attached
GPRS driver was successful loaded, and several GPRS channels created
during the ifx_enable(), from plugin. Each GPRS context seems to be
added properly.
I have not seen any particular error in the log, that would hint
something more solid.
Connman does not see the celular profile, as well.
Thanks for hints,
-- r.
11 years, 7 months
