[PATCH 1/2] sim900: Add support for SIMCOM SMS delivery reports
by r.r.zaripov＠gmail.com
From: Renat Zaripov <r.r.zaripov(a)gmail.com>
---
plugins/sim900.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/plugins/sim900.c b/plugins/sim900.c
index f7b1642..b2d1b46 100644
--- a/plugins/sim900.c
+++ b/plugins/sim900.c
@@ -224,7 +224,8 @@ static void sim900_post_sim(struct ofono_modem *modem)
DBG("%p", modem);
ofono_phonebook_create(modem, 0, "atmodem", data->modem);
- ofono_sms_create(modem, 0, "atmodem", data->modem);
+ ofono_sms_create(modem, OFONO_VENDOR_SIMCOM, "atmodem",
+ data->modem);
}
static void sim900_post_online(struct ofono_modem *modem)
--
1.7.7.3
8 years, 10 months
[PATCH] hso: Don't access freed data, in hso_set_online
by Neil Jerram
---
plugins/hso.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugins/hso.c b/plugins/hso.c
index 497c64e..249bb2c 100644
--- a/plugins/hso.c
+++ b/plugins/hso.c
@@ -421,9 +421,9 @@ static void hso_set_online(struct ofono_modem *modem, ofono_bool_t online,
if (g_at_chat_send(chat, command, NULL, set_online_cb, cbd, g_free))
return;
- g_free(cbd);
-
CALLBACK_WITH_FAILURE(cb, cbd->data);
+
+ g_free(cbd);
}
static void hso_pre_sim(struct ofono_modem *modem)
--
1.7.9
8 years, 10 months
[PATCH] hso: Don't access freed data, in hso_set_online
by Neil Jerram
---
plugins/hso.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/plugins/hso.c b/plugins/hso.c
index 4834c56..697beaa 100644
--- a/plugins/hso.c
+++ b/plugins/hso.c
@@ -422,7 +422,7 @@ static void hso_set_online(struct ofono_modem *modem, ofono_bool_t online,
g_free(cbd);
- CALLBACK_WITH_FAILURE(cb, cbd->data);
+ CALLBACK_WITH_FAILURE(cb, user_data);
}
static void hso_pre_sim(struct ofono_modem *modem)
--
1.7.9
8 years, 10 months
[PATCH] configure/make basics
by Jens Rehsack
Hi,
while hacking on a plugin for mmsd to deal with supl push
messages, I ran into a few "not so nice" solved things
in configure.ac / Makefile.am
1) libtool handling
libtool configuration is meanwhile done using LT_INIT(options)
instead of AC_PROC_LIBTOOL and alike
==> because of libtool stores some of the configuration
in the generated libtool shell script, it's reasonable
to run LT_INIT as late as possible (painfully learned
while writing and porting c++ software for many OS)
2) additional libraries
do no require explicit libraries (like -lresolv), always
let a devop in doubt invoke configure with
LIBS="-lmyspecialwrapper" to wrap between available
libs/functions and requirements
See pkgsrc's nbcompat library for example
Best regards,
Jens
8 years, 10 months
Introducing Jens Rehsack
by Jens Rehsack
Hi oFono community,
before start to asking questions, I'd like to introduce myself and
why I joined into the community.
I'm hired by Vodafone Global (Vodafone Group Services GmbH) to
assist there on some networking services, currently location
services. One part of the job will be to work with oFono, using
it, learn some work flows - and when possible - improving it.
This part of the job will also include submitting patches.
My technical background is system development on Unix and
embedded systems, most times in wired networking and related
protocols. Mobile protocols and standards are completely new
to me and I'm not tightened into names, abbreviations and
protocols related to mobile world.
I hope I can learn quickly what I need to know to start practical
things with oFono.
Best regards,
Jens
8 years, 10 months
Enhancing mmsd
by Jens Rehsack
Hi,
as announced in my last mail, I'm here to work with + improve ofono
and related software.
My next task will be to implement an ofono plugin which handles some
UPL push messages. Because there is only one "listener" at
org.ofono.PushNotificationAgent possible, I see two and a half way
to go on:
1) fork ofono-mmsd to handle more message types than mms
(via plugins?)
1b) fork ofono-mmsd to handle only SUPL push messages
2) find a way for more listeners on push messages
Any suggestions, preferred ways?
Best regards and have a nice weekend,
Jens
8 years, 10 months
[PATCHv2 0/8] Call forwarding state handling change
by Oleg Zhurakivskyy
Hello,
Please find the changes in order to correct call forwarding states.
Changes from v2:
- Don't run conditional queries if cfu is active.
- Clear the conditional cache flag on conditional deactivation
while cfu is active.
Regards,
Oleg
Oleg Zhurakivskyy (8):
call-forwarding: Minor style fixes
call-forwarding: Minor refactoring of is_cfu_enabled()
call-forwarding: Don't set conditional cfs when cfu is active
call-forwarding: Don't report conditional cfs when cfu is active
call-forwarding: Emit signals to mask/unmask conditional cfs
call-forwarding: Don't run conditional queries if cfu is active
call-forwarding: Clear the conditional cache flag
TODO: Remove completed call forwarding state task
TODO | 17 -----
src/call-forwarding.c | 182 ++++++++++++++++++++++++++++++++++--------------
2 files changed, 129 insertions(+), 70 deletions(-)
--
1.7.5.4
8 years, 10 months
[PATCH] sim900: Using AT+SPIC for obtaining times remains input SIM PIN/PUK
by r.r.zaripov＠gmail.com
From: Renat Zaripov <r.r.zaripov(a)gmail.com>
In SIMCOM SIM900 not implemented AT+CPINR, but possible use AT+SPIC
instead this one.
AT+SPIC Times Remained to Input SIM PIN/PUK
+SPIC: <pin1>,<pin2>,<puk1>,<puk2>
Parameters
<pin1> Times remained to input chv1
<pin2> Times remained to input chv2
<puk1> Times remained to input puk1
<puk2> Times remained to input puk2
---
drivers/atmodem/sim.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
plugins/sim900.c | 2 +-
2 files changed, 46 insertions(+), 1 deletions(-)
diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
index 8edd582..8ee9822 100644
--- a/drivers/atmodem/sim.c
+++ b/drivers/atmodem/sim.c
@@ -62,6 +62,7 @@ static const char *zpinpuk_prefix[] = { "+ZPINPUK:", NULL };
static const char *oercn_prefix[] = { "_OERCN:", NULL };
static const char *cpinr_prefixes[] = { "+CPINR:", "+CPINRE:", NULL };
static const char *epin_prefix[] = { "*EPIN:", NULL };
+static const char *spic_prefix[] = { "+SPIC:", NULL };
static const char *none_prefix[] = { NULL };
static void at_crsm_info_cb(gboolean ok, GAtResult *result, gpointer user_data)
@@ -800,6 +801,45 @@ static void at_cpinr_cb(gboolean ok, GAtResult *result, gpointer user_data)
cb(&error, retries, cbd->data);
}
+static void at_spic_cb(gboolean ok, GAtResult *result, gpointer user_data)
+{
+ struct cb_data *cbd = user_data;
+ ofono_sim_pin_retries_cb_t cb = cbd->cb;
+ const char *final = g_at_result_final_response(result);
+ GAtResultIter iter;
+ struct ofono_error error;
+ int retries[OFONO_SIM_PASSWORD_INVALID];
+ size_t i;
+ static enum ofono_sim_password_type password_types[] = {
+ OFONO_SIM_PASSWORD_SIM_PIN,
+ OFONO_SIM_PASSWORD_SIM_PUK,
+ OFONO_SIM_PASSWORD_SIM_PIN2,
+ OFONO_SIM_PASSWORD_SIM_PUK2,
+ };
+
+ decode_at_error(&error, final);
+
+ if (!ok) {
+ cb(&error, NULL, cbd->data);
+ return;
+ }
+
+ g_at_result_iter_init(&iter, result);
+
+ if (!g_at_result_iter_next(&iter, "+SPIC:"))
+ goto error;
+
+ BUILD_PIN_RETRIES_ARRAY(password_types, ARRAY_SIZE(password_types),
+ retries);
+
+ cb(&error, retries, cbd->data);
+
+ return;
+
+error:
+ CALLBACK_WITH_FAILURE(cb, NULL, cbd->data);
+}
+
static void at_pin_retries_query(struct ofono_sim *sim,
ofono_sim_pin_retries_cb_t cb,
void *data)
@@ -840,6 +880,11 @@ static void at_pin_retries_query(struct ofono_sim *sim,
at_epin_cb, cbd, g_free) > 0)
return;
break;
+ case OFONO_VENDOR_SIMCOM:
+ if (g_at_chat_send(sd->chat, "AT+SPIC", spic_prefix,
+ at_spic_cb, cbd, g_free) > 0)
+ return;
+ break;
default:
if (g_at_chat_send(sd->chat, "AT+CPINR", cpinr_prefixes,
at_cpinr_cb, cbd, g_free) > 0)
diff --git a/plugins/sim900.c b/plugins/sim900.c
index bc5f9c5..87d640f 100644
--- a/plugins/sim900.c
+++ b/plugins/sim900.c
@@ -210,7 +210,7 @@ static void sim900_pre_sim(struct ofono_modem *modem)
DBG("%p", modem);
ofono_devinfo_create(modem, 0, "atmodem", data->modem);
- sim = ofono_sim_create(modem, 0, "atmodem", data->modem);
+ sim = ofono_sim_create(modem, OFONO_VENDOR_SIMCOM, "atmodem", data->modem);
if (sim)
ofono_sim_inserted_notify(sim, TRUE);
--
1.7.7.3
8 years, 10 months
[PATCH] call-volume.c: Register the call-volume interface just after the +CMUT query
by Philippe Nunes
With this change, the mute status and the volume level are initialised in the
call-volume atom. This allows also to expose the call-volume interface even
if the command +CLVL is not supported as it is the case for IFX.
---
drivers/atmodem/call-volume.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/atmodem/call-volume.c b/drivers/atmodem/call-volume.c
index e2535b1..4c32ba7 100644
--- a/drivers/atmodem/call-volume.c
+++ b/drivers/atmodem/call-volume.c
@@ -65,6 +65,7 @@ static void cmut_query(gboolean ok, GAtResult *result, gpointer user_data)
if (g_at_result_iter_next_number(&iter, &muted) == FALSE)
return;
+ ofono_call_volume_register(cv);
ofono_call_volume_set_muted(cv, muted);
}
@@ -94,7 +95,6 @@ static void clvl_query(gboolean ok, GAtResult *result, gpointer user_data)
(cvd->clvl_max - cvd->clvl_min);
ofono_call_volume_set_speaker_volume(cv, percent);
- ofono_call_volume_register(cv);
}
static void clvl_range_query(gboolean ok, GAtResult *result, gpointer user_data)
--
1.7.1
8 years, 11 months
[PATCH] emulator: Fix start of RING event
by Frédéric Danis
RING event should only be sent when callsetup indicator is set to
Incoming and there is no active call.
If call indicator is set to inactive while callsetup is
already set to Incoming (waiting call has generated +CCWA),
no RING event should be sent.
Ref.: PTS test TC_AG_TWC_BV_02_I
---
src/emulator.c | 18 +++---------------
1 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/src/emulator.c b/src/emulator.c
index 262e782..0fa6eac 100644
--- a/src/emulator.c
+++ b/src/emulator.c
@@ -1219,23 +1219,12 @@ void ofono_emulator_set_indicator(struct ofono_emulator *em,
}
/*
- * Ring timer should be started when:
- * - callsetup indicator is set to Incoming and there is no active call
- * (not a waiting call)
- * - or call indicator is set to inactive while callsetup is already
- * set to Incoming.
+ * Ring timer should be started when callsetup indicator is set to
+ * Incoming and there is no active call (not a waiting call).
* In those cases, a first RING should be sent just after the +CIEV
* Ring timer should be stopped for all other values of callsetup
*/
- if (waiting)
- return;
-
- /* Call state went from active/held + waiting -> incoming */
- if (call && value == OFONO_EMULATOR_CALL_INACTIVE &&
- cs_ind->value == OFONO_EMULATOR_CALLSETUP_INCOMING)
- goto start_ring;
-
- if (!callsetup)
+ if (!callsetup || waiting)
return;
if (value != OFONO_EMULATOR_CALLSETUP_INCOMING) {
@@ -1247,7 +1236,6 @@ void ofono_emulator_set_indicator(struct ofono_emulator *em,
return;
}
-start_ring:
notify_ring(em);
em->callsetup_source = g_timeout_add_seconds(RING_TIMEOUT,
notify_ring, em);
--
1.7.1
8 years, 11 months
