[PATCH mmsd 01/12] Constify GDBus tables
by Lucas De Marchi
Constify method tables with the following commands:
find . -name '*.[ch]' -exec sed -i \
's/\(c\)\(GDBusSignalTable .* =\)/\1 const \2/g' {} \;
find . -name '*.[ch]' -exec sed -i \
's/\(c\)\(GDBusMethodTable .* =\)/\1 const \2/g' {} \;
---
plugins/ofono.c | 2 +-
src/service.c | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/plugins/ofono.c b/plugins/ofono.c
index f598c5e..29e8f06 100644
--- a/plugins/ofono.c
+++ b/plugins/ofono.c
@@ -114,7 +114,7 @@ static DBusMessage *agent_release(DBusConnection *conn,
return NULL;
}
-static GDBusMethodTable agent_methods[] = {
+static const GDBusMethodTable agent_methods[] = {
{ "ReceiveNotification", "aya{sv}", "", agent_receive },
{ "Release", "", "", agent_release,
G_DBUS_METHOD_FLAG_NOREPLY },
diff --git a/src/service.c b/src/service.c
index 6bcdede..a269556 100644
--- a/src/service.c
+++ b/src/service.c
@@ -222,13 +222,13 @@ static DBusMessage *msg_mark_read(DBusConnection *conn,
return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
}
-static GDBusMethodTable message_methods[] = {
+static const GDBusMethodTable message_methods[] = {
{ "MarkRead", "", "", msg_mark_read },
{ "Delete", "", "", msg_delete },
{ }
};
-static GDBusSignalTable message_signals[] = {
+static const GDBusSignalTable message_signals[] = {
{ "PropertyChanged", "sv" },
{ }
};
@@ -979,14 +979,14 @@ release_msg:
return __mms_error_trans_failure(dbus_msg);
}
-static GDBusMethodTable service_methods[] = {
+static const GDBusMethodTable service_methods[] = {
{ "SendMessage", "assa(sss)", "o", send_message },
{ "GetMessages", "", "a(oa{sv})", get_messages },
{ "GetConversation", "su", "a(oa{sv})", get_conversation },
{ }
};
-static GDBusSignalTable service_signals[] = {
+static const GDBusSignalTable service_signals[] = {
{ "MessageAdded", "oa{sv}" },
{ "MessageRemoved", "o" },
{ }
@@ -2342,12 +2342,12 @@ static DBusMessage *get_services(DBusConnection *conn,
return reply;
}
-static GDBusMethodTable manager_methods[] = {
+static const GDBusMethodTable manager_methods[] = {
{ "GetServices", "", "a(oa{sv})", get_services },
{ }
};
-static GDBusSignalTable manager_signals[] = {
+static const GDBusSignalTable manager_signals[] = {
{ "ServiceAdded", "oa{sv}" },
{ "ServiceRemoved", "o" },
{ }
--
1.7.10.2
8 years, 6 months
[PATCH] Add WSP_VALUE_TYPE_TEXT support in wsp_decode_application_id()
by Jens Rehsack
From: Jens Rehsack <sno(a)NetBSD.org>
---
src/wsputil.c | 6 ++++++
1 Datei geändert, 6 Zeilen hinzugefügt(+)
diff --git a/src/wsputil.c b/src/wsputil.c
index 1b2b2b7..c4c9d62 100644
--- a/src/wsputil.c
+++ b/src/wsputil.c
@@ -496,6 +496,12 @@ gboolean wsp_decode_application_id(struct wsp_header_iter *iter,
*/
if (wsp_header_iter_get_val_type(iter) == WSP_VALUE_TYPE_SHORT) {
val = *pdu_val & 0x7f;
+ } else if (wsp_header_iter_get_val_type(iter) == WSP_VALUE_TYPE_TEXT) {
+ val_len = wsp_header_iter_get_val_len(iter);
+ val = -1;
+
+ if (out_value)
+ *out_value = pdu_val;
} else {
val_len = wsp_header_iter_get_val_len(iter);
--
1.7.10.1
8 years, 6 months
[PATCH_v3] gprs: Fix wrong behavior when network is lost
by Guillaume Zajac
---
src/gprs.c | 106 ++++++++++++++++++++++++++++++++++++++++++++++++------------
1 files changed, 85 insertions(+), 21 deletions(-)
diff --git a/src/gprs.c b/src/gprs.c
index 0d25506..9428003 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -1436,6 +1436,78 @@ void ofono_gprs_resume_notify(struct ofono_gprs *gprs)
update_suspended_property(gprs, FALSE);
}
+static void gprs_attached_update(struct ofono_gprs *gprs);
+
+static void gprs_deactivate_for_release(const struct ofono_error *error,
+ void *data)
+{
+ struct pri_context *ctx = data;
+ struct ofono_gprs *gprs = ctx->gprs;
+ DBusConnection *conn = ofono_dbus_get_connection();
+ dbus_bool_t value;
+
+ if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
+ DBG("Deactivating context failed with error: %s",
+ telephony_error_to_str(error));
+
+ return;
+ }
+
+ pri_reset_context_settings(ctx);
+ release_context(ctx);
+
+ value = FALSE;
+ ofono_dbus_signal_property_changed(conn, ctx->path,
+ OFONO_CONNECTION_CONTEXT_INTERFACE,
+ "Active", DBUS_TYPE_BOOLEAN, &value);
+
+ /*
+ * If "Attached" property was about to be signalled as TRUE but there
+ * were still active contexts, try again to signal "Attached" property
+ * to registered applications after active contexts have been released.
+ */
+ gprs_attached_update(gprs);
+}
+
+static gboolean check_active_contexts(struct ofono_gprs *gprs)
+{
+ GSList *l;
+ struct pri_context *ctx;
+
+ for (l = gprs->contexts; l; l = l->next) {
+ ctx = l->data;
+
+ if (ctx->active == TRUE)
+ return TRUE;
+ }
+
+ return FALSE;
+}
+
+static void deactivate_active_contexts(struct ofono_gprs *gprs)
+{
+ GSList *l;
+ struct pri_context *ctx;
+
+ for (l = gprs->contexts; l; l = l->next) {
+ struct ofono_gprs_context *gc;
+
+ ctx = l->data;
+
+ if (ctx->active == FALSE)
+ continue;
+
+ /* This context is already being messed with */
+ if (ctx->pending)
+ continue;
+
+ gc = ctx->context_driver;
+
+ gc->driver->deactivate_primary(gc, ctx->context.cid,
+ gprs_deactivate_for_release, ctx);
+ }
+}
+
static void gprs_attached_update(struct ofono_gprs *gprs)
{
DBusConnection *conn = ofono_dbus_get_connection();
@@ -1450,30 +1522,22 @@ static void gprs_attached_update(struct ofono_gprs *gprs)
if (attached == gprs->attached)
return;
- gprs->attached = attached;
-
- if (gprs->attached == FALSE) {
- GSList *l;
- struct pri_context *ctx;
-
- for (l = gprs->contexts; l; l = l->next) {
- ctx = l->data;
-
- if (ctx->active == FALSE)
- continue;
-
- pri_reset_context_settings(ctx);
- release_context(ctx);
-
- value = FALSE;
- ofono_dbus_signal_property_changed(conn, ctx->path,
- OFONO_CONNECTION_CONTEXT_INTERFACE,
- "Active", DBUS_TYPE_BOOLEAN, &value);
- }
-
+ /*
+ * If an active context is found, a PPP session might be still active
+ * at driver level. "Attached" = TRUE property can't be signalled to
+ * the applications registered on GPRS properties.
+ * Active contexts have to be deactivated.
+ */
+ if (attached == FALSE) {
+ deactivate_active_contexts(gprs);
gprs->bearer = -1;
+ } else if (check_active_contexts(gprs) == TRUE) {
+ deactivate_active_contexts(gprs);
+ return;
}
+ gprs->attached = attached;
+
path = __ofono_atom_get_path(gprs->atom);
value = attached;
ofono_dbus_signal_property_changed(conn, path,
--
1.7.5.4
8 years, 6 months
[PATCH] bluez version 4.99 is required.
by Marko Saukko
bluez 4.99 introduced key_size to bt_security struct that is used in
ofono, thus the requirement needs to be higher.
Signed-off-by: Marko Saukko <marko.saukko(a)gmail.com>
---
configure.ac | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 251a726..9f77a3c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -177,8 +177,8 @@ AC_ARG_ENABLE(bluetooth, AC_HELP_STRING([--disable-bluetooth],
[disable Bluetooth modem support]),
[enable_bluetooth=${enableval}])
if (test "${enable_bluetooth}" != "no"); then
- PKG_CHECK_MODULES(BLUEZ, bluez >= 4.30, dummy=yes,
- AC_MSG_ERROR(Bluetooth library >= 4.30 is required))
+ PKG_CHECK_MODULES(BLUEZ, bluez >= 4.99, dummy=yes,
+ AC_MSG_ERROR(Bluetooth library >= 4.99 is required))
fi
AC_SUBST(BLUEZ_CFLAGS)
AC_SUBST(BLUEZ_LIBS)
--
1.7.7
8 years, 6 months
Re: ofono-tests internet context: DNS works, ping wget and ssh do not (Connection Refused)
by Denis Kenzior
Hi Darren,
On 05/09/2012 05:46 PM, Darren Hart wrote:
> I have successfully used ofono-tests to enable,online,activate,and
> create-internet-context. I have an IP address and added the opendns servers. DNS
> appears to be working and the route looks sane-ish.
>
Please keep in mind that oFono is only signaling settings to an external
component (e.g. a connection manager like ConnMan). So route
assignment, DNS entry assignment, etc are not done by oFono. oFono only
brings up the interface and assigns the local IPv4 address.
> However, ping, wget, and ssh all fail. ping just sits there, wget and ssh both
> fail with Connection Refused.
>
> Is there something obvious/common I might be running into?
>
> I'm using ofono 1.5. The steps I took for context follow:
>
> # ./enable-modem
> Connecting modem /mbm_0...
>
> # ./online-modem
> Setting modem /mbm_0 online...
>
> # ./activate-context
>
These steps are fine, is your context pre-configured already? What does
the output of list-contexts look like?
> # ./create-internet-context
> Found context /mbm_0/context1
>
Generally you do this _before_ activate_context and you give parameters
for the context settings. e.g. create-internet-context
"apn.operator.com" "username" "password"
> # ifconfig usb0
> usb0 Link encap:Ethernet HWaddr 02:80:37:EC:02:00
> inet addr:10.25.40.80 Bcast:10.25.40.95 Mask:255.255.255.224
> inet6 addr: fe80::80:37ff:feec:200/64 Scope:Link
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:6 errors:0 dropped:0 overruns:0 frame:0
> TX packets:41 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:846 (846.0 B) TX bytes:28270 (27.6 KiB)
That looks good.
>
> # cat /etc/resolv.conf
> # Generated by Connection Manager
> nameserver 208.67.222.222
> nameserver 208.67.220.220
> nameserver 127.0.0.1
>
> # route -n
> Kernel IP routing table
> Destination Gateway Genmask Flags Metric Ref Use Iface
> 0.0.0.0 10.25.40.66 0.0.0.0 UG 0 0 0 usb0
> 10.25.40.64 0.0.0.0 255.255.255.224 U 0 0 0 usb0
> 10.25.40.66 0.0.0.0 255.255.255.255 UH 0 0 0 usb0
> 172.18.7.170 10.25.40.66 255.255.255.255 UGH 0 0 0 usb0
>
The route assignment seems fine, I assume you're using connman?
> # ping dvhart.com
> PING dvhart.com (184.154.165.98): 56 data bytes
> ^C
> --- dvhart.com ping statistics ---
> 1 packets transmitted, 0 packets received, 100% packet loss
>
> # wget http://www.dvhart.com/darren/hello
> Connecting to www.dvhart.com (184.154.165.98:80)
> wget: can't connect to remote host (184.154.165.98): Connection refused
>
> # ssh dvhart(a)dvhart.com
> ssh: Exited: Error connecting: Connection refused
>
> After disabling usb0 and bringup eth0, all of the above commands work as
> expected.
>
>
> And finally, I saved the output of list-modems off, but I don't recall
> when in the process, but I'm including it for the modem information, etc:
>
> # ./list-modems
> [ /mbm_0 ]
> Features = gprs net cbs ussd gps sms stk rat sim
> Emergency = 0
> Powered = 1
> Lockdown = 0
> Interfaces = org.ofono.ConnectionManager org.ofono.NetworkRegistration org.ofono.CellBroadcast org.ofono.SupplementaryServices org.ofono.LocationReporting org.ofono.SmartMessaging org.ofono.PushNotification org.ofono.MessageManager org.ofono.SimToolkit org.ofono.RadioSettings org.ofono.SimManager
> Online = 1
> Model = F5521gw
> Revision = R2A07(R2A07)
> Type = hardware
> Serial = 356215040140315
> Manufacturer = Ericsson
> [ org.ofono.ConnectionManager ]
> Powered = 1
> Attached = 1
> Bearer = none
> Suspended = 0
> RoamingAllowed = 0
> [ org.ofono.NetworkRegistration ]
> Status = registered
> Strength = 80
> Name = AT&T
> LocationAreaCode = 33998
> Mode = auto-only
> MobileCountryCode = 310
> Technology = hspa
> CellId = 13805302
> MobileNetworkCode = 410
I see you're on AT&T. What APN are you using, the WAP-only APN or
something that allows actual internet connections?
> [ org.ofono.CellBroadcast ]
> Topics =
> Powered = 1
> [ org.ofono.SupplementaryServices ]
> State = idle
> [ org.ofono.LocationReporting ]
> Type = nmea
> Enabled = 0
> [ org.ofono.SmartMessaging ]
> [ org.ofono.PushNotification ]
> [ org.ofono.MessageManager ]
> Alphabet = default
> UseDeliveryReports = 0
> Bearer = cs-preferred
> ServiceCenterAddress = +13123149810
> [ org.ofono.SimToolkit ]
> IdleModeIcon =
> MainMenuTitle =
> MainMenu =
> MainMenuIcon =
> [ org.ofono.RadioSettings ]
> TechnologyPreference = any
> [ org.ofono.SimManager ]
> Retries = [pin2 = 3] [puk2 = 10] [pin = 3] [puk = 10]
> MobileCountryCode = 310
> FixedDialing = 0
> SubscriberNumbers =
> PreferredLanguages = en
> BarredDialing = 0
> CardIdentifier = 89014104254691314226
> LockedPins =
> MobileNetworkCode = 410
> SubscriberIdentity = 310410469131422
> Present = 1
> PinRequired = none
>
This looks sane?
Regards,
-Denis
8 years, 6 months
[PATCH_v2] atmodem: Fix crash on context activation.
by Guillaume Zajac
Shutdown PPP session if modem did not do it.
---
drivers/atmodem/gprs-context.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
index 16893ce..100c80b 100644
--- a/drivers/atmodem/gprs-context.c
+++ b/drivers/atmodem/gprs-context.c
@@ -239,6 +239,17 @@ static void at_gprs_activate_primary(struct ofono_gprs_context *gc,
memcpy(gcd->username, ctx->username, sizeof(ctx->username));
memcpy(gcd->password, ctx->password, sizeof(ctx->password));
+ /*
+ * For some modem, mainly Huawei branded, when GPRS is no more attached
+ * to the network, oFono core will reset context although the modem
+ * has not ended ppp sesssion at driver level.
+ * In this case trigger a disconnection manually and send an error.
+ */
+ if (gcd->ppp != NULL && gcd->state == STATE_ACTIVE) {
+ g_at_ppp_shutdown(gcd->ppp);
+ goto error;
+ }
+
gcd->state = STATE_ENABLING;
if (gcd->vendor == OFONO_VENDOR_ZTE) {
--
1.7.4.1
8 years, 6 months
[PATCH 0/2] mmsd: GetConversation
by Ronald Tessier
These patches concern mmsd and are related to lastest patches applied.
Ronald Tessier (2):
test: Add python get-conversation test
TODO: Update TODO to remove GetConversation entry
Makefile.am | 3 ++-
TODO | 10 ----------
test/get-conversation | 34 ++++++++++++++++++++++++++++++++++
3 files changed, 36 insertions(+), 11 deletions(-)
create mode 100755 test/get-conversation
--
1.7.4.1
8 years, 6 months
mms: next steps
by Ronald Tessier
Hi Marcel,
Now that mms' TODO is almost empty (I've sent a set of patches yesterday
that implement the last entry of the TODO).
What should we add to release a first version of MMS ?
What's already in place :
- MMS submission,
- MMS reception (automatic retrieval support),
- MMS storage with status support,
- (Basic) error management with transaction completion on restart.
What can be added :
- Manual retrieval support for MMS reception,
- Delivery report support (M-Delivered.ind),
- Enhance D-Bus API (DeleteMessages(), DeleteConversation() ...)
- or something else ...
How do you see the next actions to take?
Thanks in advance for your feedback.
Best regards,
Ronald
8 years, 6 months
ofono-tests internet context: DNS works, ping wget and ssh do not (Connection Refused)
by Darren Hart
I have successfully used ofono-tests to enable,online,activate,and
create-internet-context. I have an IP address and added the opendns servers. DNS
appears to be working and the route looks sane-ish.
However, ping, wget, and ssh all fail. ping just sits there, wget and ssh both
fail with Connection Refused.
Is there something obvious/common I might be running into?
I'm using ofono 1.5. The steps I took for context follow:
# ./enable-modem
Connecting modem /mbm_0...
# ./online-modem
Setting modem /mbm_0 online...
# ./activate-context
# ./create-internet-context
Found context /mbm_0/context1
# ifconfig usb0
usb0 Link encap:Ethernet HWaddr 02:80:37:EC:02:00
inet addr:10.25.40.80 Bcast:10.25.40.95 Mask:255.255.255.224
inet6 addr: fe80::80:37ff:feec:200/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:6 errors:0 dropped:0 overruns:0 frame:0
TX packets:41 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:846 (846.0 B) TX bytes:28270 (27.6 KiB)
# cat /etc/resolv.conf # Generated by Connection Manager
nameserver 208.67.222.222
nameserver 208.67.220.220
nameserver 127.0.0.1
# route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric Ref Use Iface
0.0.0.0 10.25.40.66 0.0.0.0 UG 0 0 0 usb0
10.25.40.64 0.0.0.0 255.255.255.224 U 0 0 0 usb0
10.25.40.66 0.0.0.0 255.255.255.255 UH 0 0 0 usb0
172.18.7.170 10.25.40.66 255.255.255.255 UGH 0 0 0 usb0
# ping dvhart.com PING dvhart.com (184.154.165.98): 56 data bytes ^C --- dvhart.com ping statistics --- 1 packets transmitted, 0 packets received, 100% packet loss
# wget http://www.dvhart.com/darren/hello Connecting to www.dvhart.com (184.154.165.98:80) wget: can't connect to remote host (184.154.165.98): Connection refused
# ssh dvhart(a)dvhart.com ssh: Exited: Error connecting: Connection refused
After disabling usb0 and bringup eth0, all of the above commands work as
expected.
And finally, I saved the output of list-modems off, but I don't recall
when in the process, but I'm including it for the modem information, etc:
# ./list-modems [ /mbm_0 ]
Features = gprs net cbs ussd gps sms stk rat sim Emergency = 0
Powered = 1
Lockdown = 0
Interfaces = org.ofono.ConnectionManager org.ofono.NetworkRegistration org.ofono.CellBroadcast org.ofono.SupplementaryServices org.ofono.LocationReporting org.ofono.SmartMessaging org.ofono.PushNotification org.ofono.MessageManager org.ofono.SimToolkit org.ofono.RadioSettings org.ofono.SimManager Online = 1
Model = F5521gw
Revision = R2A07(R2A07)
Type = hardware
Serial = 356215040140315
Manufacturer = Ericsson
[ org.ofono.ConnectionManager ]
Powered = 1
Attached = 1
Bearer = none
Suspended = 0
RoamingAllowed = 0
[ org.ofono.NetworkRegistration ]
Status = registered
Strength = 80
Name = AT&T
LocationAreaCode = 33998
Mode = auto-only
MobileCountryCode = 310
Technology = hspa
CellId = 13805302
MobileNetworkCode = 410
[ org.ofono.CellBroadcast ]
Topics = Powered = 1
[ org.ofono.SupplementaryServices ]
State = idle
[ org.ofono.LocationReporting ]
Type = nmea
Enabled = 0
[ org.ofono.SmartMessaging ]
[ org.ofono.PushNotification ]
[ org.ofono.MessageManager ]
Alphabet = default
UseDeliveryReports = 0
Bearer = cs-preferred
ServiceCenterAddress = +13123149810
[ org.ofono.SimToolkit ]
IdleModeIcon = MainMenuTitle = MainMenu = MainMenuIcon = [ org.ofono.RadioSettings ]
TechnologyPreference = any
[ org.ofono.SimManager ]
Retries = [pin2 = 3] [puk2 = 10] [pin = 3] [puk = 10] MobileCountryCode = 310
FixedDialing = 0
SubscriberNumbers = PreferredLanguages = en BarredDialing = 0
CardIdentifier = 89014104254691314226
LockedPins = MobileNetworkCode = 410
SubscriberIdentity = 310410469131422
Present = 1
PinRequired = none
Thanks,
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
8 years, 6 months
[PATCHv2 0/4] mmsd: GetConversation support
by Ronald Tessier
These patches concern mmsd and implement "GetConversation" D-Bus API.
Ronald Tessier (4):
service: Retrieve get_conversation() args
service: Fill conversation list with messages
service: Sort conversation list by message date
doc: Update service-api.txt
doc/service-api.txt | 6 ++
src/service.c | 141 +++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 147 insertions(+), 0 deletions(-)
--
1.7.4.1
8 years, 6 months
