[PATCH_v4 0/5] Private network request to ConnMan
by Guillaume Zajac
Hi,
Changelog from v3 is:
- Add private-network source/include
- ConnMan plugin is independant from emulator
- Each application that need VPN will pass a callback as argument
when private network is requested. This callback will contain the
private network settings.
Guillaume Zajac (5):
gatppp: Add new contructor to use external fd
private-network: add callback typedef drivers and settings
private-network: add request/release functions and new feature to
Makefile.am
emulator: add request/release private network calls
connman: add plugin in oFono to request request/release private
network
Makefile.am | 10 +-
gatchat/gatppp.c | 33 +++++-
gatchat/gatppp.h | 1 +
gatchat/ppp.h | 2 +-
gatchat/ppp_net.c | 40 ++++---
include/private-network.h | 59 +++++++++
plugins/connman.c | 297 +++++++++++++++++++++++++++++++++++++++++++++
src/emulator.c | 49 ++++++--
src/ofono.h | 6 +
src/private-network.c | 89 ++++++++++++++
10 files changed, 556 insertions(+), 30 deletions(-)
create mode 100644 include/private-network.h
create mode 100644 plugins/connman.c
create mode 100644 src/private-network.c
1 month
ERROR:Reject SCO: Agent not registered.
by Abhishek Dharmapurikar
Hi,
I was trying to setup HFP uing ofono. I have the following setup
Rasperry Pi B+ ( ARM1176JZF-S)
Bluez 5.32
Pulseaudio 6.0
ofono 1.16
Used the following steps
http://padovan.org/blog/2010/02/handsfree-profile-into-bluez-and-ofono/
start pulseaudio, bluetoothd and ofonod
Connect to phone using bluetoothctl
./enable-modem
./dial-number
loopback
I was able to pair my nexus 4 device and use the script ./dial-number which
actually sets a call up. But the audio of the call doesn't route to the
default sink. I see the following error in ofonod
*Reject SCO: Agent not registered*
Which could be the reason for the audio problem.
Things that I have already tried.
Patched http://cgit.freedesktop.org/~jprvita/pulseaudio/ file
bluetooth-headsets-media-api.
Recompiled the raspbian kernel with
*CONFIG_BT_SCOCONFIG_BT_HCIUSB_SCO*
enabled
Added
*Enable = Source,Sink,Headset,Gateway,Control,MediaDisable = Socket*
to /etc/bluetooth/audio.conf.
Things that could be wrong
When I do a pactl list cards, i see the bluetooth card at #0 with two
profiles.
* Profiles: a2dp_source: High Fidelity Capture (A2DP
Source) (sinks: 0, sources: 1, priority: 10, available: yes)
headset_audio_gateway: Headset Audio Gateway (HSP/HFP) (sinks: 1, sources:
1, priority: 20, available: no) off: Off (sinks: 0, sources:
0, priority: 0, available: yes) Active Profile: a2dp_source*
But when I try making the headset_audio_gateway the default profile. I get
*$ sudo pactl set-card-profile 0 headset_audio_gatewayFailure: Input/Output
error*
Also read this in the pulseaudio notes
http://www.freedesktop.org/wiki/Software/PulseAudio/Notes/6.0/
"When building PulseAudio, it's possible to choose between "native" and
"ofono" BlueZ 5 headset backends."
How do I specify that I wish to use the ofono headset backend? Is that the
problem?
6 years
[PATCH] gdbus: Drop message replies if the sender requested no reply
by Philip Withnall
If the sender flags a D-Bus message as not expecting a reply, it is
against system bus policy to send a reply — sending one will result in
errors being sent to us by dbus-daemon.
Magically drop all replies to messages which request no reply.
This is not a complete fix. In an ideal world, the existing check for
G_DBUS_METHOD_FLAG_NOREPLY would be dropped, as the server should be
prepared to return a reply to every method, if the client requests and
expects one — otherwise the client will time out. However, that’s a
much
bigger change with a much bigger risk of breaking things, so I’ll stick
with this for now.
Signed-off-by: Philip Withnall <philip.withnall(a)collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie(a)collabora.co.uk>
---
gdbus/object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index 96db516..146a255 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -258,7 +258,8 @@ static DBusHandlerResult
process_message(DBusConnection *connection,
reply = method->function(connection, message,
iface_user_data);
- if (method->flags & G_DBUS_METHOD_FLAG_NOREPLY) {
+ if (method->flags & G_DBUS_METHOD_FLAG_NOREPLY ||
+ dbus_message_get_no_reply(message)) {
if (reply != NULL)
dbus_message_unref(reply);
return DBUS_HANDLER_RESULT_HANDLED;
--
2.5.0
6 years
[PATCH] gatchat/gatppp.c: Add timeout handler in ppp_enter_phase
by Marko Šulejić
* ppp_enter_phase calls ppp_dead if the PPP phase is PPP_PHASE_DEAD
&& ppp->sta_pending == FALSE, but fails if sta_pending is never set
to FALSE. So a timeout handler was added to handle this case too.
---
gatchat/gatppp.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c
index 5144084..f84535a 100644
--- a/gatchat/gatppp.c
+++ b/gatchat/gatppp.c
@@ -361,8 +361,12 @@ static inline void ppp_enter_phase(GAtPPP *ppp, enum ppp_phase phase)
DBG(ppp, "%d", phase);
ppp->phase = phase;
- if (phase == PPP_PHASE_DEAD && ppp->sta_pending == FALSE)
- ppp->ppp_dead_source = g_idle_add(ppp_dead, ppp);
+ if (phase == PPP_PHASE_DEAD) {
+ if(ppp->sta_pending)
+ ppp->ppp_dead_source = g_timeout_add(5000, ppp_dead, ppp);
+ else
+ ppp->ppp_dead_source = g_idle_add(ppp_dead, ppp);
+ }
}
void ppp_set_auth(GAtPPP *ppp, const guint8* auth_data)
--
2.1.0
6 years
Huawei 3131 with idVendor=12d1, idProduct=14fe
by matti kaasinen
Hi!
Have anyone managed using newer version of Huawei 3131 (idVendor=12d1,
idProduct=14fe pair) together with connman/ofono?
Older version of Huawei 3131 registered nicely with cdc_ether and was shown
as wired service and connected automatically with eth1 interface.
------------------
Modeswitch:
------------------
seems noticing modem as idVendor=12d1, idProduct=1506 device.
-------------------------------------------------------------
Connman seems creating wwan0 interface
-------------------------------------------------------------
connmand[349]: wwan0 {create} index 3 type 1 <ETHER>
connmand[349]: wwan0 {update} flags 4098 <DOWN>
connmand[349]: wwan0 {newlink} index 3 address 58:2C:80:13:92:63 mtu 1500
connmand[349]: wwan0 {newlink} index 3 operstate 2 <DOWN>
connmand[349]: Adding interface wwan0 [ cellular ]
-----------
usbcore:
-----------
usbcore: registered new interface driver usbserial
usb-storage 2-1:1.5: USB Mass Storage device detected
usbcore: registered new interface driver cdc_ncm
usbcore: registered new interface driver cdc_wdm
usbcore: registered new interface driver option
-------------------------
huawei_cdc_ncm:
--------------------------
huawei_cdc_ncm 2-1:1.1 wwan0: register 'huawei_cdc_ncm' at
usb-musb-hdrc.1.auto-1, Huawei CDC NCM device, 58:2c:80:13:92:63
-------------------------
usbserial:
--------------------------
usbserial: USB Serial support registered for GSM modem (1-port)
usb 2-1: GSM modem (1-port) converter now attached to ttyUSB0
usb 2-1: GSM modem (1-port) converter now attached to ttyUSB1
usb 2-1: GSM modem (1-port) converter now attached to ttyUSB2
-------------------------
ofono:
--------------------------
Modem and NDIS support (CDC support: NDIS port)
Besides /dev/ttyUSBx ports there also exists /dev/cdc-wdm0
Modem shows up with connmanctl technologies
/net/connman/technology/cellular
Name = Cellular
Type = cellular
Powered = False
Connected = False
Tethering = False
But it does not show as service
It is required to make manual online-modem ofono test command to get
cellular technology powered. Then it is also shown as service. Also fast
blinking green sign switches to slow blinking blue sign.
However, no interfaces are shown with ifconfig command nor any connection
is made when etherenet is unplugged.
Also no proggress is shown when
connmanctl session connect --type cellular
is made.
Do anyone know what I miss?
Thanks,
Matti
If so, what kernel modules should I have present?
6 years
[PATCH] gprs: Fix the ContextAdded() signal Introspection
by John Ernberg
From: John Ernberg <john.ernberg(a)actia.se>
This matches the behavior described by the documentation the signal
value returned by the code. This was causing a headache when using
stricter D-Bus wrappers like dbus-c++.
---
src/gprs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gprs.c b/src/gprs.c
index ba797dd..9192e68 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -2385,7 +2385,7 @@ static const GDBusSignalTable manager_signals[] = {
{ GDBUS_SIGNAL("PropertyChanged",
GDBUS_ARGS({ "name", "s" }, { "value", "v" })) },
{ GDBUS_SIGNAL("ContextAdded",
- GDBUS_ARGS({ "path", "o" }, { "properties", "v" })) },
+ GDBUS_ARGS({ "path", "o" }, { "properties", "a{sv}" })) },
{ GDBUS_SIGNAL("ContextRemoved", GDBUS_ARGS({ "path", "o" })) },
{ }
};
--
1.9.1
6 years, 1 month
[PATCH] network: Fix use-after-free caused by Scan() in poor reception.
by John Ernberg
From: John Ernberg <john.ernberg(a)actia.se>
When issuing a Scan() in poor reception while attached to an operator it's
fully possible to get no results, which causes the attached operator to be
cleaned up. In certain scenarios this would cause a use-after-free.
Make sure to clean up all the references to the operator when it's destroyed.
---
src/network.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/network.c b/src/network.c
index 1dddcac..5329c28 100644
--- a/src/network.c
+++ b/src/network.c
@@ -257,6 +257,9 @@ static void network_operator_destroy(gpointer user_data)
{
struct network_operator_data *op = user_data;
+ if (op->netreg->current_operator == op)
+ op->netreg->current_operator = NULL;
+
g_free(op);
}
--
1.9.1
6 years, 1 month
[PATCH] gprs: Make the ContextAdded return a variant.
by John Ernberg
From: John Ernberg <john.ernberg(a)actia.se>
This matches the behavior described by the documentation and the signal
value described in the introspection. This was causing a headache when
using stricter D-Bus wrappers like dbus-c++.
---
src/gprs.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/gprs.c b/src/gprs.c
index ba797dd..b583c28 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -1879,7 +1879,17 @@ static void send_context_added_signal(struct ofono_gprs *gprs,
const char *path;
DBusMessage *signal;
DBusMessageIter iter;
+ DBusMessageIter var;
DBusMessageIter dict;
+ char typesig[5];
+ char arraysig[6];
+
+ arraysig[0] = DBUS_TYPE_ARRAY;
+ arraysig[1] = typesig[0] = DBUS_DICT_ENTRY_BEGIN_CHAR;
+ arraysig[2] = typesig[1] = DBUS_TYPE_STRING;
+ arraysig[3] = typesig[2] = DBUS_TYPE_VARIANT;
+ arraysig[4] = typesig[3] = DBUS_DICT_ENTRY_END_CHAR;
+ arraysig[5] = typesig[4] = '\0';
path = __ofono_atom_get_path(gprs->atom);
signal = dbus_message_new_signal(path,
@@ -1893,11 +1903,15 @@ static void send_context_added_signal(struct ofono_gprs *gprs,
path = context->path;
dbus_message_iter_append_basic(&iter, DBUS_TYPE_OBJECT_PATH, &path);
- dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY,
- OFONO_PROPERTIES_ARRAY_SIGNATURE,
+ dbus_message_iter_open_container(&iter, DBUS_TYPE_VARIANT,
+ arraysig, &var);
+
+ dbus_message_iter_open_container(&var, DBUS_TYPE_ARRAY,
+ typesig,
&dict);
append_context_properties(context, &dict);
- dbus_message_iter_close_container(&iter, &dict);
+ dbus_message_iter_close_container(&var, &dict);
+ dbus_message_iter_close_container(&iter, &var);
g_dbus_send_message(conn, signal);
}
--
1.9.1
6 years, 1 month
[PATCH] cbs: Resolve a use-after-free that could occur with rapid location changes.
by John Ernberg
From: John Ernberg <john.ernberg(a)actia.se>
What happens is that the timeout leaks and then the cbs struct with
the callback is cleaned up, resulting in a SIGSEGV when the callback
occurs from the glib loop.
---
src/cbs.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/cbs.c b/src/cbs.c
index b5f0b72..fdc44a1 100644
--- a/src/cbs.c
+++ b/src/cbs.c
@@ -1029,11 +1029,14 @@ out:
/*
* In order to minimize signal transmissions we wait about X seconds
- * before reseting the base station id. The hope is that we receive
+ * before resetting the base station id. The hope is that we receive
* another cell broadcast with the new base station name within
* that time
*/
if (lac_changed || ci_changed) {
+ if(cbs->reset_source)
+ g_source_remove(cbs->reset_source);
+
cbs->reset_source =
g_timeout_add_seconds(3, reset_base_station_name, cbs);
}
--
1.9.1
6 years, 1 month
[PATCH] gprs: Make the ContextAdded return a variant.
by John Ernberg
From: John Ernberg <john.ernberg(a)actia.se>
I am not sure if this is the desired way to resolve this issue. This will
break compatibility with Connman and possibly other systems using oFono
through D-Bus.
I do have a patch for Connman that I can send to them if this patch is
accepted, but not for any other potential systems.
It is also possible to change the introspection and the documentation,
the proposed patch is however more in line with the rest of oFono's
D-Bus API.
Discussion regarding this is encouraged before any possible acception
of this patch.
John Ernberg (1):
gprs: Make the ContextAdded return a variant.
src/gprs.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
--
1.9.1
6 years, 1 month
