[PATCH] rilmodem: fix sim_status_cb debug logging
by Tony Espy
During the re-factoring of rilmodem's sim atom
messaging code, the sim_status_cb function's
RIL tracing code was converted to DBG calls.
This change adds the same prefix to DBG/trace
calls when a single message's parameters span
more than one DBG call. This makes it easier
to filter out trace messages when looking at a
log file.
---
drivers/rilmodem/sim.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/rilmodem/sim.c b/drivers/rilmodem/sim.c
index ada7c20..5307d67 100644
--- a/drivers/rilmodem/sim.c
+++ b/drivers/rilmodem/sim.c
@@ -777,9 +777,11 @@ static void sim_status_cb(struct ril_msg *message, gpointer user_data)
message->serial_no,
"RIL_REQUEST_GET_SIM_STATUS");
- DBG("card_state=%d,universal_pin_state=%d,"
+ DBG("[%d,%04d]< card_state=%d,universal_pin_state=%d,"
"gsm_umts_index=%d,cdma_index=%d,ims_index=%d,"
"num_apps=%d",
+ g_ril_get_slot(sd->ril),
+ message->serial_no,
card_state, universal_pin_state,
gsm_umts_app_index, cdma_app_index, ims_app_index,
num_apps);
@@ -886,7 +888,8 @@ static void sim_status_cb(struct ril_msg *message, gpointer user_data)
g_free(sd->aid_str);
sd->aid_str = parcel_r_string(&rilp); /* AID */
- DBG("app_type: %d, passwd_state: %d, aid_str (AID): %s",
+ DBG("[%d,%04d]< app_type: %d, passwd_state: %d, aid_str (AID): %s",
+ g_ril_get_slot(sd->ril), message->serial_no,
sd->app_type, sd->passwd_state, sd->aid_str);
/*
--
2.1.4
5 years, 9 months
[PATCH 0/2] Fix rilmodem SMSC quoting
by Tony Espy
This changeset fixes the string formatting of the
RIL_REQUEST_SET_SMSC_ADDRESS request, which requires
the string to bracketed by quotation marks.
Tony Espy (2):
rilmodem: restore SET_SMSC_ADDRESS number format
unit: update test-rilmodem-sms set_sca test case
drivers/rilmodem/sms.c | 4 +++-
unit/test-rilmodem-sms.c | 8 ++++----
2 files changed, 7 insertions(+), 5 deletions(-)
--
2.1.4
5 years, 9 months
U-Blox modem sends unprintable chars before "AT+CGMS=<seq>" reply: ofono (1.16) close the serial port ?
by Fabio
Hello,
I'm using ofono 1.16 with some patch to add sms manager to the Ublox driver.
Someone could confirm that ofono close the serial port when it receives
some unexpected/unprintable character before the "AT+CGMS=<seq>" reply from
the modem?
If yes, is possible to discard these characters instead of hanging-up the
serial port? Could I have some info about the source I have to patch ?
Thanks in advance,
FabioT
--
****************************************************************************************************************************
"Solo due cose sono infinite: l'universo e la stupidità umana. Ma della
prima non sono sicuro". [Albert Einstein]
****************************************************************************************************************************
5 years, 9 months
