[PATCH_v4 0/5] Private network request to ConnMan
by Guillaume Zajac
Hi,
Changelog from v3 is:
- Add private-network source/include
- ConnMan plugin is independant from emulator
- Each application that need VPN will pass a callback as argument
when private network is requested. This callback will contain the
private network settings.
Guillaume Zajac (5):
gatppp: Add new contructor to use external fd
private-network: add callback typedef drivers and settings
private-network: add request/release functions and new feature to
Makefile.am
emulator: add request/release private network calls
connman: add plugin in oFono to request request/release private
network
Makefile.am | 10 +-
gatchat/gatppp.c | 33 +++++-
gatchat/gatppp.h | 1 +
gatchat/ppp.h | 2 +-
gatchat/ppp_net.c | 40 ++++---
include/private-network.h | 59 +++++++++
plugins/connman.c | 297 +++++++++++++++++++++++++++++++++++++++++++++
src/emulator.c | 49 ++++++--
src/ofono.h | 6 +
src/private-network.c | 89 ++++++++++++++
10 files changed, 556 insertions(+), 30 deletions(-)
create mode 100644 include/private-network.h
create mode 100644 plugins/connman.c
create mode 100644 src/private-network.c
2 months, 1 week
Read/Write EFcfis/EFcphs-cff files
by Jeevaka Badrappan
Hi,
This patch reads and writes the call forwarding unconditional status
from and to the SIM depending on the SIM file availability.
New property needs to be added due to the fact that number won't be
available from the cphs-cff file.
Incase of SIM, EFcphs-cff file holds call forwarding status and it
is represented as a flag. In case of USIM(EFcfis), we have the status
flag and also number.So, adding new property for status and using the
existing VoiceUnconditional with number will work for both SIM and USIM cases.
Other option is to have 2 properties, "VoiceUnconditional" and "Number".
"VoiceUnconditional" will have the status of the call forwarding( "enabled",
"disabled") whereas the "Number" property will have the call forwared number.
offline-online state transitions results in caching the call forwaring status
every time. To avoid this, call forwarding atom is moved to the post sim and
its moved also due to the fact that call forwarding status doesn't change in
roaming.
Regards,
Jeevaka
Jeevaka Badrappan (7):
call-forwarding: Read/Write cfis/cphs-cff
ifx: Move call forwarding to post sim
isigen: Move call forwarding to post sim
plugins/n900: Move call forwarding to post sim
phonesim: Move call forwarding to post sim
doc: Add new property to call forwarding
TODO: Marking the Read/Write EFcfis task as done
TODO | 9 --
doc/call-forwarding-api.txt | 5 +
doc/features.txt | 5 +
plugins/ifx.c | 2 +-
plugins/isigen.c | 2 +-
plugins/n900.c | 2 +-
plugins/phonesim.c | 3 +-
src/call-forwarding.c | 242 ++++++++++++++++++++++++++++++++++++++++++-
8 files changed, 256 insertions(+), 14 deletions(-)
3 months
[PATCH] Simcom support
by Anthony Viallard
Add SIMCOM support.
I developped this with the SIM5216E chipset and ofono 1.12.
- SMS and GPRS work (in the same time) ;
- SIM card presence check ;
- No voice part because I can't test it ;
- Use default characters set instead GSM because it works like that
for what I'm doing (SMS+GPRS) (by default, the set is IRA for SIM5216E).
Also, the SIMCOM doc affraids me about problems when using GSM
(this setting causes easily software flow control (XON /XOFF) problems.).
Signed-off-by: Anthony Viallard <homer242 at gmail.com>
--- ofono-1.12.orig/Makefile.am 2012-04-20 21:06:29.000000000 +0200
+++ ofono-1.12/Makefile.am 2013-01-21 17:17:48.089627277 +0100
@@ -371,6 +371,9 @@ builtin_sources += plugins/samsung.c
builtin_modules += sim900
builtin_sources += plugins/sim900.c
+builtin_modules += simcom
+builtin_sources += plugins/simcom.c
+
if BLUETOOTH
builtin_modules += bluetooth
builtin_sources += plugins/bluetooth.c plugins/bluetooth.h
--- ofono-1.12.orig/drivers/atmodem/sms.c 2012-04-20 21:06:29.000000000 +0200
+++ ofono-1.12/drivers/atmodem/sms.c 2013-01-21 16:48:44.460627485 +0100
@@ -805,6 +807,7 @@ static gboolean build_cnmi_string(char *
case OFONO_VENDOR_NOVATEL:
case OFONO_VENDOR_HUAWEI:
case OFONO_VENDOR_ZTE:
+ case OFONO_VENDOR_SIMCOM:
/* MSM devices advertise support for mode 2, but return an
* error if we attempt to actually use it. */
mode = "1";
diff -pruN ofono-1.12.orig/drivers/atmodem/sim.c ofono-1.12/drivers/atmodem/sim.c
--- ofono-1.12.orig/drivers/atmodem/sim.c 2013-01-23 11:38:22.959609087 +0100
+++ ofono-1.12/drivers/atmodem/sim.c 2013-01-23 11:57:52.602608948 +0100
@@ -1023,12 +1023,18 @@ static void at_pin_send_cb(gboolean ok,
FALSE, cbd, g_free);
return;
case OFONO_VENDOR_ZTE:
case OFONO_VENDOR_ALCATEL:
case OFONO_VENDOR_HUAWEI:
+ case OFONO_VENDOR_SIMCOM:
/*
* On ZTE modems, after pin is entered, SIM state is checked
* by polling CPIN as their modem doesn't provide unsolicited
* notification of SIM readiness.
+ *
+ * On SIMCOM modems, SIM is busy after pin is entered (we've
+ * got an "+CME ERROR: 14" at "AT+CPIN?" request) and ofono
+ * don't catch the "+CPIN: READY" message sent by the modem
+ * when SIM is ready. So, use extra CPIN to check the state.
*/
sd->sim_state_query = at_util_sim_state_query_new(sd->chat,
2, 20, sim_state_cb, cbd,
diff -purN ofono-1.12/drivers/atmodem/network-registration.c ofono-patched/drivers/atmodem/network-registration.c
--- ofono-1.12/drivers/atmodem/network-registration.c 2013-01-18 15:04:03.598659165 +0100
+++ ofono-patched/drivers/atmodem/network-registration.c 2013-01-18 14:54:03.256659236 +0100
@@ -1411,6 +1411,14 @@ static void at_creg_set_cb(gboolean ok,
}
switch (nd->vendor) {
+ case OFONO_VENDOR_SIMCOM:
+ /* Register for CSQ changes */
+ g_at_chat_send(nd->chat, "AT+AUTOCSQ=1,1", none_prefix,
+ NULL, NULL, NULL);
+
+ g_at_chat_register(nd->chat, "+CSQ:",
+ csq_notify, FALSE, netreg, NULL);
+ break;
case OFONO_VENDOR_PHONESIM:
g_at_chat_register(nd->chat, "+CSQ:",
csq_notify, FALSE, netreg, NULL);
@@ -1534,7 +1537,6 @@ static void at_creg_set_cb(gboolean ok,
break;
case OFONO_VENDOR_NOKIA:
case OFONO_VENDOR_SAMSUNG:
- case OFONO_VENDOR_SIMCOM:
/* Signal strength reporting via CIND is not supported */
break;
default:
--- /dev/null 2013-01-28 10:34:59.843091650 +0100
+++ ofono-1.12/plugins/simcom.c 2013-02-15 16:16:38.058552544 +0100
@@ -0,0 +1,401 @@
+/*
+ *
+ * oFono - Open Source Telephony
+ *
+ * Copyright (C) 2008-2011 Intel Corporation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ *
+ */
+
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
+#include <errno.h>
+#include <stdlib.h>
+#include <stdio.h>
+
+#include <glib.h>
+#include <gatchat.h>
+#include <gattty.h>
+
+#define OFONO_API_SUBJECT_TO_CHANGE
+#include <ofono/plugin.h>
+#include <ofono/modem.h>
+#include <ofono/devinfo.h>
+#include <ofono/netreg.h>
+#include <ofono/sim.h>
+#include <ofono/cbs.h>
+#include <ofono/sms.h>
+#include <ofono/ussd.h>
+#include <ofono/gprs.h>
+#include <ofono/gprs-context.h>
+#include <ofono/radio-settings.h>
+#include <ofono/phonebook.h>
+#include <ofono/log.h>
+
+#include <drivers/atmodem/atutil.h>
+#include <drivers/atmodem/vendor.h>
+
+#define MAX_IGNITION_POOL_CALL 7
+
+#define CMEERR_SIMBUSY 14
+
+static const char *none_prefix[] = { NULL };
+
+struct simcom_data {
+ GAtChat *modem;
+ GAtChat *data;
+ guint ignition_pool;
+ unsigned int ignition_pool_call;
+ unsigned int at_ignition_pending;
+ ofono_bool_t have_sim;
+};
+
+/* Callback and helpers functions */
+static void simcom_debug(const char *str, void *user_data)
+{
+ const char *prefix = user_data;
+
+ ofono_info("%s%s", prefix, str);
+}
+
+static gboolean simcom_ignition(gpointer user_data)
+{
+ struct ofono_modem *modem = user_data;
+ struct simcom_data *data = ofono_modem_get_data(modem);
+
+ ++data->ignition_pool_call;
+
+ if(data->at_ignition_pending > 0)
+ {
+ if(data->ignition_pool_call > MAX_IGNITION_POOL_CALL)
+ {
+ ofono_error("Ignition timeout");
+ return FALSE;
+ }
+
+ /* Waiting reply of AT commands */
+ DBG("Waiting AT reply...");
+ return TRUE;
+ }
+
+ ofono_modem_set_powered(modem, TRUE);
+
+ return FALSE;
+}
+
+static void simcom_sim_status(gboolean ok, GAtResult *result, gpointer user_data)
+{
+ struct ofono_modem *modem = user_data;
+ struct ofono_error error;
+ struct simcom_data *data = ofono_modem_get_data(modem);
+
+ --data->at_ignition_pending;
+
+ if(!ok)
+ {
+ decode_at_error(&error, g_at_result_final_response(result));
+ if(error.type == OFONO_ERROR_TYPE_CME)
+ {
+ if(error.error == CMEERR_SIMBUSY)
+ {
+ DBG("System is busy. Retry...");
+ g_at_chat_send(data->data, "AT+CPIN?",
+ none_prefix,
+ simcom_sim_status, modem,
+ NULL);
+ ++data->at_ignition_pending;
+ return;
+ }
+ }
+
+ data->have_sim = FALSE;
+ return;
+ }
+
+ /* If doesn't have an "fatal" error on AT+CPIN request,
+ * we can guess there a SIM card ...
+ */
+ data->have_sim = TRUE;
+}
+
+static void cfun_enable(gboolean ok, GAtResult *result, gpointer user_data)
+{
+ struct ofono_modem *modem = user_data;
+ struct simcom_data *data = ofono_modem_get_data(modem);
+
+ DBG("");
+
+ if (!ok) {
+ g_at_chat_unref(data->modem);
+ data->modem = NULL;
+
+ g_at_chat_unref(data->data);
+ data->data = NULL;
+
+ ofono_modem_set_powered(modem, FALSE);
+ return;
+ }
+
+ /* Get model and sim card status */
+ data->at_ignition_pending = 0;
+
+ g_at_chat_send(data->data, "AT+CPIN?", none_prefix,
+ simcom_sim_status, modem, NULL);
+ ++data->at_ignition_pending;
+
+ data->ignition_pool = g_timeout_add_seconds(1,
+ simcom_ignition,
+ modem);
+}
+
+static void cfun_disable(gboolean ok, GAtResult *result, gpointer user_data)
+{
+ struct ofono_modem *modem = user_data;
+ struct simcom_data *data = ofono_modem_get_data(modem);
+
+ DBG("");
+
+ g_at_chat_unref(data->data);
+ data->data = NULL;
+
+ if (ok)
+ ofono_modem_set_powered(modem, FALSE);
+}
+
+static GAtChat *open_device(struct ofono_modem *modem,
+ const char *key,
+ char *debug)
+{
+ const char *device;
+ GIOChannel *channel;
+ GAtSyntax *syntax;
+ GAtChat *chat;
+ /* GHashTable *options; */
+
+ device = ofono_modem_get_string(modem, key);
+ if (device == NULL)
+ {
+ ofono_error("Failed to get modem '%s'", key);
+ return NULL;
+ }
+
+ DBG("%s %s", key, device);
+
+ /* options = g_hash_table_new(g_str_hash, g_str_equal); */
+ /* if (options == NULL) */
+ /* return NULL; */
+
+ /* g_hash_table_insert(options, "Baud", "115200"); */
+ /* g_hash_table_insert(options, "Parity", "none"); */
+ /* g_hash_table_insert(options, "StopBits", "1"); */
+ /* g_hash_table_insert(options, "DataBits", "8"); */
+ /* g_hash_table_insert(options, "XonXoff", "off"); */
+ /* g_hash_table_insert(options, "RtsCts", "on"); */
+ /* g_hash_table_insert(options, "Local", "on"); */
+ /* g_hash_table_insert(options, "Read", "on"); */
+
+ channel = g_at_tty_open(device, NULL);
+
+ /* g_hash_table_destroy(options); */
+
+ if (channel == NULL)
+ {
+ ofono_error("Failed to get tty for '%s'", key);
+ return NULL;
+ }
+
+ syntax = g_at_syntax_new_gsm_permissive();
+ chat = g_at_chat_new(channel, syntax);
+ g_at_syntax_unref(syntax);
+
+ g_io_channel_unref(channel);
+
+ if (chat == NULL)
+ {
+ ofono_error("Failed to get chat for '%s'", key);
+ return NULL;
+ }
+
+ //if (getenv("OFONO_AT_DEBUG"))
+ g_at_chat_set_debug(chat, simcom_debug, debug);
+
+ return chat;
+}
+
+/* Modem interface function */
+static int simcom_probe(struct ofono_modem *modem)
+{
+ struct simcom_data *data;
+
+ DBG("%p", modem);
+
+ data = g_try_new0(struct simcom_data, 1);
+ if (data == NULL)
+ return -ENOMEM;
+
+ ofono_modem_set_data(modem, data);
+
+ return 0;
+}
+
+static void simcom_remove(struct ofono_modem *modem)
+{
+ struct simcom_data *data = ofono_modem_get_data(modem);
+
+ DBG("%p", modem);
+
+ if(data->ignition_pool > 0)
+ {
+ g_source_remove(data->ignition_pool);
+ data->ignition_pool = 0;
+ }
+
+ ofono_modem_set_data(modem, NULL);
+
+ /* Cleanup after hot-unplug */
+ g_at_chat_unref(data->data);
+
+ g_free(data);
+}
+
+static int simcom_enable(struct ofono_modem *modem)
+{
+ struct simcom_data *data = ofono_modem_get_data(modem);
+
+ DBG("%p", modem);
+
+ data->modem = open_device(modem, "Modem", "Modem: ");
+ if (data->modem == NULL)
+ return -EINVAL;
+
+ data->data = open_device(modem, "Data", "Data: ");
+ if (data->data == NULL) {
+ g_at_chat_unref(data->modem);
+ data->modem = NULL;
+ return -EIO;
+ }
+
+ g_at_chat_set_slave(data->modem, data->data);
+
+ g_at_chat_blacklist_terminator(data->data,
+ G_AT_CHAT_TERMINATOR_NO_CARRIER);
+
+ /* init modem */
+ g_at_chat_send(data->modem, "ATE0 +CMEE=1", NULL, NULL, NULL, NULL);
+ g_at_chat_send(data->data, "ATE0 +CMEE=1", NULL, NULL, NULL, NULL);
+
+ g_at_chat_send(data->data, "AT+CFUN=1", none_prefix,
+ cfun_enable, modem, NULL);
+
+ return -EINPROGRESS;
+}
+
+static int simcom_disable(struct ofono_modem *modem)
+{
+ struct simcom_data *data = ofono_modem_get_data(modem);
+
+ DBG("%p", modem);
+
+ g_at_chat_cancel_all(data->modem);
+ g_at_chat_unregister_all(data->modem);
+
+ g_at_chat_unref(data->modem);
+ data->modem = NULL;
+
+ g_at_chat_cancel_all(data->data);
+ g_at_chat_unregister_all(data->data);
+
+ g_at_chat_send(data->data, "AT+CFUN=4", none_prefix,
+ cfun_disable, modem, NULL);
+
+ return -EINPROGRESS;
+}
+
+static void simcom_pre_sim(struct ofono_modem *modem)
+{
+ struct simcom_data *data = ofono_modem_get_data(modem);
+ struct ofono_sim *sim;
+
+ DBG("%p", modem);
+
+ ofono_devinfo_create(modem, 0, "atmodem", data->data);
+ sim = ofono_sim_create(modem, OFONO_VENDOR_SIMCOM, "atmodem",
+ data->data);
+
+ if (sim)
+ ofono_sim_inserted_notify(sim, data->have_sim);
+}
+
+static void simcom_post_sim(struct ofono_modem *modem)
+{
+ struct simcom_data *data = ofono_modem_get_data(modem);
+ struct ofono_message_waiting *mw;
+ struct ofono_gprs *gprs;
+ struct ofono_gprs_context *gc;
+
+ DBG("%p", modem);
+
+ ofono_phonebook_create(modem, 0, "atmodem", data->data);
+
+ ofono_sms_create(modem, OFONO_VENDOR_SIMCOM, "atmodem",
+ data->data);
+
+ /* gprs things */
+ gprs = ofono_gprs_create(modem, 0, "atmodem", data->data);
+ gc = ofono_gprs_context_create(modem, 0, "atmodem", data->modem);
+
+ if(gprs && gc)
+ {
+ ofono_gprs_add_context(gprs, gc);
+ }
+}
+
+static void simcom_post_online(struct ofono_modem *modem)
+{
+ struct simcom_data *data = ofono_modem_get_data(modem);
+
+ DBG("%p", modem);
+
+ ofono_netreg_create(modem, OFONO_VENDOR_SIMCOM, "atmodem", data->data);
+ ofono_cbs_create(modem, 0, "atmodem", data->data);
+ ofono_ussd_create(modem, 0, "atmodem", data->data);
+}
+
+static struct ofono_modem_driver simcom_driver = {
+ .name = "simcom",
+ .probe = simcom_probe,
+ .remove = simcom_remove,
+ .enable = simcom_enable,
+ .disable = simcom_disable,
+ .pre_sim = simcom_pre_sim,
+ .post_sim = simcom_post_sim,
+ .post_online = simcom_post_online,
+};
+
+static int simcom_init(void)
+{
+ return ofono_modem_driver_register(&simcom_driver);
+}
+
+static void simcom_exit(void)
+{
+ ofono_modem_driver_unregister(&simcom_driver);
+}
+
+OFONO_PLUGIN_DEFINE(simcom, "SIMCOM modem driver", VERSION,
+ OFONO_PLUGIN_PRIORITY_DEFAULT,
+ simcom_init, simcom_exit)
3 months
CMGS <CTRL-Z> appears with terminate IO stream in Ofono
by Frederik Lotter
Hi Enrico,
> I had a similar problem and the reason was the hangout of the modem on the
> SMS sending.
>
> I solved with the following command on my plaugin:
>
> g_at_chat_send(data->chat, "AT&C0", NULL, NULL, NULL, NULL);
>
>Hope this helps.
>
>Enrico
I already have AT&C0 on both my AT chat and data channel. Maybe there is an
issue with this setup on my modem.
The root issue appears in the callback:
static gboolean received_data(GIOChannel *channel, GIOCondition cond, gpointer
data)
The g_io_channel_read_chars function gets an EOF status on read and returns
zero bytes. This happens after the CTRL-Z of the CMGS write (it appears).
What I am hoping someone can explain, is if this could be caused only by
the modem doing something on the line, or whether this could be cause by
the GLIB IO channel interpreting the CTRL-Z as a signal to close the
channel?
(I do not know which avenue to persue in debugging).
Right in the beginning of my modem init code I do:
g_at_chat_send(data->chat, "ATE0+CMEE=1", none_prefix,
NULL, NULL, NULL);
g_at_chat_send(data->chat, "AT&C0", none_prefix,
NULL, NULL, NULL);
g_at_chat_send(data->chat, "AT&D0", none_prefix,
NULL, NULL, NULL);
g_at_chat_send(data->modem, "AT&C0", none_prefix,
NULL, NULL, NULL);
g_at_chat_send(data->modem, "AT&D0", none_prefix,
NULL, NULL, NULL);
Thank for the quick reply and assistance so far.
Frederik Lotter
MiX Telematics South Africa
7 years, 7 months
CMGS <CTRL-Z> appears with terminate IO stream in Ofono
by Frederik Lotter
Hi Ofono experts,
I am using a UBLOX U200 modem and I wrote the driver for it some months
ago, and have since been using GPRS successfully.
I have now added the SMS feature and I am running into a problem:
It looks like once the SMS PDU byte block is sent (with CTRL-Z) the stream
disconnects.
Aux: > 0011000A8170033962660000A7044679990C<CtrlZ>
Any ideas? It looks like the g_io_channel_set_encoding() is called on both
my tty channels to RAW mode, so I am not sure why the CTRL-Z (I guess) is
causing this.
Instrumented output below:
------------------------------------
ofonod[1502]:
/home/flotter/mix6000-angstrom/build/tmp-angstrom_v2014_06-eglibc/work/armv7at2hf-vfp-angstrom-linux-gnueabi/ofono/1.14-r0/ofono-1.14/drivers/atmodem/sms.c:at_cmgl_done()
ofonod[1502]: Aux: > AT+CGSMS=3\r
FRED[Write watcher destroyed...]
ofonod[1502]: Aux: < \r\nOK\r\n
FRED>>[
OK
] - 6 - 6 <<
ofonod[1502]: Aux: > AT+CMGS=17\r
FRED[Write watcher destroyed...]
ofonod[1502]: RegisterProfile() replied an error:
org.freedesktop.DBus.Error.UnknownMethod, Method "RegisterProfile" with
signature "osa{sv}" on interface "org.bluez.ProfileManager1" doesn't exist
ofonod[1502]: Aux: < \r\n>
FRED>>[
> ] - 4 - 4 <<
ofonod[1502]: Aux: > 0011000A8170033962660000A7044679990C<CtrlZ>
FRED[Write watcher destroyed...]
FRED[Read watcher destroyed...]
FRED[IO Disconnect]
7 years, 7 months
Why doesn't ofono match all +CGEV notification ? How can I implement a GPRS watchdog ?
by Viallard Anthony
Hello,
I'm looking for an issue with GPRS. I have the SIMCOM5216E module with
ofono 1.12. The problem was see in France with SFR provider. I didn't
reproduce this with another provider and in another country... But maybe
it's a question of uptime...
During a good period of time, my device is well connected through the
GPRS connection. All work perfectly. In recent log, I can see the GPRS
is reactivated several time along the weeks but the PPP is back online
soon after.
But, few days ago, I saw the GPRS connection was unusable for 10 days. I
saw the problem began the 12th February. According to different logs,
the network connectivity have began to fail since the 2th February.
Unfortunately, I couldn't get logs from ofono during the period of time
(it's an embedded device, so the size of the log file is only 64k bytes.
But it will be a good idea for the future to increment it ...). However,
the device had others logs. I could see the log from our program that
deals with ofono (it sends dbus commands and listen for dbus signals)
and I saw there is a blank period from the 2th to the 12th. It's like
ofono or the module was dead.
So, I begin to read the code, especially the simcom driver, to see if I
miss something. And I see something weird.
According to the SIMCOM AT document, the +CGEV notification can be send
with this list of event:
REJECT
NW REACT
NW DEACT
ME DEACT
NW DETACH
ME DETACH
NW CLASS
ME CLASS
But in gprs-context.c, I see we deal only with the "NW DETACH" event.
Maybe It's the point. Maybe the modem send to ofono an another event and
therefore ofono begins to be in incorrect state about the GPRS
connection... Is it possible ?
Otherwise, I'm thinking about implement a GPRS watchdog. Does it exist
an AT command which could do that ? My idea is to send an AT command
each XX period of time and check the GPRS connection is really here.
Regards,
Anthony Viallard.
--
-----------------------------------------
Viallard Anthony (+41 024 455 24 82)
[ Embedded System | Software Designer ]
-----------------------------------------
Syscom Instruments SA
Rue de l'industrie 21
1450 Sainte-Croix
-----------------------------------------
7 years, 7 months
Re: Re: [PATCH 0/2] Add ResetProperties method to ConnectionContext interface
by Tommi Kenakkala
> Date: Fri, 20 Feb 2015 10:00:31 -0600
> From: Denis Kenzior <denkenz(a)gmail.com>
> To: ofono(a)ofono.org
> Subject: Re: [PATCH 0/2] Add ResetProperties method to
> ConnectionContext interface
> Message-ID: <54E75A1F.8070709(a)gmail.com>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> Hi Tommi,
>
> On 02/19/2015 05:59 AM, Tommi Kenakkala wrote:
>> In some cases it is useful to reset connection context settings back to ones
>> ofono provisioning resolved initially.
>> What's your opinion on the API design, implementation and use-case described
>> next?
>>
> Why don't you just remove the settings file and restart oFono?
oFono handles many other services so restarting would have undesirable effects.
For a moment clients would think there is no telephony at all: no SIM,
no cellular signal strength, no voice/emergency calls, no SIM ATK etc.
>> Deactivation of the context is obviously mandatory. The reasoning for placing
>> this into ofono is handling client requests consistently and avoiding race
>> conditions. Using this approach ofono does not re-activate the context, that's
>> done by ConnMan or whatever connection manger the system uses.
>>
> I'm not so sure that this is a good idea. A 'live' reset of the
> settings just seems wrong to me. Why would you ever want to do that
> anyway? If something is working, why bother resetting the settings?
Generally speaking I agree with the point of view. The main point was
not the 'live' part, but to allow running provisioning again, e.g. if
user has set wrong ones.
FYI a MMS context may be active using a correct APN but messages don't
flow due to a wrong proxy. In such a case context remains active for
some time.
> oFono supports arbitrary number of contexts, so your UI can always add
> more. So if you need to re-provision, let your UI handle this. The UI
> should be capable of reading the provisioning database anyway in order
> to handle duplicates, etc.
When ofono already implements the initial provisioning logic it is not
tempting to duplicate it but instead trigger it again.
(A more suitable name for the new method could be "ProvisiongContext"
or similar.)
If reverting provisioned settings is done by creating a new empty
context, one would still want to run ofono provisioning for that
(ofono restart not an option).
>
> Regards,
> -Denis
Thanks for your feedback Denis, I appreciate it. All tips to make
changes more upstream-worthy, or if not then otherwise better, are
welcome.
Thanks
--
Tommi
7 years, 7 months
[PATCH 0/2] Add ResetProperties method to ConnectionContext interface
by Tommi Kenakkala
In some cases it is useful to reset connection context settings back to ones
ofono provisioning resolved initially.
What's your opinion on the API design, implementation and use-case described
next?
Deactivation of the context is obviously mandatory. The reasoning for placing
this into ofono is handling client requests consistently and avoiding race
conditions. Using this approach ofono does not re-activate the context, that's
done by ConnMan or whatever connection manger the system uses.
Ps. Patches on behalf of Slava whose emails didn't get through to the mailing
list.
Slava Monich (2):
gprs: Add ResetProperties method to ConnectionContext interface
doc: Document ResetProperties method
doc/connman-api.txt | 9 ++
src/gprs.c | 292 +++++++++++++++++++++++++++++++++++++++++++++++++--
2 files changed, 295 insertions(+), 6 deletions(-)
--
1.7.9.5
7 years, 7 months
Re: Which desktop linux distribution uses ofono natively?
by Sanjay Mehta
> From: Christian Gagneraud
> I use to use Ubuntu 13.04 and 13.10 with custom built ofono.
> The problem when you experiment with ofono on your dev machine is that
> you will loose your internet connection in case ofono goes nuts. So I
I’ve brought up ofono and econnman on Ubuntu 14.04.01 LTS
using the packages available via apt-get on a generic Intel laptop.
Haven’t tested Bluetooth, but it’s working with wifi and wired ethernet. I’m now
trying to figure out how to add “cellular” to the technologies supported by ofono.
After upgrading the linux kernel to 3.19, I can see wwan0 showing up
in /sys/class/net so the device (a Huawei E3272 LTE dongle) is being
detected by the kernel properly (and it works if I use sakis3g).
I think there was a Huawei specific bug in the shipped version of the
kernel that blocked me earlier.
Short of reading the ofono code - which I can do later this week - any pointers
on connecting cellular with ofono?
> would say it's better to run ofono experiment on the embedded board.
> Set up your dev computer with the cross toolchain, and mount (part of)
> the board rootfs on your dev computer and build (or install) ofono there.
My target board isn’t ready yet. I could try an experiment with an old
Raspberry Pi B.
thanks!
Sanjay
7 years, 7 months
+CUSD charset
by Enrico Sau
Hi all,
I'm trying to use supplementary services and I have a problem in decoding
the response string.
The received charset is AT_UTIL_CHARSET_IRA, which is not evaluated in the
switch case statement.
I noticed that it seems to decode correctly the string if I apply the same
function as for AT_UTIL_CHARSET_GSM.
The question is: am I doing it wrong?
I cannot understand the difference between GSM and IRA charsets.
Thank you.
Enrico
7 years, 7 months
