[PATCH_v4 0/5] Private network request to ConnMan
by Guillaume Zajac
Hi,
Changelog from v3 is:
- Add private-network source/include
- ConnMan plugin is independant from emulator
- Each application that need VPN will pass a callback as argument
when private network is requested. This callback will contain the
private network settings.
Guillaume Zajac (5):
gatppp: Add new contructor to use external fd
private-network: add callback typedef drivers and settings
private-network: add request/release functions and new feature to
Makefile.am
emulator: add request/release private network calls
connman: add plugin in oFono to request request/release private
network
Makefile.am | 10 +-
gatchat/gatppp.c | 33 +++++-
gatchat/gatppp.h | 1 +
gatchat/ppp.h | 2 +-
gatchat/ppp_net.c | 40 ++++---
include/private-network.h | 59 +++++++++
plugins/connman.c | 297 +++++++++++++++++++++++++++++++++++++++++++++
src/emulator.c | 49 ++++++--
src/ofono.h | 6 +
src/private-network.c | 89 ++++++++++++++
10 files changed, 556 insertions(+), 30 deletions(-)
create mode 100644 include/private-network.h
create mode 100644 plugins/connman.c
create mode 100644 src/private-network.c
1 month, 1 week
Re: HSP/HFP ofono bluetooth support for Linux desktop
by Denis Kenzior
Hi Pali,
On 1/8/20 3:25 PM, Pali Rohár wrote:
> Hello!
>
Somehow this went straight to my Junk folder, so I didn't see this
message at all until now.
>
> Audio application (e.g. pulseaudio) really do not want to handle two
> separate services to monitor and process HSP/HFP devices. >
> For audio application are HSP and HFP devices equivalent, they provide
> same features: SCO socket, API for controlling microphone and speaker
> gain; plus optionally specify used codec.
>
> So having two separate services which fully divided for audio
> application purpose does not make sense.
>
> So it is possible that both HSP and HFP audio cards would be available
> via one audio API? Because I do not see how it could be done via design
> like dundee.
>
One API sure. Maybe on multiple services. Honestly, I don't see why
this would be such a burden for PA to watch 2 dbus services instead of
1. From oFono perspective it would make more sense to keep the HSP part
a separate daemon. I could be convinced otherwise if it is indeed a big
burden for PA...
>> You can then implement the same API interfaces for setting up the HSP audio
>> stream as oFono does today (i.e. https://git.kernel.org/pub/scm/network/ofono/ofono.git/tree/doc/handsfree...),
>
> This API is unusable for both HSP and HFP audio streams. In pulseaudio
> it is somehow used, but it is not suitable.
>
Funny. "It is used but not suitable"?
> Main objection for handsfree-audio-api.txt is that it does not provide
> information about locally used codec and somehow mixes air codec and
> local codec. In my hsphfpd.txt I used term "AgentCodec" for bluetooth
> local codec and term "AirCodec" for bluetooth air codec format.
Okay. But, just FYI, at the time there was no hw that could do such
on-the-fly conversions, so this use case wasn't considered/implemented.
There's really no reason why we couldn't extend our APIs to handle this.
>
> Another objection against handsfree-audio-api.txt API is that it is
> bound to HF codecs (via number) and does not support for pass e.g. CSR
> codecs.
True. In retrospect we probably should have used strings. But it was
assumed that vendor extensions would go via the Bluetooth SIG Assigned
Numbers facility. Anyhow, we can always add a 'Register2' method that
could take codecs as a string array or a combination of strings & ints.
And if Register2 was used, then use 'NewConnection2' with a signature
that supports passing in vendor codecs and whatever else that might be
needed.
>
> What is completely missing in that API is controlling volume level.
>
It is there on the CallVolume interface
> And also API does not provide socket MTU information or ability to
> change/specify which codec would be used.
There was no need, we automatically defaulted to using Wide band if
available. Third party codecs are a new use case (for oFono HFP), so
would require an API extension.
>
> Non-audio APIs which are needed to export (for both HSP and HFP profiles):
>
> * battery level (0% - 100%)
> * power source (external, battery, unknown)
> * ability to send "our laptop" battery level and power source to remote device
> * send text message to embedded display
> * process button press event (exported via linux kernel uinput)
>
I think all of these are feasible to support under the current oFono
structure, either via plugins or API extensions.
Regards,
-Denis
2 months, 1 week
Re: [PATCH] udevng: Add support for Quectel BG96 modem
by Martin Hundebøll
Hi Sean,
On 11/25/19 9:26 AM, Sean Nyekjaer wrote:
> Signed-off-by: Sean Nyekjaer <sean(a)geanix.com>
No signoff when submitting to ofono.
// Martin
> ---
> plugins/udevng.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/plugins/udevng.c b/plugins/udevng.c
> index 40ed2b02..cc294c94 100644
> --- a/plugins/udevng.c
> +++ b/plugins/udevng.c
> @@ -1790,6 +1790,8 @@ static struct {
> { "quectelqmi", "qcserial", "2c7c", "0121" },
> { "quectelqmi", "qmi_wwan", "2c7c", "0125" },
> { "quectelqmi", "qcserial", "2c7c", "0125" },
> + { "quectelqmi", "qmi_wwan", "2c7c", "0296" },
> + { "quectelqmi", "qcserial", "2c7c", "0296" },
> { "ublox", "cdc_acm", "1546", "1010" },
> { "ublox", "cdc_ncm", "1546", "1010" },
> { "ublox", "cdc_acm", "1546", "1102" },
>
1 year, 6 months
APN for a newly added service provider
by Marek Szuba
Hello,
I have noticed something interesting lately in how oFono (or to be
precise oFono+Connman, as that is what I have on my system) has handled
a newly added service provider and I wonder if this is intentional or I
have done something wrong.
Context: I have attempted to connect to the Internet using a broadband
modem using a SIM card from a provider not listed in my
serviceproviders.xml file. The provider in question is an MVNO on the
German T-Mobile network, with all the settings (other than the SPN, of
course) identical to those of another pre-paid MVNO that already has an
entry in the aforementioned file (Congstar), which has only got a single
APN defined.
My steps: I have cloned the Congstar <provider> section in
serviceproviders.xml with an appropriate SPN, then disconnected the
modem and restarted ofonod just in case.
Expected: Connman establishes a cellular connection right away
Actually happened: although ofonod debug messages showed that it had
correctly read the new SPN entry and set up an Internet context, said
context did not have an APN set and connman failed to use it to
establish a connection - until I used the "create-internet-context" test
script to set the APN. Now regardless of how often I disconnect the
modem, restart ofonod and so on, the context's APN does get set
automatically and the mobile-broadband connection works fine.
I am curious regarding what might have happened here so that I
understand why it has happened and possibly prevent from having to mess
around with test scripts in the future. Thank you in advance for your
comments!
--
MS
1 year, 10 months
APN for a newly added service provider
by Marek Szuba
Hello,
I have noticed something interesting lately in how oFono (or to be
precise oFono+Connman, as that is what I have on my system) has handled
a newly added service provider and I wonder if this is intentional or I
have done something wrong.
Context: I have attempted to connect to the Internet using a broadband
modem using a SIM card from a provider not listed in my
serviceproviders.xml file. The provider in question is an MVNO on the
German T-Mobile network, with all the settings (other than the SPN, of
course) identical to those of another pre-paid MVNO that already has an
entry in the aforementioned file (Congstar), which has only got a single
APN defined.
My steps: I have cloned the Congstar <provider> section in
serviceproviders.xml with an appropriate SPN, then disconnected the
modem and restarted ofonod just in case.
Expected: Connman establishes a cellular connection right away
Actually happened: although ofonod debug messages showed that it had
correctly read the new SPN entry and set up an Internet context, said
context did not have an APN set and connman failed to use it to
establish a connection - until I used the "create-internet-context" test
script to set the APN. Now regardless of how often I disconnect the
modem, restart ofonod and so on, the context's APN does get set
automatically and the mobile-broadband connection works fine.
I am curious regarding what might have happened here so that I
understand why it has happened and possibly prevent from having to mess
around with test scripts in the future. Thank you in advance for your
comments!
--
MS
--
MS
1 year, 10 months
Using a Huawei modem in NCM mode
by Marek Szuba
Hello,
A possibly stupid question: is there any way of having my broadband
modem, a Huawei E3372 (12d1:155e), connect in NCM mode rather than
PPP-via-Modem mode? At first I thought this mode was not supported for
Huawei in spite of it exposing a CDC_NCM interface to the system which
the kernel has used to create a WWAN network interface. Then however I
noticed ofonod logs report the modem as capable of both Modem and NDIS
modes, and posts and patches I have found on OpenWRT mailing lists
(comments elsewhere invariably said one had to flash stick-mode firmware
to make it work, which however I am confident is not needed in my case
because I can get the stick out if Hilink and into Modem/NDIS mode
simply by setting the right option in usb_modeswitch configuration)
suggest switching to NDIS mode might be a simple matter of sending an
appropriate AT^NDISDUP command. Unfortunately, I haven't found anything
on how to achieve this in oFono.
Just to make it clear, the ttyUSB0+ppp mode of this modem works
perfectly with oFono.
Again, thank you in advance for your answers.
--
MS
1 year, 10 months
[PATCH] plugin: provision: create multiple contexts for multiple entries in mbpi
by Nicola Lunghi
if the mobile provider information database has multiple apn settings for the
same operator, ofono was throwing an error and creating a default internet
context with an empty apn.
This patch will instead allow the automatic creation of multiple context
allowing the user to pick one of the default via connman.
Connman supports multiple cellular context so no issue there.
Previously proposed by Martin Hundebøll here:
https://lists.ofono.org/hyperkitty/list/ofono@ofono.org/thread/2SC46PH5CW...
And tested by Nicola Lunghi with connman 1.37
Signed-off-by: Nicola Lunghi <nick83ola(a)gmail.com>
---
plugins/provision.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/provision.c b/plugins/provision.c
index 99c299eb..aa0b05e4 100644
--- a/plugins/provision.c
+++ b/plugins/provision.c
@@ -50,7 +50,7 @@ static int provision_get_settings(const char *mcc, const char *mnc,
DBG("Provisioning for MCC %s, MNC %s, SPN '%s'", mcc, mnc, spn);
- apns = mbpi_lookup_apn(mcc, mnc, FALSE, &error);
+ apns = mbpi_lookup_apn(mcc, mnc, TRUE, &error);
if (apns == NULL) {
if (error != NULL) {
ofono_error("%s", error->message);
--
2.20.1
1 year, 10 months
How to handle modems with additional wwan connect stage?
by mattias.mansson＠verisure.com
We are writing a ofono driver/plugin for a new Quectel modem based on a qualcomm chipset. This modem has a wwan interface that needs to be "connected" after the context is activated, partially to allow the host to run dhcp. It can be done either using QMI or with a special qualcomm command AT$QCRMCALL. We want to control it using AT, as we have found several issues with QMI. But we are having some trouble figuring out where this command should be called in the ofono state machine, at least in the LTE case where the context is automatically activated. If we activate the context manually, we could just add that call in the end of the context activation. But if we for the automatic case add this command when we receive PDN ACT 1 and the AT command fails (which right now happens sometimes), we end up in a state where we can't try again, because the context is already activated. So we can't really find the best way to do this...
Another issue I wanted to ask is that when we get an automatic context activation on 4G, we don't get the APN set from the network in the AT+CGDCONT? response. According to Quectel, this is just how their modem work. It will only show manually set APN from that response. Is this normal for any other modules? And how to solve the problem that ofono wants the APN when calling ofono_gprs_cid_activated when we get the CGEV saying the PDN is active?
1 year, 10 months
[PATCH] build: require dbus >= 1.6
by joey＠joeyhewitt.com
dbus_validate_path() is used several times. dbus's NEWS says it was
added in 1.5.12.
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index b17bfb5e..3655a112 100644
--- a/configure.ac
+++ b/configure.ac
@@ -67,8 +67,8 @@ PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes,
AC_SUBST(GLIB_CFLAGS)
AC_SUBST(GLIB_LIBS)
-PKG_CHECK_MODULES(DBUS, dbus-1 >= 1.4, dummy=yes,
- AC_MSG_ERROR(D-Bus >= 1.4 is required))
+PKG_CHECK_MODULES(DBUS, dbus-1 >= 1.6, dummy=yes,
+ AC_MSG_ERROR(D-Bus >= 1.6 is required))
AC_SUBST(DBUS_CFLAGS)
AC_SUBST(DBUS_LIBS)
--
2.17.1
1 year, 10 months
Expose MBPI api over d-bus
by nick83ola
Dear Ofono developers,
I need to expose the mbpi information over d-bus and possibly
automatically create profiles based on the information provided in the
mobile provider information database.
Do you think the right way could be:
- add a d-bus interface to the mbpi.c plugin
- or extend the allowed apn plugin to query the mobile provider database?
- or something else?
Thanks
Nicola Lunghi
1 year, 10 months
