[PATCH] huawei: fix AT^SYSCFGEX acqorder "0201"
by Jimmy Gysens
Commit 6c574ee24a57d0397e4e3c617016bf026405960a ("huawei: the AT^SYSCFGEX
command supports additional modes") has a mistake for acqorder "0201". It
should be UMTS and GSM preferred.
---
drivers/huaweimodem/radio-settings.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/huaweimodem/radio-settings.c b/drivers/huaweimodem/radio-settings.c
index ff7be48a..c8ebcba0 100644
--- a/drivers/huaweimodem/radio-settings.c
+++ b/drivers/huaweimodem/radio-settings.c
@@ -210,7 +210,7 @@ static void syscfgex_query_mode_cb(gboolean ok, GAtResult *result,
else if (strstr(acqorder, "0302"))
mode = (OFONO_RADIO_ACCESS_MODE_LTE | OFONO_RADIO_ACCESS_MODE_UMTS);
else if (strstr(acqorder, "0201"))
- mode = (OFONO_RADIO_ACCESS_MODE_UMTS | OFONO_RADIO_ACCESS_MODE_LTE);
+ mode = (OFONO_RADIO_ACCESS_MODE_UMTS | OFONO_RADIO_ACCESS_MODE_GSM);
else if (strstr(acqorder, "03"))
mode = OFONO_RADIO_ACCESS_MODE_LTE;
else if (strstr(acqorder, "02"))
@@ -330,7 +330,7 @@ static void syscfgex_set_rat_mode(struct radio_settings_data *rsd,
if (mode == (OFONO_RADIO_ACCESS_MODE_LTE | OFONO_RADIO_ACCESS_MODE_UMTS))
acqorder = "0302";
- else if (mode == (OFONO_RADIO_ACCESS_MODE_UMTS | OFONO_RADIO_ACCESS_MODE_LTE))
+ else if (mode == (OFONO_RADIO_ACCESS_MODE_UMTS | OFONO_RADIO_ACCESS_MODE_GSM))
acqorder = "0201";
snprintf(buf, sizeof(buf), atcmd, acqorder);
--
2.17.1
2 years, 1 month
[PATCH] gprs: clean context properly
by Jimmy Gysens
After a context is detached, the context is not properly cleared. In
addition to releasing the context:
- Reset the context settings (IP, DNS, interface, ...).
- Signal the Active flag as false.
---
src/gprs.c | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/src/gprs.c b/src/gprs.c
index d9e24840..00cfb905 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -1573,6 +1573,19 @@ static bool have_read_settings(struct ofono_gprs *gprs)
return false;
}
+static void pri_context_signal_active(struct pri_context *ctx)
+{
+ DBusConnection *conn;
+ dbus_bool_t value;
+
+ value = ctx->active;
+ conn = ofono_dbus_get_connection();
+
+ ofono_dbus_signal_property_changed(conn, ctx->path,
+ OFONO_CONNECTION_CONTEXT_INTERFACE,
+ "Active", DBUS_TYPE_BOOLEAN, &value);
+}
+
static void detach_active_contexts(struct ofono_gprs *gprs)
{
GSList *l;
@@ -1596,7 +1609,9 @@ static void detach_active_contexts(struct ofono_gprs *gprs)
gc->driver->detach_shutdown(gc, ctx->context.cid);
/* Make sure the context is properly cleared */
+ pri_reset_context_settings(ctx);
release_context(ctx);
+ pri_context_signal_active(ctx);
}
}
@@ -2251,8 +2266,6 @@ static void gprs_deactivate_for_all(const struct ofono_error *error,
{
struct pri_context *ctx = data;
struct ofono_gprs *gprs = ctx->gprs;
- DBusConnection *conn;
- dbus_bool_t value;
if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
__ofono_dbus_pending_reply(&gprs->pending,
@@ -2262,12 +2275,7 @@ static void gprs_deactivate_for_all(const struct ofono_error *error,
pri_reset_context_settings(ctx);
release_context(ctx);
-
- value = ctx->active;
- conn = ofono_dbus_get_connection();
- ofono_dbus_signal_property_changed(conn, ctx->path,
- OFONO_CONNECTION_CONTEXT_INTERFACE,
- "Active", DBUS_TYPE_BOOLEAN, &value);
+ pri_context_signal_active(ctx);
gprs_deactivate_next(gprs);
}
--
2.17.1
2 years, 1 month
[PATCH 1/2] modem: add a driver reset function
by Jimmy Gysens
Add a reset function to the modem driver. This function can be used to hard
reset the device. This is an alternative in case the (*enable) and
(*disable) functions are not supported.
A reset will not work when emergency mode is active.
For dbus: dbus-send \
--system \
--print-reply \
--dest=org.ofono \
<modem_path> \
org.ofono.Modem.Reset
---
include/modem.h | 3 +++
src/modem.c | 20 ++++++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/include/modem.h b/include/modem.h
index 9b12cfad..519ffe97 100644
--- a/include/modem.h
+++ b/include/modem.h
@@ -75,6 +75,9 @@ struct ofono_modem_driver {
/* Populate the atoms available online */
void (*post_online)(struct ofono_modem *modem);
+
+ /* Reset device */
+ int (*reset)(struct ofono_modem *modem);
};
void ofono_modem_add_interface(struct ofono_modem *modem,
diff --git a/src/modem.c b/src/modem.c
index 52988cf3..8c633edb 100644
--- a/src/modem.c
+++ b/src/modem.c
@@ -1082,6 +1082,24 @@ done:
return NULL;
}
+static DBusMessage *modem_reset(DBusConnection *conn,
+ DBusMessage *msg, void *data)
+{
+ struct ofono_modem *modem = data;
+ const struct ofono_modem_driver *driver = modem->driver;
+
+ if (ofono_modem_get_emergency_mode(modem) == TRUE)
+ return __ofono_error_emergency_active(msg);
+
+ if (!driver->reset)
+ return __ofono_error_not_implemented(msg);
+
+ if (driver->reset(modem))
+ return __ofono_error_failed(msg);
+
+ return dbus_message_new_method_return(msg);
+}
+
static DBusMessage *modem_set_property(DBusConnection *conn,
DBusMessage *msg, void *data)
{
@@ -1179,6 +1197,8 @@ static const GDBusMethodTable modem_methods[] = {
{ GDBUS_ASYNC_METHOD("SetProperty",
GDBUS_ARGS({ "property", "s" }, { "value", "v" }),
NULL, modem_set_property) },
+ { GDBUS_METHOD("Reset",
+ NULL, NULL, modem_reset) },
{ }
};
--
2.17.1
2 years, 1 month
[PATCH 1/2] huawei: add RejectInfo signal to org.ofono.ConnectionManager
by Jimmy Gysens
Huawei devices can have support for ^REJINFO unsolicited event. This event
provides useful info, regarding to the network attached state, for higher
level applications.
This commit adds an additional property RejectInfo to the PropertyChanged
signal for org.ofono.ConnectionManager.
---
include/gprs.h | 3 ++
src/gprs.c | 126 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 129 insertions(+)
diff --git a/include/gprs.h b/include/gprs.h
index 20bdb7a4..92c0d260 100644
--- a/include/gprs.h
+++ b/include/gprs.h
@@ -62,6 +62,9 @@ void ofono_gprs_detached_notify(struct ofono_gprs *gprs);
void ofono_gprs_suspend_notify(struct ofono_gprs *gprs, int cause);
void ofono_gprs_resume_notify(struct ofono_gprs *gprs);
void ofono_gprs_bearer_notify(struct ofono_gprs *gprs, int bearer);
+void ofono_gprs_rejectinfo_notify(struct ofono_gprs *gprs, int plmn,
+ int service_domain, int rat_type,
+ int reject_cause, int reject_type);
struct ofono_modem *ofono_gprs_get_modem(struct ofono_gprs *gprs);
diff --git a/src/gprs.c b/src/gprs.c
index daf2611b..d9e24840 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -136,6 +136,14 @@ struct pri_context {
struct ofono_gprs *gprs;
};
+struct rejectinfo {
+ int plmn;
+ int service_domain;
+ int rat_type;
+ int reject_cause;
+ int reject_type;
+};
+
static void gprs_attached_update(struct ofono_gprs *gprs);
static void gprs_netreg_update(struct ofono_gprs *gprs);
static void gprs_deactivate_next(struct ofono_gprs *gprs);
@@ -2734,6 +2742,124 @@ void ofono_gprs_bearer_notify(struct ofono_gprs *gprs, int bearer)
"Bearer", DBUS_TYPE_STRING, &value);
}
+static void append_rejectinfo_properties(const struct rejectinfo *ri,
+ DBusMessageIter *iter)
+{
+ DBusMessageIter variant;
+ DBusMessageIter array;
+ char typesig[5];
+ char arraysig[6];
+ const char *rat;
+ const char *service;
+ const char *reason;
+
+ switch (ri->rat_type) {
+ //GERAN
+ case 0:
+ rat = "gprs";
+ break;
+ //UTRAN
+ case 1:
+ rat = "umts";
+ break;
+ //E-UTRAN
+ case 2:
+ rat = "lte";
+ break;
+ default:
+ rat = "unknown";
+ }
+
+ switch (ri->service_domain) {
+ case 0:
+ service = "cs";
+ break;
+ case 1:
+ service = "ps";
+ break;
+ case 2:
+ service = "cs_ps";
+ break;
+ default:
+ service = "unknown";
+ }
+
+ switch (ri->reject_type) {
+ case 0:
+ reason = "register reject";
+ break;
+ case 1:
+ reason = "authentication failure";
+ break;
+ case 2:
+ reason = "service request reject";
+ break;
+ case 3:
+ reason = "detach request from the network";
+ break;
+ default:
+ reason = "unknown";
+ }
+
+ arraysig[0] = DBUS_TYPE_ARRAY;
+ arraysig[1] = typesig[0] = DBUS_DICT_ENTRY_BEGIN_CHAR;
+ arraysig[2] = typesig[1] = DBUS_TYPE_STRING;
+ arraysig[3] = typesig[2] = DBUS_TYPE_VARIANT;
+ arraysig[4] = typesig[3] = DBUS_DICT_ENTRY_END_CHAR;
+ arraysig[5] = typesig[4] = '\0';
+
+ dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT,
+ arraysig, &variant);
+
+ dbus_message_iter_open_container(&variant, DBUS_TYPE_ARRAY,
+ typesig, &array);
+
+ ofono_dbus_dict_append(&array, "PLMN", DBUS_TYPE_INT32, &ri->plmn);
+ ofono_dbus_dict_append(&array, "Service", DBUS_TYPE_STRING, &service);
+ ofono_dbus_dict_append(&array, "Technology", DBUS_TYPE_STRING, &rat);
+ ofono_dbus_dict_append(&array, "Cause", DBUS_TYPE_INT32,
+ &ri->reject_cause);
+ ofono_dbus_dict_append(&array, "Type", DBUS_TYPE_INT32,
+ &ri->reject_type);
+ ofono_dbus_dict_append(&array, "Reason", DBUS_TYPE_STRING, &reason);
+
+ dbus_message_iter_close_container(&variant, &array);
+ dbus_message_iter_close_container(iter, &variant);
+}
+
+void ofono_gprs_rejectinfo_notify(struct ofono_gprs *gprs, int plmn,
+ int service_domain, int rat_type,
+ int reject_cause, int reject_type)
+{
+ DBusConnection *conn;
+ DBusMessage *signal;
+ DBusMessageIter iter;
+ const char *name = "RejectInfo";
+ const char *path;
+ const struct rejectinfo ri = { plmn, service_domain, rat_type,
+ reject_cause, reject_type };
+
+ if (!gprs)
+ return;
+
+ path = __ofono_atom_get_path(gprs->atom);
+ signal = dbus_message_new_signal(path,
+ OFONO_CONNECTION_MANAGER_INTERFACE,
+ "PropertyChanged");
+
+ if (!signal)
+ return;
+
+ conn = ofono_dbus_get_connection();
+
+ dbus_message_iter_init_append(signal, &iter);
+ dbus_message_iter_append_basic(&iter, DBUS_TYPE_STRING, &name);
+
+ append_rejectinfo_properties(&ri, &iter);
+
+ g_dbus_send_message(conn, signal);
+}
+
void ofono_gprs_context_deactivated(struct ofono_gprs_context *gc,
unsigned int cid)
{
--
2.17.1
2 years, 1 month
[PATCH] huawei: send restore settings command on startup
by Jimmy Gysens
When initializing a Huawei device, send the AT&F0 command to restore the
default AT settings on device restart.
Huawei stores all APN settings, which can cause issues when changing the
APN. The AT&F0 command makes sure the device starts from a clean state.
---
plugins/huawei.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index 35195e2d..681e643f 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
@@ -419,6 +419,10 @@ static void sysinfo_enable_cb(gboolean ok, GAtResult *result,
g_at_chat_send(data->modem, "AT&C0", NULL, NULL, NULL, NULL);
g_at_chat_send(data->pcui, "AT&C0", NULL, NULL, NULL, NULL);
+ /* Restore settings after restart */
+ g_at_chat_send(data->modem, "AT&F0", NULL, NULL, NULL, NULL);
+ g_at_chat_send(data->pcui, "AT&F0", NULL, NULL, NULL, NULL);
+
/*
* Ensure that the modem is using GSM character set and not IRA,
* otherwise weirdness with umlauts and other non-ASCII characters
--
2.17.1
2 years, 1 month
[PATCH] huawei: the AT^SYSCFGEX command supports additional modes
by Jimmy Gysens
- LTE and UMTS preferred (acqorder = 0302);
AT^SYSCFGEX="0302",40000000,2,4,40000000
- UMTS and GSM preferred (acqorder = 0201);
AT^SYSCFGEX="0201",40000000,2,4,40000000
For AT^SYSCFG, the modes are not available.
---
drivers/huaweimodem/radio-settings.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/huaweimodem/radio-settings.c b/drivers/huaweimodem/radio-settings.c
index 20181d2b..ff7be48a 100644
--- a/drivers/huaweimodem/radio-settings.c
+++ b/drivers/huaweimodem/radio-settings.c
@@ -207,6 +207,10 @@ static void syscfgex_query_mode_cb(gboolean ok, GAtResult *result,
strstr(acqorder, "02") &&
strstr(acqorder, "03")))
mode = OFONO_RADIO_ACCESS_MODE_ANY;
+ else if (strstr(acqorder, "0302"))
+ mode = (OFONO_RADIO_ACCESS_MODE_LTE | OFONO_RADIO_ACCESS_MODE_UMTS);
+ else if (strstr(acqorder, "0201"))
+ mode = (OFONO_RADIO_ACCESS_MODE_UMTS | OFONO_RADIO_ACCESS_MODE_LTE);
else if (strstr(acqorder, "03"))
mode = OFONO_RADIO_ACCESS_MODE_LTE;
else if (strstr(acqorder, "02"))
@@ -281,6 +285,8 @@ static void syscfg_set_rat_mode(struct radio_settings_data *rsd,
break;
case OFONO_RADIO_ACCESS_MODE_LTE:
goto error;
+ default:
+ goto error;
}
snprintf(buf, sizeof(buf), "AT^SYSCFG=%u,%u,40000000,2,4",
@@ -318,8 +324,15 @@ static void syscfgex_set_rat_mode(struct radio_settings_data *rsd,
case OFONO_RADIO_ACCESS_MODE_LTE:
acqorder = "03";
break;
+ default:
+ break;
}
+ if (mode == (OFONO_RADIO_ACCESS_MODE_LTE | OFONO_RADIO_ACCESS_MODE_UMTS))
+ acqorder = "0302";
+ else if (mode == (OFONO_RADIO_ACCESS_MODE_UMTS | OFONO_RADIO_ACCESS_MODE_LTE))
+ acqorder = "0201";
+
snprintf(buf, sizeof(buf), atcmd, acqorder);
if (g_at_chat_send(rsd->chat, buf, none_prefix,
--
2.17.1
2 years, 1 month
[PATCH] atmodem: set PDP/EPS minimum context ID to 1.
by Jimmy Gysens
There are manufacturers, like Huawei, returning profile 0 as the minimum
PDP/EPS context ID. Profile 0, however, is the default profile used to
register to the LTE network. It contains manufacturer specific settings and
should not be created by +CGDCONT.
Reference: ETSI TS 127 007: AT command set for User Equipment (UE), section
10.1.0.
---
drivers/atmodem/gprs.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index 58d4eed3..bcf1eaaf 100644
--- a/drivers/atmodem/gprs.c
+++ b/drivers/atmodem/gprs.c
@@ -787,6 +787,13 @@ static void at_cgdcont_test_cb(gboolean ok, GAtResult *result,
if (found == FALSE)
goto error;
+ /*
+ * ETSI TS 127 007: profile 0 is manufacturer specific.
+ * Start from PDP/EPS context ID 1.
+ */
+ if (min <= 0)
+ min = 1;
+
ofono_gprs_set_cid_range(gprs, min, max);
g_at_chat_send(gd->chat, "AT+CGREG=?", cgreg_prefix,
--
2.17.1
2 years, 1 month
[PATCH] lte: Use the right D-Bus interface for property change signal
by Slava Monich
---
src/lte.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lte.c b/src/lte.c
index fbe0116..951a06f 100644
--- a/src/lte.c
+++ b/src/lte.c
@@ -212,7 +212,7 @@ static void lte_set_default_attach_info_cb(const struct ofono_error *error,
}
ofono_dbus_signal_property_changed(conn, path,
- OFONO_CONNECTION_CONTEXT_INTERFACE,
+ OFONO_LTE_INTERFACE,
key,
DBUS_TYPE_STRING, &value);
--
1.9.1
2 years, 1 month
[PATCH] cbs: Allow the last CBS fragment to be truncated
by Slava Monich
That does happen in real life.
---
src/smsutil.c | 23 +++++++++++++++--------
src/smsutil.h | 1 +
2 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/src/smsutil.c b/src/smsutil.c
index 8c084d4..450a1d3 100644
--- a/src/smsutil.c
+++ b/src/smsutil.c
@@ -1756,7 +1756,7 @@ gboolean sms_udh_iter_init_from_cbs(const struct cbs *cbs,
return FALSE;
hdr = cbs->ud;
- max_ud_len = 82;
+ max_ud_len = cbs->udlen;
/* Must have at least one information-element if udhi is true */
if (hdr[0] < 2)
@@ -3862,8 +3862,8 @@ gboolean cbs_dcs_decode(guint8 dcs, gboolean *udhi, enum sms_class *cls,
gboolean cbs_decode(const unsigned char *pdu, int len, struct cbs *out)
{
- /* CBS is always a fixed length of 88 bytes */
- if (len != 88)
+ /* CBS is (almost) always a fixed length of 88 bytes */
+ if (len < 6 || len > 88)
return FALSE;
out->gs = (enum cbs_geo_scope) ((pdu[0] >> 6) & 0x03);
@@ -3874,6 +3874,10 @@ gboolean cbs_decode(const unsigned char *pdu, int len, struct cbs *out)
out->max_pages = pdu[5] & 0xf;
out->page = (pdu[5] >> 4) & 0xf;
+ /* Allow the last fragment to be truncated */
+ if (len != 88 && out->max_pages != out->page)
+ return FALSE;
+
/*
* If a mobile receives the code 0000 in either the first field or
* the second field then it shall treat the CBS message exactly the
@@ -3885,7 +3889,10 @@ gboolean cbs_decode(const unsigned char *pdu, int len, struct cbs *out)
out->page = 1;
}
- memcpy(out->ud, pdu + 6, 82);
+ out->udlen = (guint8)(len - 6);
+ memcpy(out->ud, pdu + 6, out->udlen);
+ if (out->udlen < 82)
+ memset(out->ud + out->udlen, 0, 82 - out->udlen);
return TRUE;
}
@@ -4078,7 +4085,7 @@ char *cbs_decode_text(GSList *cbs_list, char *iso639_lang)
if (iso639)
bufsize -= 3;
} else {
- bufsize += 82;
+ bufsize += cbs->udlen;
if (iso639)
bufsize -= 2;
@@ -4095,7 +4102,7 @@ char *cbs_decode_text(GSList *cbs_list, char *iso639_lang)
if (sms_udh_iter_init_from_cbs(cbs, &iter))
taken = sms_udh_iter_get_udh_length(&iter) + 1;
- unpack_7bit_own_buf(cbs->ud + taken, 82 - taken,
+ unpack_7bit_own_buf(cbs->ud + taken, cbs->udlen - taken,
taken, false, 2,
NULL, 0,
(unsigned char *)iso639_lang);
@@ -4128,7 +4135,7 @@ char *cbs_decode_text(GSList *cbs_list, char *iso639_lang)
max_chars =
sms_text_capacity_gsm(CBS_MAX_GSM_CHARS, taken);
- unpack_7bit_own_buf(ud + taken, 82 - taken,
+ unpack_7bit_own_buf(ud + taken, cbs->udlen - taken,
taken, false, max_chars,
&written, 0, unpacked);
@@ -4162,7 +4169,7 @@ char *cbs_decode_text(GSList *cbs_list, char *iso639_lang)
* the check here since the specification isn't clear
*/
} else {
- int num_ucs2_chars = (82 - taken) >> 1;
+ int num_ucs2_chars = (cbs->udlen - taken) >> 1;
int i = taken;
int max_offset = taken + num_ucs2_chars * 2;
diff --git a/src/smsutil.h b/src/smsutil.h
index 0adba51..01487de 100644
--- a/src/smsutil.h
+++ b/src/smsutil.h
@@ -408,6 +408,7 @@ struct cbs {
guint8 dcs; /* 8 bits */
guint8 max_pages; /* 4 bits */
guint8 page; /* 4 bits */
+ guint8 udlen;
guint8 ud[82];
};
--
1.9.1
2 years, 1 month
Re: [PATCH] create stk atom for Esim Handling
by Denis Kenzior
Hi Shweta,
On 6/11/20 2:06 AM, shweta wrote:
> From: Shweta Jain <shweta2.jain(a)intel.com>
>
> ---
> plugins/xmm7xxx.c | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
This patch does not apply cleanly. In fact, I see three distinct series from
you and it isn't clear in what order I would even apply these. Since it looks
like all these series are related, can you please rebase all patches on top of
git HEAD (for example, via 'git pull --rebase') and resubmit the entire set as a
single series?
> diff --git a/plugins/xmm7xxx.c b/plugins/xmm7xxx.c
> index 6afc8cb..3959583 100644
> --- a/plugins/xmm7xxx.c
> +++ b/plugins/xmm7xxx.c
> @@ -123,6 +123,8 @@ struct xmm7xxx_data {
> int coex_lte_id;
> int coex_wlan_id;
> int coex_bt_id;
> + ofono_bool_t stk_enable;
> + ofono_bool_t enable_euicc;
> };
>
> /* eUICC Implementation */
> @@ -1888,7 +1890,10 @@ static void switch_sim_state_status(struct ofono_modem *modem, int status)
> ofono_phonebook_create(modem, 0, "atmodem", data->chat);
> data->sms_phonebook_added = TRUE;
> }
> -
> + break;
> + case 18:
> + data->enable_euicc=TRUE;
> + ofono_warn("Esim State With no Profile %d ", status);
why ofono_warn?
> break;
> default:
> ofono_warn("Unknown SIM state %d received", status);
> @@ -2077,15 +2082,24 @@ static void xmm7xxx_pre_sim(struct ofono_modem *modem)
> data->sim = ofono_sim_create(modem, OFONO_VENDOR_XMM, "atmodem",
> data->chat);
> xmm_euicc_enable(modem, data->chat);
> + ofono_stk_create(modem, OFONO_VENDOR_XMM, "atmodem", data->chat);
Generally STK isn't available until the PIN has been entered, and thus should be
available only in post_sim state. Is esim somehow different?
> }
>
> static void set_online_cb(gboolean ok, GAtResult *result, gpointer user_data)
> {
> struct cb_data *cbd = user_data;
> ofono_modem_online_cb_t cb = cbd->cb;
> + char * strng = cbd->cb;
What does this do??
> + DBG("");
Hmm, not sure what compiler you're using, but C99 doesn't support mixed
declarations and expressions. Nor does our coding style. Please move this
after all the variable declaration block.
> struct ofono_error error;
> -
> + struct ofono_modem *modem = cbd->data;
> + struct xmm7xxx_data *data = ofono_modem_get_data(modem);
> decode_at_error(&error, g_at_result_final_response(result));
> + if(data->enable_euicc==TRUE && data->stk_enable==TRUE )
> + {
> + g_at_chat_send(data->chat, "AT+CFUN=16", none_prefix,
> + NULL, NULL, NULL);
> + }
Okay, but this is not following our coding style. Refer to doc/coding-style.txt
for details.
> cb(&error, cbd->data);
> }
>
> @@ -2108,8 +2122,10 @@ static void xmm7xxx_set_online(struct ofono_modem *modem, ofono_bool_t online,
> data->coex_wlan_id = 0;
> g_at_chat_unregister(data->chat, data->coex_bt_id);
> data->coex_bt_id = 0;
> + data->stk_enable=FALSE;
> }
> -
> + else
> + data->stk_enable=TRUE;
Coding style is all wrong here...
> if (g_at_chat_send(data->chat, command, none_prefix,
> set_online_cb, cbd, g_free) > 0) {
> if (online)
>
Regards,
-Denis
2 years, 1 month