RE: [PATCH 04/16] emulator: Add APIs to send GAtServer result

>> Defines APIs to send final/intermediate/unsolicited result to DUN >> client. --- >> include/emulator.h | 2 ++ >> src/emulator.c | 28 ++++++++++++++++++++++++++++ >> src/ofono.h | 11 +++++++++++ >> 3 files changed, 41 insertions(+), 0 deletions(-) >> >> diff --git a/include/emulator.h b/include/emulator.h >> index 29e87b9..2a45c65 100644 >> --- a/include/emulator.h >> +++ b/include/emulator.h >> @@ -36,6 +36,8 @@ enum ofono_emulator_status { >> OFONO_EMULATOR_STATUS_DESTROY, >> }; >> >> +enum _GAtServerResult; >> + > > this is not good. It should not be needed outside of GAtChat. Why not > just include gatserver.h? My original purpose is to avoid including another gatserver header in .h file. So far, we don't include gatchat.h/gatserver.h in oFono core header file. > And in addition the _GAt declaration should never be used. Why not use > the typedef one? If we allow to include gatserver.h, this problem is gone. We do have typedef in gatserver.h.