I make a quick review, use checkpatch and post it.

Thanks for testing and sorry to not always take the time needed to propose a patch to mainline.

 

Christophe

 

On 10/26/2017 12:54 PM, Jonas Bonn wrote:

On 10/26/2017 12:43 PM, Christophe Ronco wrote:




Seems to be this:

i)  When the modem is first powered on, service discovery takes some time (more than 5 seconds)
ii)  The service discovery timeout fires before the QMI request returns so discover_reply gets called before discover_callback and things get cleaned up
iii)  Then the QMI request returns and discover_callback gets called even though the request has timed out in ii)

...and this is where things go wrong because the userdata pointer to discover_callback is probably no longer valid.

How do we handle the QMI request returning a _late_ response, i.e. after it technically has timed out?  I'll dig a bit more...

/Jonas


Hi Jonas,

When I look at my personal patches, it seems I've already seen that. Please find attached the patch I currently have in my setup on this subject.


Yes, that's exactly what I was just in the process of implementing.  Glad you beat me to it.  :)

I tested your patch and it solves the problem.  Can you submit it to the list?  If not, I will... :)

I think service_create_reply() has the same issue but I don't hit it in my setup..

Eswaran:  try the patch from Christophe... I'm 99% certain it solves your issue.

Sorry, I couldn’t able to run GDB on my test bench. So not able to provide the necessary core dumps. I applied the patch you had provided. This fixes the issue during enabling the modem.  

 

The ofono process is not getting exited when I run enable-modem.

             

But I am seeing some other issues. After starting the system ,I am running the scripts when I identify the modem device and ofono service is in active state.

 

/enable-modem

/online-modem

/list-modems à here I am checking the ofono sim interface for SIM card status. The ofono is reporting that SIM is not present even though the SIM card is attached to the system

 

            /offline-modem -> the ofono process gets exited.

 

I have attached the debug logs of ofono. I will try to get backtrace and post as soon as possible.

 


/Jonas


Christophe







_______________________________________________
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

 




_______________________________________________
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono