Re: [PATCH 0/6] PPP Patches v3
On Mon, 22 Mar 2010 21:51:38 -0700
Marcel Holtmann <marcel(a)holtmann.org> wrote:
So Denis and I looked through my changes and he figured out what
might
have broken it. So your attempt at doing code flow optimization with
g_list_length() throw me on the wrong error path. Please don't do this
since all the GLib functions will do proper empty list checking.
I reviewed your patch and it seems that you didn't break it this time :).
If you ever have questions about the code, feel free to ask me.