Re: [PATCH 07/18] isimodem: add wgmodem2.5 to devinfo
Hi,
2011/2/15 Andreas Westin <andreas.westin(a)stericsson.com>:
@@ -111,17 +115,22 @@ static void isi_query_manufacturer(struct
ofono_devinfo *info,
struct devinfo_data *dev = ofono_devinfo_get_data(info);
struct isi_cb_data *cbd = isi_cb_data_new(dev, cb, data);
+ if (cbd == NULL || dev == NULL)
+ goto error;
+
+ if (g_isi_client_resource(dev->client) == PN_MODEM_INFO) {
+ goto error;
+ } else {
+
So do I understand this right, that PN_MODEM_INFO doesn't return any
of manufacturer, model, revision, or serial information at all?
If so, then I don't understand why any of this code is here. To
implement the serial number query, you just need to implement and
register your custom devinfo driver in the U8500 plugin that reads the
serial from under /etc.
Cheers,
Aki