Re: [PATCH 3/4] Add: set_online and post_online methods to isimodem driver
Hi Aki,
On Thu, 2010-05-27 at 04:08 +0200, ext Denis Kenzior wrote:
> Hi Pekka,
>
> > +static bool mtc_state_cb(GIsiClient *client, const void *restrict
> > data, + size_t len, uint16_t object, void *opaque)
>
> We don't use bools in oFono, please fix this to use gboolean or an int.
Well, stdbool.h is what gisi uses currently. I've been meaning to
replace all occurrences with gboolean, but haven't gotten around to it
yet.
So I think this can be pushed, and the issue fixed aftrewards.
This is new code, so might as well be done properly. If the rest of the patch
is looking good to you, then just --amend it to get rid of the bool.
Regards,
-Denis