RE: [RFC] HFP support into oFono and BlueZ
Hi Padovan,
Gustavo F. Padovan wrote:
> New version of the patches. Known issues:
> "'org.bluez.HandsfreeAgent.Release' part not implemented" and
it's
> not working with more than one bluetooth devices in some cases.
> Comments are welcome.
>
Another new version of the patches. Now ofono query all bluetooth
devices and searches for the ones with Gateway interface. Bluez has
some fixes and now supports connection coming from the AG.
The patches are using a per-device agent as described by the last
version of Handsfree API.
I did not implemented yet 'org.bluez.HandsfreeAgent.Release'.
Comments are welcome. :)
Two small comments.
1. Remove unused variables.
make --no-print-directory all-am
CC plugins/hfp.o
cc1: warnings being treated as errors
plugins/hfp.c: In function ‘get_properties_cb’:
plugins/hfp.c:500: error: unused variable ‘err’
plugins/hfp.c: In function ‘list_devices_cb’:
plugins/hfp.c:529: error: unused variable ‘modem’
plugins/hfp.c: In function ‘hfp_probe’:
plugins/hfp.c:656: error: unused variable ‘data’
make[1]: *** [plugins/hfp.o] Error 1
make: *** [all] Error 2
2. You may use Linux kernel /scripts/checkpatch.pl to check your patch.
E.g, there're trailing space in 0002.patch line 832.
Regards,
Zhenhua