Re: [PATCH 0/6] PPP Patches v3

Hi Kristen, > > And there was another problem with one variable being > > guint16, but the is_option casts it back to guint8. We can't really have > > that. Once you start casting on that scale the compiler will not warn > > you about type mismatches or if the value of argument is too big for its > > type. > > Can you please let me know which git commit this fix you made was? I > want to review it because all of the option types should only be a byte > anyway, so I am trying to figure out if there was a mistake somewhere > where we were using is_option to examine a 16 bit value. I searched > through the git log and can't figure out where this change was. I > can see where you changed the option type we are comparing to a regular > guint to avoid compiler problems, but not the other issue you mentioned. I had a second look at these. It is the is_proto_handler actually and not the is_option. However that thing applies here. A helper function to find that handle would be better then manually coding g_list_find_custom in the functions. Regards Marcel