Re: [PATCH 2/2] atmodem: Add use of pin event *EPEV after sending PUK.

>> The MBM/STE modems send the unsolicited result code *EPEV to report when >> the PIN code has been inserted and accepted. > > I almost thought so, but I was not sure when adapting this for IFX. > >> diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c >> index 94658f2..3abd1d8 100644 >> --- a/drivers/atmodem/sim.c >> +++ b/drivers/atmodem/sim.c >> @@ -671,6 +671,16 @@ static void at_pin_send_puk_cb(gboolean ok, GAtResult *result, >> at_xsim_notify, >> FALSE, cbd, g_free); >> return; >> + case OFONO_VENDOR_MBM: >> + /* >> + * On the MBM modem, AT+CPIN? keeps returning SIM PIN >> + * for a moment after successful AT+CPIN="..", but then >> + * sends *EPEV when that changes. >> + */ >> + sd->ready_id = g_at_chat_register(sd->chat, "*EPEV", >> + at_epev_notify, >> + FALSE, cbd, g_free); >> + return; >> } > > Denis, I think we can merge the PIN entering and PUK entering code paths > into one. No need to keep them separate. > Or refactor the EPEV registration into a separate function. But either is fine with me.