Re: [RFC 1/1] GPRS Provisioning Plugin.
On Friday 08 July 2011 21:23:34 ext Denis Kenzior, you wrote:
Hi Oleg,
<snip>
> +static int gprs_provision(const char *mcc, const char *mnc,
> + const char *spn,
> + struct ofono_gprs_provision_data **settings,
> + int *count)
> +{
> + int i;
> + struct parser_data *data;
> + *settings = NULL;
> +
> + DBG("Provisioning for MCC %s, MNC %s, SPN '%s'",
> + mcc, mnc, spn);
> +
> + data = g_try_new0(struct parser_data, 1);
> + if (data == NULL)
> + return -ENOMEM;
> +
> + lookup_apn(mcc, mnc, NULL, data);
What I wonder is what is the overhead of the XML parser right now (e.g.
how long it takes on reasonable embedded hardware). If this takes a
while, then it might be better to pre-parse the mobile-provider-info db
during plugin initialization and not every time gprs_provision is
called. Otherwise we run the risk of hanging the daemon while the
provision settings are being looked up.
Provisioning should be a fairly rare occurence. Preparsing the table into
memory might be a waste of both CPU and memory in the common circumstances...
If you suspect the parser is slow (I doubt it, but I have not checked), then
it might be better to just do it in a separate thread in the rare cases that
you actually do need the data.
--
Rémi Denis-Courmont
http://www.remlab.net/