Re: [PATCH 1/4] bluetooth: only use bluetooth_refcount in bluetooth_ref/bluetooth_unref

Le 27/01/2011 16:12, Marcel Holtmann a écrit : > Hi Fred, > >> plugins/bluetooth.c | 14 +++++++++----- >> 1 files changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c >> index 93dd7a1..e59bd31 100644 >> --- a/plugins/bluetooth.c >> +++ b/plugins/bluetooth.c >> @@ -505,7 +505,7 @@ static guint adapter_added_watch; >> static guint adapter_removed_watch; >> static guint property_watch; >> >> -static void bluetooth_ref(void) >> +static int bluetooth_ref(void) >> { > > why are we now reverting something back that we already applied > upstream. Something is wrong here. I followed Padovan's comment on my first try for this patch : "bluetooth_refcount can only be read/write by bluetooth_ref/unref" which seems good to me