Re: [patch 3/6] LCP support
Hi Kristen,
Makefile.am | 6 -
gatchat/gatppp.c | 53 +++++++++
gatchat/gatppp_internal.h | 8 +
gatchat/gatppplcp.c | 244 ++++++++++++++++++++++++++++++++++++++++++++++
this should be gatchat/ppp_lcp.c
+void __ppp_set_auth(GAtPPP *ppp, guint8* auth_data)
+{
+ guint16 proto = ntohs(*(guint16 *)auth_data);
This are again one of these constructs that will break on non-x86
hardware.
I think you need to create ppp_get_unaligned and ppp_put_unaligned. If
all of them are be16 anyway, you could do ppp_get_unaligned_be16 etc.
Regards
Marcel