>> + if(app == NULL)
>> + return;
> Not our coding style. Also, the "Application" property should not
> disappear under you, so I would leave this check out.
Is it like this :
/* foo bar
* foo bar
For multi-line comments it the latter. See doc/coding-style.txt item M2.
For single line comments:
/* foo bar */ is acceptable.
However, I meant there's no space between if and () I believe.
>> + app = ofono_modem_get_string(modem, "Application");
>> + mdm = ofono_modem_get_string(modem, "Modem");
Here, I've realized I'm getting the "Modem" property but I'm not
opening it. Should I still get it here such that I could check that it
isn't NULL ? Or do you prefer it to be handled in gemalto_initialize() ?
I would check it here since the error path is easier.