10:37 a.m.
Hi Denis
On 12/22/2010 05:31 PM, ext Denis Kenzior wrote:
Hi Dara,
On 12/20/2010 07:36 PM, Dara Spieker-Doyle wrote:
> ---
> Makefile.am | 5 ++++-
> test/cdma-dial-number | 24 ++++++++++++++++++++++++
> test/cdma-hangup | 20 ++++++++++++++++++++
> test/cdma-list-call | 30 ++++++++++++++++++++++++++++++
> 4 files changed, 78 insertions(+), 1 deletions(-)
> create mode 100755 test/cdma-dial-number
> create mode 100755 test/cdma-hangup
> create mode 100755 test/cdma-list-call
>
Patch looks fine but does not apply cleanly without patch 4. Can you
also fix these:
> diff --git a/Makefile.am b/Makefile.am
> index 50e893f..32ded3d 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -431,7 +431,10 @@ test_scripts = test/backtrace \
> test/test-push-notification \
> test/test-smart-messaging \
> test/send-vcard \
> - test/set-tty
> + test/set-tty \
> + test/cdma-list-call \
> + test/cdma-dial-number \
> + test/cdma-hangup
>
> if TEST
> testdir = $(pkglibdir)/test
> diff --git a/test/cdma-dial-number b/test/cdma-dial-number
> new file mode 100755
> index 0000000..948d32d
> --- /dev/null
> +++ b/test/cdma-dial-number
> @@ -0,0 +1,24 @@
> +#!/usr/bin/python
> +
> +import sys
> +import dbus
> +
> +bus = dbus.SystemBus()
> +
> +manager = dbus.Interface(bus.get_object('org.ofono', '/'),
> + 'org.ofono.Manager')
> +
> +if len(sys.argv)> 2:
> + path = sys.argv[1]
> + number = sys.argv[2]
> +else:
> + modems = manager.GetModems()
> + path, properties = modems[0]
> + number = sys.argv[1]
> +
> +print "Using modem %s" % path
> +
> +manager = dbus.Interface(bus.get_object('org.ofono', path),
> + 'org.ofono.cdma.VoiceCallManager')
> +
> +manager.Dial(number)
> \ No newline at end of file
^^^^^
> diff --git a/test/cdma-hangup b/test/cdma-hangup
> new file mode 100755
> index 0000000..f8e631e
> --- /dev/null
> +++ b/test/cdma-hangup
> @@ -0,0 +1,20 @@
> +#!/usr/bin/python
> +
> +import sys
> +import dbus
> +
> +bus = dbus.SystemBus()
> +
> +manager = dbus.Interface(bus.get_object('org.ofono', '/'),
> + 'org.ofono.Manager')
> +
> +if len(sys.argv)> 2:
> + path = sys.argv[1]
> +else:
> + modems = manager.GetModems()
> + path, properties = modems[0]
> +
> +manager = dbus.Interface(bus.get_object('org.ofono', path),
> + 'org.ofono.cdma.VoiceCallManager')
> +
> +manager.Hangup()
> diff --git a/test/cdma-list-call b/test/cdma-list-call
> new file mode 100755
> index 0000000..9f9fdbc
> --- /dev/null
> +++ b/test/cdma-list-call
> @@ -0,0 +1,30 @@
> +#!/usr/bin/python
> +
> +import dbus
> +
> +bus = dbus.SystemBus()
> +
> +manager = dbus.Interface(bus.get_object('org.ofono', '/'),
> + 'org.ofono.Manager')
> +
> +modems = manager.GetModems()
> +
> +for path, properties in modems:
> + print "[ %s ]" % (path)
> +
> + if "org.ofono.cdma.VoiceCallManager" not in
properties["Interfaces"]:
> + continue
> +
> + mgr = dbus.Interface(bus.get_object('org.ofono', path),
> + 'org.ofono.cdma.VoiceCallManager')
> +
> + properties = mgr.GetProperties()
> +
> + for key in properties.keys():
> + if key in ["Interfaces", "Features"]:
> + val = ""
> + for i in properties[key]:
> + val += i + " "
> + else:
> + val = str(properties[key])
> + print " %s = %s" % (key, val)
> \ No newline at end of file
and ^^^^^^
Regards,
-Denis
Yes I'll clean these up with the new version
Thank you
Dara