Re: [patch 6/6] Allow gsmdial to use gatchat ppp support
On Sun, 14 Mar 2010 13:02:52 -0700
Marcel Holtmann <marcel(a)holtmann.org> wrote:
>
> +static void print_ip_address(guint32 ip_addr)
> +{
> + struct in_addr addr;
> + addr.s_addr = ip_addr;
> + g_print("%s\n", inet_ntoa(addr));
It is just fine to use printf() like everybody else. The g_print
function is pretty much stupid idea from GLib. Same as gchar should not
be used either.
The only case where g_print makes sense is in GLib based unit tests.
OK, but I think I should leave this the way it is just because it
is consistent with the rest of gsmdial.