RE: [PATCH v2] reopen once if open device failed
>
> (2) Fix Huawei NDIS modem gprs doesn't work issue
what does this comment mean. We should just not try the NDIS part of
Huawei until I get clear specs on how to use the NDIS port. Even the
basic AT^DHCP handling of this is unreliable.
I find this issue when I get a Huawei EM820W modem. I see according current
Implementation, gprs atom and context will not be created, because if NDIS
is supported, no device opened for data transmission. Please refer to function
huawei_enable() and post_online().
I don't have specs about how to use NDIS too. Here I just simply correct this
Issue.
>
> - if ((data->sim_state == HUAWEI_SIM_STATE_VALID ||
> - data->sim_state == HUAWEI_SIM_STATE_INVALID_CS) &&
> - data->modem != NULL) {
> + if (data->sim_state == HUAWEI_SIM_STATE_VALID ||
> + data->sim_state == HUAWEI_SIM_STATE_INVALID_CS) {
Why this change?
As above comment, because data->modem will always be NULL for modems support NDIS.
> data->gprs = ofono_gprs_create(modem, OFONO_VENDOR_HUAWEI,
> "atmodem", data->pcui);
>
> if (data->ndis == TRUE)
> data->gc = ofono_gprs_context_create(modem, 0,
> "huaweimodem", data->pcui);
> - else
> + else if (data->modem != NULL)
> data->gc = ofono_gprs_context_create(modem, 0,
> "atmodem", data->modem);
>
I do not understand this change.
data->modem may be NULL, due to open device fail.
Best regards
Caiwen